From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 3244CA0471
	for <public@inbox.dpdk.org>; Mon, 17 Jun 2019 11:27:01 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 6C5571BEA8;
	Mon, 17 Jun 2019 11:26:59 +0200 (CEST)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D6DDE1BE94;
 Mon, 17 Jun 2019 11:26:56 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 17 Jun 2019 02:26:55 -0700
X-ExtLoop1: 1
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by fmsmga004.fm.intel.com with ESMTP; 17 Jun 2019 02:26:54 -0700
Received: from irsmsx104.ger.corp.intel.com ([169.254.5.143]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.159]) with mapi id 14.03.0439.000;
 Mon, 17 Jun 2019 10:26:53 +0100
From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "Zhang, Roy
 Fan" <roy.fan.zhang@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code
Thread-Index: AQHVCzqu5YzdLmvqG0q7yQxUc7/Im6afxqbQ
Date: Mon, 17 Jun 2019 09:26:53 +0000
Message-ID: <6DC05C7C5F25994B81B3F2F214251F66020F7156@IRSMSX104.ger.corp.intel.com>
References: <20190515161948.70498-1-roy.fan.zhang@intel.com>
In-Reply-To: <20190515161948.70498-1-roy.fan.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzhhZTkzMWYtMmIzZS00ZmQ3LTg5YzctYTljYjcxYzA4MDE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRlVpdnJvdDNYUUV0bFdsd3dyUXJuaDBTVENzY2ErcXZsMk5USTNtU25aVTBtMXJMWTdCU01VcmhmTXFCRGhJeiJ9
x-ctpclassification: CTP_NT
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> Subject: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code
>=20
> This patch fixes a few same class bugs that causes the logically dead cod=
e in
> vhost_crypto.
>=20
> Coverity issue: 277236
> Coverity issue: 277233
> Coverity issue: 277220
> Coverity issue: 277214
>=20
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  lib/librte_vhost/vhost_crypto.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_cry=
pto.c
> index 0edf12d52..069b56108 100644
> --- a/lib/librte_vhost/vhost_crypto.c
> +++ b/lib/librte_vhost/vhost_crypto.c
> @@ -1024,7 +1024,7 @@ prepare_sym_chain_op(struct vhost_crypto
> *vcrypto, struct rte_crypto_op *op,
>  		}
>  		if (unlikely(copy_data(rte_pktmbuf_mtod(m_src, uint8_t *),
>  				vc_req, &desc, chain->para.src_data_len,
> -				nb_descs, vq_size)) < 0) {
> +				nb_descs, vq_size) < 0)) {
>  			ret =3D VIRTIO_CRYPTO_BADMSG;
>  			goto error_exit;
>  		}
> @@ -1598,7 +1598,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t
> qid,
>  			op->sym->m_dst->data_off =3D 0;
>=20
>  			if (unlikely(vhost_crypto_process_one_req(vcrypto,
> vq,
> -					op, head, desc_idx)) < 0)
> +					op, head, desc_idx) < 0))
>  				break;
>  		}

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>