DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
Date: Mon, 17 Jun 2019 09:26:58 +0000	[thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F66020F7166@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20190515162548.71498-1-roy.fan.zhang@intel.com>

> Subject: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return
> value
> 
> This patch tries to fix the coverity issue of unchecked return value. Since the
> function that causes the problem is unused, it is removed completely.
> 
> Coverity issue: 336816
> Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  examples/vhost_crypto/main.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index ac7118e7e..cfb9dfda2 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -354,12 +354,6 @@ static const struct vhost_device_ops
> virtio_crypto_device_ops = {
>  	.destroy_device = destroy_device,
>  };
> 
> -__attribute__((unused))
> -static void clrscr(void)
> -{
> -	system("@cls||clear");
> -}
> -
>  static int
>  vhost_crypto_worker(void *arg)
>  {

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>

  parent reply	other threads:[~2019-06-17  9:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 16:25 Fan Zhang
2019-05-15 16:25 ` Fan Zhang
2019-05-16  8:07 ` Jens Freimann
2019-05-16  8:07   ` Jens Freimann
2019-06-17  9:09   ` Zhang, Roy Fan
2019-06-19 11:56     ` Jens Freimann
2019-06-17  9:26 ` Kovacevic, Marko [this message]
2019-06-20  9:43 ` Maxime Coquelin
2019-06-24 12:25   ` Zhang, Roy Fan
2019-06-20  9:59 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6DC05C7C5F25994B81B3F2F214251F66020F7166@IRSMSX104.ger.corp.intel.com \
    --to=marko.kovacevic@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).