From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3254C23D for ; Mon, 18 Dec 2017 12:04:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2017 03:04:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,421,1508828400"; d="scan'208";a="185135811" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga005.jf.intel.com with ESMTP; 18 Dec 2017 03:04:56 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002; Mon, 18 Dec 2017 11:04:55 +0000 From: "Kovacevic, Marko" To: "Singh, Jasvinder" , "dev@dpdk.org" CC: "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow classify lib Thread-Index: AQHTdY9Oqc5yflumfE2LYHwThfpcAqNI6Xmg Date: Mon, 18 Dec 2017 11:04:54 +0000 Message-ID: <6DC05C7C5F25994B81B3F2F214251F6632AAEB@IRSMSX104.ger.corp.intel.com> References: <20171211162646.146936-1-jasvinder.singh@intel.com> <20171215103924.5185-1-jasvinder.singh@intel.com> <20171215103924.5185-4-jasvinder.singh@intel.com> In-Reply-To: <20171215103924.5185-4-jasvinder.singh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2JlOTY1MDItMjFiMi00ZDA5LWEwOWItY2NkZTA0MzhmYWU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjNVQ09yYzUxd1JFY1Y2RWtEM1wvam1IMUllZkxLVVR1d1ZtZmVVUlhCdms4PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow classify lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 11:04:58 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Friday, December 15, 2017 10:39 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard > Subject: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow cla= ssify > lib >=20 > Updates the documentation for flow classification library and sample > application. >=20 > Signed-off-by: Jasvinder Singh > v3: > - add validate API desciption to programmers guide Small typo desciption/ description > @@ -225,11 +236,16 @@ The ``Classifier`` has the following internal struc= tures: > /* Input parameters */ > char name[RTE_FLOW_CLASSIFIER_MAX_NAME_SZ]; > int socket_id; > - enum rte_flow_classify_table_type type; >=20 > - /* Internal tables */ > - struct rte_table tables[RTE_FLOW_CLASSIFY_TABLE_MAX]; > + /* Internal */ > + /* ntuple_fliter */ Small typo above. Ntuple_fliter/ ntuple_filter. > + struct rte_eth_ntuple_filter ntuple_filter; > + > + /* clasifier tables */ Same above clasifier / classifier =20 > To create an ACL table the ``rte_table_acl_params`` structure must be @@= - > 314,14 +329,14 @@ and SCTP. > RTE_FLOW_ITEM_TYPE_END, > }; >=20 > -The internal function ``flow_classify_parse_flow`` parses the > +The API function ``rte_flow_classify_validate`` parses the > IPv4 5-tuple pattern, attributes and actions and returns the 5-tuple dat= a in the > ``rte_eth_ntuple_filter`` structure. >=20 > .. code-block:: c >=20 > static int > - flow_classify_parse_flow( > + rte_flow_classify_validate(struct rte_flow_classifier *cls, > const struct rte_flow_attr *attr, > const struct rte_flow_item pattern[], > const struct rte_flow_action actions[], @@ -333,7 +34= 8,7 @@ > Adding Flow Rules The ``rte_flow_classify_table_entry_add`` API creates = an > ``rte_flow_classify`` object which contains the flow_classify id and type= , the > action, a union of add and delete keys and a union of rules. > -It uses the ``flow_classify_parse_flow`` internal function for parsing t= he > +It uses the ``rte_flow_classify_validate`` api function for parsing the Above api/ API Otherwise everything else seem ok Acked-by: Marko Kovacevic