From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 661151B425 for ; Tue, 6 Feb 2018 14:26:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 05:26:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,468,1511856000"; d="scan'208";a="17484802" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga002.fm.intel.com with ESMTP; 06 Feb 2018 05:26:14 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by irsmsx110.ger.corp.intel.com ([169.254.15.15]) with mapi id 14.03.0319.002; Tue, 6 Feb 2018 13:26:13 +0000 From: "Kovacevic, Marko" To: Stefan Hajnoczi , "dev@dpdk.org" CC: Maxime Coquelin , Yuanhan Liu , "Mcnamara, John" Thread-Topic: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c Thread-Index: AQHTnntLPjRAKaUMzEirBeeLsG2QY6OXXqSA Date: Tue, 6 Feb 2018 13:26:13 +0000 Message-ID: <6DC05C7C5F25994B81B3F2F214251F66343578@IRSMSX104.ger.corp.intel.com> References: <20180205121642.26428-1-stefanha@redhat.com> <20180205121642.26428-2-stefanha@redhat.com> In-Reply-To: <20180205121642.26428-2-stefanha@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmM1NjAxZTctMmEyOC00ZWYzLWFiM2YtMGM2YWYyNDA4OThlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik8yQnhJeFpDeHN0cW9JVWpWQTJad1JMSkdkUVVEemVEcGNCV0U3WG1QT2s9In0= x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 13:26:16 -0000 > Input validation is not applied consistently in vhost_user.c. This sugge= sts that > not everyone has the same security model in mind when working on the > code. >=20 > Make the security model explicit so that everyone can understand and foll= ow > the same model when modifying the code. >=20 > Signed-off-by: Stefan Hajnoczi > --- > lib/librte_vhost/vhost_user.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.= c <...> This is a useful comment but I don't know if it makes sense to include it i= n the vhost_user.c file.=20 Particularly at the top where it looks like a general descriptive comment f= or the file. It would probably be better in the vhost-user section of the programmer's g= uide: http://dpdk.org/doc/guides/prog_guide/vhost_lib.html Also, the subject line shouldn't include an underscore. Marko