From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5943A04EF; Mon, 25 May 2020 18:57:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96CC71D985; Mon, 25 May 2020 18:57:12 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id DD4791D942; Mon, 25 May 2020 18:57:09 +0200 (CEST) IronPort-SDR: 7rliXkjY8Z/Cs6vk8k0P0A3BF4EmkMO5f8wgjrFHzfrwB3Z6v6AXsRUE1O0/VxRzdMBNH4reGE RQ1Hged8hKjA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2020 09:57:08 -0700 IronPort-SDR: YX7OkIR5jQiJlk2MA2+Mw+KzuB19qcs07Cvh8Wla9yQQFifj/+C6Tc+80R9gF9s4wHA78ORmib u8XAsZABipbA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,434,1583222400"; d="scan'208";a="441783276" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 25 May 2020 09:57:07 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 May 2020 09:57:07 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 25 May 2020 09:57:07 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 25 May 2020 09:57:07 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.50) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 May 2020 09:57:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UHFiWF9OEtI6FQD5jGGNW4+0hVsj4+TJzzPWf0KzN3mzn2kxp/kFjdj++ERKkgWl0YXj0SB9kfCzVC/QHSUbsgObpvsURVYrFmcsEY8iOd574rnH51cBfIQUq4ecY9BDp5wclcj9RgT3gkHjE7cb6q8KljBFUwlFoHNT8aT9zjtQgF8gkhw5YJ0FXTFpaFRCG6sLVK4FaoFm6diBFmas7NwMX245sZQf3bLo2er4bsn02Yd2euoqvBlAPny7mzE8aYAqEH+Ihx6SXBoDiyiWjZnNjbUtIMTCKnN1059Ed+IQapERDZcC8KBn9loEJaqWgi04Lll9aOZdFULis9M6bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LkGfi42oHY+5rBwSIOh4kZZQFXGsc60jbfJSQJDze0=; b=MYpXMj8X6ZUsNeFNIDIBVv3dLgOUej8qgjWrG/oWN7It+JySdYDBhCw+9dTG2i04H6XlBeZXz6AQN5QZPY7ipfyGfclZ1gE4mGYpbi2UsWRfmnp+eqfa9NLBkItj9tkcLudNVYS2qdfq4s3zlYCmW8hXT24HkGyvCzZ1KUlFEf2Tpn2F3TpHUY6mgWSU+bsUoEVzIAS7n/Jf4htR26z5hGahBZQ84b9eW43k58MvE3IJxFFQKSIqMRg+6Hkt/zZuAFtHiBwx7xrQWeV3nl4+wCMdaO2bNxEWF/uqI+Iy9UBpx+ja7c8NIuNkK80a2ddCUNoh3oJF6fkVN2WpvKXmTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/LkGfi42oHY+5rBwSIOh4kZZQFXGsc60jbfJSQJDze0=; b=AQ5IL3LwIguU3JsgT7beK6PR38Zy5TQvgnRpVtzTL6O3XiOo3Pk5koRCGXqImNUk0sS7hRXDHd2IYRr8CrTXAULVXA3HHUCILzylu7c7AT2u7ja/2L8QGzqohsuItp0gmFw5dcEG94UvhYZcAXxcqSridZtd8jvhyEfJque8OC4= Received: from DM6PR11MB4593.namprd11.prod.outlook.com (2603:10b6:5:2a3::8) by DM6PR11MB3148.namprd11.prod.outlook.com (2603:10b6:5:6f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.27; Mon, 25 May 2020 16:57:04 +0000 Received: from DM6PR11MB4593.namprd11.prod.outlook.com ([fe80::acee:4fa2:2a9e:7cd6]) by DM6PR11MB4593.namprd11.prod.outlook.com ([fe80::acee:4fa2:2a9e:7cd6%3]) with mapi id 15.20.3021.029; Mon, 25 May 2020 16:57:04 +0000 From: "Wiles, Keith" To: Thomas Monjalon CC: Jerin Jacob , "Burakov, Anatoly" , =?iso-8859-1?Q?Morten_Br=F8rup?= , Maxime Coquelin , dpdk-dev , "techboard@dpdk.org" , "St Leger, Jim" Thread-Topic: [dpdk-dev] [dpdk-techboard] Consider improving the DPDK contribution processes Thread-Index: AQHWMrGtyXy39HWagEib7tmt6hmYvai5BaOA Date: Mon, 25 May 2020 16:57:04 +0000 Message-ID: <6E257791-337C-495A-9F23-0F385E5B075F@intel.com> References: <98CBD80474FA8B44BF855DF32C47DC35C60FEA@smartserver.smartshare.dk> <6512da71-09a0-3357-27b1-58939597bcf1@redhat.com> <1d1c7a90-934b-3db4-b7d6-308a0ebb7ee4@intel.com> <11959277.FkLDZFFinP@thomas> In-Reply-To: <11959277.FkLDZFFinP@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [47.24.6.94] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0cc0ba34-9550-41cd-752e-08d800cca6c0 x-ms-traffictypediagnostic: DM6PR11MB3148: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0414DF926F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: csKpILJcne3+3qyCwJu+ia6bwgi6Yu3k28DfGglpap4dNzJpOmvhqe8oNBeiZQDpewPvVJd8y8OGsMnqk8uKeuWnhuL8BI+FJemFLHKCHFfF98qDPtZOyHMYhkLQdK5y1N/S1hKKokvnFO+zQyTtwPC6/ZS/zXv/G2c2AL2ngrwRloccvZwHaikcSyXjS3sxYE8g4F4HcpjOtts2I4yAXUT+0QhmXNjwD7AA3tarfN3BQZOdVydVy8T9XB8Un+33rEvC3Boj3D4eWT1YkCgmI47odOHCjVjS33SwsgjVRzSvi+LtmbLff6iM1L7FMA1Yf1V+LTnh/uuBFy6klot1NyMbzbYIrXVRN9Aq6djNVGE/q6yAIT46u14KRkr/86ly4E7LmxfMDJ94u68vQPc/Wg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4593.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(366004)(396003)(39860400002)(376002)(346002)(2906002)(6916009)(8936002)(6486002)(36756003)(316002)(33656002)(5660300002)(2616005)(54906003)(4326008)(186003)(66946007)(64756008)(66476007)(76116006)(66446008)(66556008)(6512007)(478600001)(45080400002)(71200400001)(53546011)(26005)(966005)(6506007)(86362001)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: oElXKn86s2bJRCDTdhaLigwl3rc94v2c0/tCYi8Zy0TbomNzMcvkhO4NJRwmPDJgFA43ajBTbXaEZU1f1tBC8KeEVxSi9vz9tnWdebcAGktPSMk4KTDuPZ2z6ltcxWWbl3S56w5uVPZGmgyPT7HHWGFVN1uOBALdnmPG98Jf8atPDrPS4T3eq0S5s1TxnJpImssre3g8eHUrZbsgGARlRml/tOorWYrXenNZE2/6gbyE0NwzW2eCysZetQ3q7SyCy3pXAWmxn21Ym4jEQHgrb2KSac18W1S4JPhEXe8pjaqqSRlA77OE3TAURt8tPqBECXhNhMEpWUtD9nnVLdl0pDC/B7MLmn8KZeSkrGbwl5Cu+ZJSSciN6JqxkvxtWKzTVh35PMG955xx9OEJzFWUJ+VydzfUCG1iE3dZ35WH+e1BjaBj06ldry/DyYeAuNqeP4wiTZZkXLqEvBmRithkNTbwdamV+pEt9HfjyVAMR58= Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0cc0ba34-9550-41cd-752e-08d800cca6c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2020 16:57:04.2450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b5UeQd0i3BAtVfwuQ/IHSXXhKlUpRvQqW4gRgrsfi9SbNGXd4QyDY/MPYrNxPCpinAM4ZzRf1hGT7U0r0ENVRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3148 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-techboard] Consider improving the DPDK contribution processes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On May 25, 2020, at 11:28 AM, Thomas Monjalon wrote= : >=20 > 25/05/2020 18:09, Burakov, Anatoly: >> On 25-May-20 5:04 PM, Maxime Coquelin wrote: >>> On 5/25/20 5:59 PM, Burakov, Anatoly wrote: >>>> On 25-May-20 4:52 PM, Maxime Coquelin wrote: >>>>> On 5/25/20 5:35 PM, Jerin Jacob wrote: >>>>>> On May 25, 2020 Thomas Monjalon wrote: >>>>>>> My concern about clarity is the history of the discussion. >>>>>>> When we post a new versions in GitHub, it's very hard to keep track >>>>>>> of the history. >>>>>>> As a maintainer, I need to see the history to understand what happe= ned, >>>>>>> what we are waiting for, and what should be merged. >>>>>>=20 >>>>>> IMO, The complete history is available per pull request URL. >>>>>> I think, Github also email notification mechanism those to prefer to= see >>>>>> comments in the email too. >>>>>>=20 >>>>>> In addition to that, Bugzilla, patchwork, CI stuff all integrated in= to >>>>>> one place. >>>>>> I am quite impressed with vscode community collaboration. >>>>>> https://github.com/Microsoft/vscode/pulls >>>>>=20 >>>>> Out of curiosity, just checked the git history and I'm not that >>>>> impressed. For example last commit on the master branch: >>>>>=20 >>>>> https://github.com/microsoft/vscode/commit/2a4cecf3f2f72346d06990feeb= 7446b3915d6148 >>>>>=20 >>>>>=20 >>>>> Commit title: " Fix #98530 " >>>>> Commit message empty, no explanation on what the patch is doing. >>>>>=20 >>>>> Then, let's check the the issue it is pointed to: >>>>> https://github.com/microsoft/vscode/issues/98530 >>>>>=20 >>>>> Issue is created 15 minutes before the patch is being merged. All tha= t >>>>> done by the same contributor, without any review. >>>>>=20 >>>>=20 >>>> Just because they do it wrong doesn't mean we can't do it right :) Thi= s >>>> says more about Microsoft's lack of process around VSCode than it does >>>> about Github the tool. >>>>=20 >>>=20 >>> True. I was just pointing out that is not the kind of process I would >>> personally want to adopt. >>>=20 >>=20 >> You won't find disagreement here, but this "process" is not due to the=20 >> tool. You can just as well allow Thomas to merge stuff without any=20 >> review because he has commit rights, no Github needed - and you would be= =20 >> faced with the same problem. >>=20 >> So, i don't think Jerin was suggesting that we degrade our merge/commit= =20 >> rules. Rather, the point was that (whatever you think of VSCode's=20 >> review/merge process) there are a lot of pull requests and there is=20 >> healthy community collaboration. I'm not saying we don't have that, >=20 > Yes, recent survey said the process was fine: > http://mails.dpdk.org/archives/announce/2019-June/000268.html IMO the survey is not a great tool for these types of things. The tech boar= d and others that fully understand the process should decide. From my exper= ience using Github or Gitlab is much easy and a single tool to submit patch= es to a project. Anatoly and others stated it very well and we should conve= rt IMO, as I have always stated in the past. >=20 >=20 >> obviously, but i have a suspicion that we'll get more of it if we lower= =20 >> the barrier for entry (not the barrier for merge!). I think there is a=20 >> way to lower the secondary skill level needed to contribute to DPDK=20 >> without lowering coding/merge standards with it. >=20 > About the barrier for entry, maybe it is not obvious because I don't > communicate a lot about it, but please be aware that I (and other > maintainers I think) are doing a lot of changes in newcomer patches > to avoid asking them knowing the whole process from the beginning. > Then frequent contributors get educated on the way. >=20 > I think the only real barrier we have is to sign the patch > with a real name and send an email to right list. > The ask for SoB real name is probably what started this thread > in Morten's mind. And the SoB requirement will *never* change. >=20 >=20 Would it not free up your time and energies by have the tools do most of th= e work. then you can focus on what matters the patch and developing more fe= atures?=20 There is a reasons millions of developer use one of these two tools, instea= d of emailing patch around. We are a fairly small project compared to Linux= Kernel and we are not developing code for the Linux kernel. Some of the pr= ocess like coding standard is great, but the rest is just legacy IMO and no= t required to get the job done. Having tools to keep track of the minutia s= hould free up more of your time for the real development. Yes, it will be a learning curve for some and nailing down the process or r= ules for merge requests needs to be done. All in all it will be a huge improvement for contributors.