From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB0C2A052B; Wed, 29 Jul 2020 04:28:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44A454C98; Wed, 29 Jul 2020 04:28:27 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2A0634C93 for ; Wed, 29 Jul 2020 04:28:24 +0200 (CEST) IronPort-SDR: t2XKnbLuX5uXKePbJH1eb1qTvkU3K8PkvB1utEJXG12vHbC9WtG48D8hP77xOaijFFBPrPrz3K P4X7Im5bhgPw== X-IronPort-AV: E=McAfee;i="6000,8403,9696"; a="215851876" X-IronPort-AV: E=Sophos;i="5.75,408,1589266800"; d="scan'208";a="215851876" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2020 19:28:24 -0700 IronPort-SDR: ++JZ5aM3bQeMSlnAsDPIkTmZ7CQBzur8ek6R++nnaIfpExBWNh0yT2k+iT+uLhk5u066LwO2UV X3bl+a136yNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,408,1589266800"; d="scan'208";a="464708477" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 28 Jul 2020 19:28:24 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Jul 2020 19:28:23 -0700 Received: from cdsmsx151.ccr.corp.intel.com (172.17.4.38) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Jul 2020 19:28:23 -0700 Received: from cdsmsx102.ccr.corp.intel.com ([169.254.2.201]) by CDSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0439.000; Wed, 29 Jul 2020 10:28:19 +0800 From: "Xie, WeiX" To: "Zhang, Yuying" , "dev@dpdk.org" , "olivier.matz@6wind.com" , "Zhang, Qi Z" , "Yang, Qiming" CC: "Zhang, Yuying" Thread-Topic: [dpdk-dev] [PATCH v2 1/1] net: fix TSO packets checksum incorrect Thread-Index: AQHWZQIxlmt0qHRjhk+9AcY/quntG6kd1bFg Date: Wed, 29 Jul 2020 02:28:18 +0000 Message-ID: <6FD6A7610D20924F885A4ECF34E8AC910463FEAA@CDSMSX102.ccr.corp.intel.com> References: <20200728085531.204296-1-yuying.zhang@intel.com> <20200728170950.208532-1-yuying.zhang@intel.com> In-Reply-To: <20200728170950.208532-1-yuying.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.17.6.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/1] net: fix TSO packets checksum incorrect X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Zhang, XiX Regards, Xie Wei -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yuying Zhang Sent: Wednesday, July 29, 2020 1:10 AM To: dev@dpdk.org; olivier.matz@6wind.com; Zhang, Qi Z ; Yang, Qiming Cc: Zhang, Yuying Subject: [dpdk-dev] [PATCH v2 1/1] net: fix TSO packets checksum incorrect The ol_flags check lacks of flag for IPv6 which causes checksum flag config= uration error while IPv6/TCP TSO packet is sent. This patch fixes the issue by adding PKT_TX_TCP_SEG flag. Fixes: 520059a41aa9 ("net: check fragmented headers in non-debug as well") Signed-off-by: Yuying Zhang --- lib/librte_net/rte_net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h index 1edc= 283a4..94b06d9ee 100644 --- a/lib/librte_net/rte_net.h +++ b/lib/librte_net/rte_net.h @@ -125,7 +125,7 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, u= int64_t ol_flags) * Mainly it is required to avoid fragmented headers check if * no offloads are requested. */ - if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK))) + if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | PKT_TX_TCP_SEG))) return 0; =20 if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) -- 2.25.1