From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C11CA09DE; Thu, 12 Nov 2020 21:16:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D6D75937; Thu, 12 Nov 2020 21:16:15 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 9875C56A3 for ; Thu, 12 Nov 2020 21:16:13 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id p8so7375907wrx.5 for ; Thu, 12 Nov 2020 12:16:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=1e214Pw6tEbwAgLJK8NuUvyxkP3t47wWhdOXDnSvbqo=; b=EDVBG4IRkrJwP+Yyw7rRMHyv6nldIAbAkUr7XWJkWywUY2AFl6erRtoQu7iboajRj5 yPMsWDuD/k3IoJeAh/TIel3SVaZA9WIf/KAwQwI7T8Zu6EMU6DHna8EMTP0Jkij6b8ZO fFjC6Lb1wesvA9SBA21VZ8pWb1sO2iXnE8F88jWHolLEIywpQ5pFyDAPVyzgjmDGd6Pq +Oai1pVsZDcjG3uPRlHYELpc1KkI7O6enGPVgqKjdNBzcuMNXa39/jT20We9vwo+3R4i t4ZxrkAh+7QDilm23VRw7wg/0HnfT+lfYIe2SiDil15+p7mfKG7F2sTMADi0e+MVvRfD iqaQ== X-Gm-Message-State: AOAM532w82e8icCoKW6Fp1EopA3gfWGIvQUovWOAoyaFDMCOllZI3XaS aEROovhXanzAM7mS8ISyOImpd339SqbtAg== X-Google-Smtp-Source: ABdhPJzlEXJIubNfAscSEnG980CfrpAW8j7zXhMyxCU2JTRxfovqFfp8f1gosxdX0NV3U2eRBri4Qw== X-Received: by 2002:adf:e28c:: with SMTP id v12mr1465186wri.230.1605212172342; Thu, 12 Nov 2020 12:16:12 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id w1sm7371671wmi.24.2020.11.12.12.16.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 12:16:11 -0800 (PST) Message-ID: <6a189e2a221f2d568a406a6e78e1f99d4aad24a7.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon , Dmitry Kozlyuk Cc: dev@dpdk.org, Narcisa Ana Maria Vasile , John Alexander Date: Thu, 12 Nov 2020 20:16:11 +0000 In-Reply-To: References: <20201029225505.30093-1-dmitry.kozliuk@gmail.com> <3042169.36grohAEOo@thomas> <805419dbc589b31f01e8864004a5c2a59dfd6e78.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2020-11-11 at 15:09 +0000, Luca Boccassi wrote: > On Wed, 2020-11-11 at 15:03 +0000, Luca Boccassi wrote: > > On Wed, 2020-11-11 at 16:02 +0100, Thomas Monjalon wrote: > > > 29/10/2020 23:55, Dmitry Kozlyuk: > > > > MSBuild XML files have to use CRLF line-endings, otherwise any chan= ge > > > > results in the whole file being rewritten with CRLF line-endings by > > > > Visual Studio. However, it's inconvenient to have such files checke= d-out > > > > with CLRF in Unix environments. > > > >=20 > > > > Add suggested git configuration to top-level README, so that Unix > > > > developers don't miss it. Remove .gitattributes, because core.autoc= rlf > > > > overrides eol=3D attribute. Convert line-endings of the existing fi= les in > > > > the repository. > > >=20 > > > It is converted to what? > > > You mean all files should have LF endings in the repo? > > >=20 > > > [...] > > > > windows/virt2phys/virt2phys.sln | 54 ++-- > > > > windows/virt2phys/virt2phys.vcxproj | 454 ++++++++++++++----------= ---- > > > > 4 files changed, 259 insertions(+), 258 deletions(-) > > >=20 > > > The file windows/virt2phys/virt2phys.vcxproj.filters is not converted= . > > > And I see other stuff to fix, see below. > > >=20 > > > > +Some Windows files use have to use CRLF line-endings. > > >=20 > > > "use have to use" -> "have to use" ? > > >=20 > > > Isn't it automatic to have CRLF on Windows git working tree? > > >=20 > > > > +Unix developers can configure git to get only LF on checkout: > > > > + > > > > + git config core.autocrlf input > > >=20 > > > Isn't it the default? > > > If all files have LF, there is nothing to do on Unix. > > >=20 > > >=20 > > > I think more fixes are required as below: > >=20 > > <..> > >=20 > > Yes, I second that - those changes are needed too. >=20 > To clarify, having some options that convert after the fact > (clone/checkout) is _not_ a solution - everything needs to be checked > in with LF endings only, otherwise automated infrastructure (where > setting random configs it's just not an option) will break. Took the initiative and sent a v2 that changes all the files. --=20 Kind regards, Luca Boccassi