From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Sean Morrissey <sean.morrissey@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] devtools: export title syntax data for check-git-log
Date: Mon, 24 Feb 2020 14:38:12 +0000 [thread overview]
Message-ID: <6a1a93ae-d78e-69f1-7483-7375f8730ee7@intel.com> (raw)
In-Reply-To: <2509081.uZKlY2gecq@xps>
On 2/24/2020 1:39 PM, Thomas Monjalon wrote:
> 24/02/2020 13:02, Ferruh Yigit:
>> From: Sean Morrissey <sean.morrissey@intel.com>
>>
>> Moved title syntax to a separate file so that it improves code
>> readability and allows easy addition.
>>
>> Also logic changed from checking for bad pattern to checking good
>> pattern which documents the expected syntax more clearly, and does not
>> have gaps in the checks.
>>
>> Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> v2:
>> * renamed data file to words-case.txt and added to MAINTAINERS file
>> * Updated script
>> * as of now vdpa as file prefix is giving false positive
>
> False positive can be avoided if filtering out what is before the first colon.
>
It can, wasn't sure to add more work/check just to cover this case.
Also it is possible to introduce additional check for 'vdpa' only, right now it
is the only case that hits the file prefix.
Do you have a preference?
next prev parent reply other threads:[~2020-02-24 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 9:59 [dpdk-dev] [PATCH] devtools: export title syntax " Sean Morrissey
2019-10-25 13:44 ` Ferruh Yigit
2020-02-22 20:38 ` Thomas Monjalon
2020-02-24 12:02 ` [dpdk-dev] [PATCH v2] devtools: export title syntax data " Ferruh Yigit
2020-02-24 13:39 ` Thomas Monjalon
2020-02-24 14:38 ` Ferruh Yigit [this message]
2020-02-24 15:30 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2020-02-25 20:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a1a93ae-d78e-69f1-7483-7375f8730ee7@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=sean.morrissey@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).