From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) by dpdk.org (Postfix) with ESMTP id 446017D52 for ; Wed, 23 Aug 2017 14:56:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2530; q=dns/txt; s=iport; t=1503493000; x=1504702600; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=M6aREQtsrdsP8HWXrSixd0e7LemK1JeiHwzREmczx0U=; b=jH+gFqe2aYDV4fP+o303aUzrW+eovoxtEzQuRcn/QtwofNef2Vl2A308 uC3tSTf81cwuBeK8dglemZB3tHBenyRIWY6zU6pKYmamMdWJXNUlzXigX CN4d3p3Zlq4q73dP0RMw5zAg3KcK/iPTfu6zP1ZhuL9sZBL0gSKia8Zjf s=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CfAAAIe51Z/4UNJK1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1qBeQeODZAagXCWJA6CBIVHAoRDPxgBAgEBAQEBAQFrKIUYAQE?= =?us-ascii?q?BAQIBJxM/BQcEAgEIEQQBAR8JBzIUCQgCBAENBQiKIQiwMjqLbQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBAR2DKoICgUyFCoRchgsFoFgCiymJEIIbkFJIiSeMPgEfOIE?= =?us-ascii?q?KdxWHY3aJcoEPAQEB?= X-IronPort-AV: E=Sophos;i="5.41,417,1498521600"; d="scan'208";a="475746861" Received: from alln-core-11.cisco.com ([173.36.13.133]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 23 Aug 2017 12:56:38 +0000 Received: from XCH-ALN-019.cisco.com (xch-aln-019.cisco.com [173.36.7.29]) by alln-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id v7NCucp0009293 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 23 Aug 2017 12:56:38 GMT Received: from xch-rcd-016.cisco.com (173.37.102.26) by XCH-ALN-019.cisco.com (173.36.7.29) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 23 Aug 2017 07:56:38 -0500 Received: from xch-rcd-016.cisco.com ([173.37.102.26]) by XCH-RCD-016.cisco.com ([173.37.102.26]) with mapi id 15.00.1210.000; Wed, 23 Aug 2017 07:56:38 -0500 From: "David Harton (dharton)" To: "Ananyev, Konstantin" , "wenzhuo.lu@intel.co" CC: "dev@dpdk.org" Thread-Topic: [PATCH] ixgbe: initialize scattered_rx during dev_configure Thread-Index: AQHTG6/WB/ALDTQiTESWrP4e7/srgKKSEmqA///KsUA= Date: Wed, 23 Aug 2017 12:56:38 +0000 Message-ID: <6a28e8c0c8a64733a5f1bbbbe22c8c78@XCH-RCD-016.cisco.com> References: <20170823013333.40576-1-dharton@cisco.com> <2601191342CEEE43887BDE71AB977258489B4F98@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258489B4F98@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.82.213.192] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ixgbe: initialize scattered_rx during dev_configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 12:56:40 -0000 > -----Original Message----- > From: Ananyev, Konstantin [mailto:konstantin.ananyev@intel.com] > Sent: Wednesday, August 23, 2017 6:32 AM > To: David Harton (dharton) ; wenzhuo.lu@intel.co > Cc: dev@dpdk.org > Subject: RE: [PATCH] ixgbe: initialize scattered_rx during dev_configure >=20 > Hi David, >=20 > > > > An application may want to manipulate the MTU settings of a device > > without having to start the device first. > > In order to remove the need to start the device the ixgbe/ixgbevf > > drivers need to initialize the scattered_rx value during > > dev_configure. >=20 > Not sure how that would help? > As I can see ixgbe_dev_mtu_set() uses rx_conf->enable_scatter to check is > multiseg RX allowed or not. Hi Konstantin, I see. The problem has been fixed already. Originally (v2.2), the check i= n ixgbe_dev_mtu_set() was made against dev->data->scattered_rx but it has b= een changed. Sorry, I'll rescind the request. Thanks! Dave > Konstantin >=20 > > > > Signed-off-by: David Harton > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index 22171d8..e85bdb4 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -2372,6 +2372,13 @@ static int eth_ixgbevf_pci_remove(struct > rte_pci_device *pci_dev) > > intr->flags |=3D IXGBE_FLAG_NEED_LINK_UPDATE; > > > > /* > > + * Update scattered_rx so we can update MTU immediately > > + * following configure without having to start the device > > + */ > > + if (dev->data->dev_conf.rxmode.enable_scatter) > > + dev->data->scattered_rx =3D 1; > > + > > + /* > > * Initialize to TRUE. If any of Rx queues doesn't meet the bulk > > * allocation or vector Rx preconditions we will reset it. > > */ > > @@ -4949,6 +4956,13 @@ static int > > ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > > #endif > > > > /* > > + * Update scattered_rx so we can update MTU immediately > > + * following configure without having to start the device > > + */ > > + if (dev->data->dev_conf.rxmode.enable_scatter) > > + dev->data->scattered_rx =3D 1; > > + > > + /* > > * Initialize to TRUE. If any of Rx queues doesn't meet the bulk > > * allocation or vector Rx preconditions we will reset it. > > */ > > -- > > 1.8.3.1