From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DE73D4593A;
	Sun,  8 Sep 2024 10:32:48 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id ADFA840295;
	Sun,  8 Sep 2024 10:32:48 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id BF59B4026F
 for <dev@dpdk.org>; Sun,  8 Sep 2024 10:32:46 +0200 (CEST)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 262B140
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1725784365;
 bh=xDXQZrrdBSLttp82weS1lVU+E/OaDAN9ASkr0/Ixiow=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=gOtZYoK6hs29X9vysrOI0Wij2SfvQQfdWEvwXDL09+sceqwZAPmt+q552+iQdtrV3
 dhg27gTG100eQZfTvPw2rnuHZzlWssBxXFyAFIrFoRMS6E7/3b6uSmutnpwdtotwQq
 Bh+C2G1tblN9iGW9r6EVbd0ehVicKHEqH4shgtZc=
Received: from [192.168.1.38] (unknown [188.170.82.189])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 262B140;
 Sun,  8 Sep 2024 11:32:45 +0300 (MSK)
Message-ID: <6a32ac92-1513-4c62-b201-3f99dacf5aab@oktetlabs.ru>
Date: Sun, 8 Sep 2024 11:32:44 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: virtio: RSS support capa
To: =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,
 maxime.coquelin@redhat.com, Chenbo Xia <chenbox@nvidia.com>,
 thomas@monjalon.net, Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org
References: <98CBD80474FA8B44BF855DF32C47DC35E9F6BB@smartserver.smartshare.dk>
 <98CBD80474FA8B44BF855DF32C47DC35E9F6BD@smartserver.smartshare.dk>
Content-Language: en-US
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F6BD@smartserver.smartshare.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 9/7/24 23:55, Morten Brørup wrote:
>> From: Morten Brørup [mailto:mb@smartsharesystems.com]
>> Sent: Friday, 6 September 2024 21.38
>>
>> Maxime, Chenbo,
>>
>> If the virtio PMD supports RSS, it should be announced in its
>> capabilities.
>>
>> I think this should be added to virtio_dev_info_get():
>>
>> 	if (host_features & (1ULL << VIRTIO_NET_F_RSS))
>> 		dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_RSS_HASH;
> 
> Or perhaps I'm misunderstanding this capability flag.
> 
> I thought it indicated RSS ability, i.e. multi-queue, effectively shadowing rte_eth_conf.rxmode.mq_mode RTE_ETH_MQ_RX_RSS_FLAG.
> But maybe it doesn't. Maybe it indicates the ability to store the RSS hash value in the mbuf.
> 
> The RTE_ETH_RX_OFFLOAD_RSS_HASH flag is completely undocumented.
> 
> Can someone please clarify?
>
RTE_ETH_RX_OFFLOAD_RSS_HASH means that the driver can provide RSS hash
value in mbuf (it makes sense if HW can provide it to the driver).