From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 994BE42D70; Tue, 27 Jun 2023 11:33:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 778484113F; Tue, 27 Jun 2023 11:33:00 +0200 (CEST) Received: from forward500b.mail.yandex.net (forward500b.mail.yandex.net [178.154.239.144]) by mails.dpdk.org (Postfix) with ESMTP id 92EE740F18 for ; Tue, 27 Jun 2023 11:32:58 +0200 (CEST) Received: from mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:150a:0:640:1aa5:0]) by forward500b.mail.yandex.net (Yandex) with ESMTP id E2FBC5E620; Tue, 27 Jun 2023 12:32:57 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id tWHExc6WniE0-hTbzVnk4; Tue, 27 Jun 2023 12:32:57 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1687858377; bh=n/SkJr6rXwNwETwz1N0mCax7azzLz0fjLfzMWGYPeLQ=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=gzT1cf1ET6nrQhREAkSMRVh0e0amRBHkPg44e6vyYPkNPreiU1pytV9Bzt6ECm+3b vg99Y3ixhgli2e9C0xYi+hb26R///eqxg5+uarMZUI5IseCbtNdX8sJc+6E1GDTp3P YYyzRKVDHPiFMZNMkAn6fMA7PxF8lLf/HI/Cg+98= Authentication-Results: mail-nwsmtp-smtp-production-main-60.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <6a58c9ad-baf1-2dde-6c0c-35d058ba1061@yandex.ru> Date: Tue, 27 Jun 2023 10:32:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 8/9] build: make fragmentation library optional Content-Language: en-US To: Bruce Richardson , dev@dpdk.org Cc: =?UTF-8?Q?Morten_Br=c3=b8rup?= , pbhagavatula@marvell.com References: <20230622134840.3225975-1-bruce.richardson@intel.com> <20230623150708.2203918-1-bruce.richardson@intel.com> <20230623150708.2203918-9-bruce.richardson@intel.com> From: Konstantin Ananyev In-Reply-To: <20230623150708.2203918-9-bruce.richardson@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/06/2023 16:07, Bruce Richardson пишет: > This library is not essential for most DPDK uses, so mark it as optional > in the build config. > > Signed-off-by: Bruce Richardson > Acked-by: Morten Brørup > --- > app/test/meson.build | 6 ++++-- > lib/meson.build | 1 + > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/app/test/meson.build b/app/test/meson.build > index 0a971997a5..2e447e3402 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -56,7 +56,6 @@ test_sources = files( > 'test_hash_perf.c', > 'test_hash_readwrite_lf_perf.c', > 'test_interrupts.c', > - 'test_ipfrag.c', > 'test_ipsec.c', > 'test_ipsec_sad.c', > 'test_ipsec_perf.c', > @@ -173,7 +172,6 @@ fast_tests = [ > ['func_reentrancy_autotest', false, true], > ['hash_autotest', true, true], > ['interrupt_autotest', true, true], > - ['ipfrag_autotest', false, true], > ['lcores_autotest', true, true], > ['logs_autotest', true, true], > ['lpm_autotest', true, true], > @@ -376,6 +374,10 @@ if dpdk_conf.has('RTE_LIB_GRAPH') > test_sources += 'test_graph_perf.c' > perf_test_names += 'graph_perf_autotest' > endif > +if dpdk_conf.has('RTE_LIB_IP_FRAG') > + test_sources += 'test_ipfrag.c' > + fast_tests += [['ipfrag_autotest', false, true]] AFAIK, there is a new patch in flight to add new ip_frag perf autotest: http://patchwork.dpdk.org/project/dpdk/patch/20230602170147.4828-2-pbhagavatula@marvell.com/ Probably need to be synced with these changes too.. > +endif > if dpdk_conf.has('RTE_LIB_METRICS') > test_sources += ['test_metrics.c'] > fast_tests += [['metrics_autotest', true, true]] > diff --git a/lib/meson.build b/lib/meson.build > index 757c1a63e9..ea351b236a 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -83,6 +83,7 @@ optional_libs = [ > 'gro', > 'gso', > 'kni', > + 'ip_frag', > 'jobstats', > 'latencystats', > 'member', Acked-by: Konstantin Ananyev