From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 076173DC; Wed, 22 Aug 2018 18:00:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2018 09:00:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,274,1531810800"; d="scan'208";a="82510912" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by fmsmga004.fm.intel.com with ESMTP; 22 Aug 2018 09:00:11 -0700 From: Ferruh Yigit To: Alejandro Lucero , dev@dpdk.org Cc: stable@dpdk.org References: <1531156496-1702-1-git-send-email-alejandro.lucero@netronome.com> <8ccb1427-34ad-be2b-26e7-11439798fb92@intel.com> Openpgp: preference=signencrypt Message-ID: <6a63d8a4-f51d-b266-9877-73775145b52f@intel.com> Date: Wed, 22 Aug 2018 17:00:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <8ccb1427-34ad-be2b-26e7-11439798fb92@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/2] support MAC changes when no live changes allowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 16:00:13 -0000 On 7/18/2018 9:58 AM, Ferruh Yigit wrote: > On 7/9/2018 6:14 PM, Alejandro Lucero wrote: >> This is a patched to fix a functionality coming with the first public >> release: changing/setting MAC address. >> >> The original patch assumes all NICs can safely change or set the MAC >> in any case. However, this is not always true. NFP depends on the firmware >> capabilities and this is not always supported. There are other NICs with >> this same limitation, although, as far as I know, not in DPDK. Linux kernel >> has a IFF_LIVE_ADDR_CHANGE flag and two NICs are checking this flag for >> allowing or not live MAC changes. >> >> The flag proposed in this patch is just the opposite: advertise if live >> change not supported and assuming it is supported other way. >> >> Although most NICs support rte_eth_dev_default_mac_addr_set and this >> function returns and error when live change is not supported, note that >> this function is invoked during port start but the value returned is not >> checked. It is likely this is good enough for most of the cases, but >> bonding is relying on this start then mac set/change, and a PMD ports is >> not properly configured for being used as an slave port in some bonding >> modes. > > Hi Alejandro, > > Overall looks good to me, only it can be good to update "rte_eth_dev_start" API > doc to mention about affect of new flag and perhaps update release notes "API > Changes" section to document behavior change of the "rte_eth_dev_start" API > based on flag. Would you mind sending a new version for this release, v18.11, with above documentation update? Thanks, ferruh > > But, the ethdev library patch was late for this release, I suggest considering > the patch for next release, meanwhile it can get more reviews. > > Thanks, > ferruh >