From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15679A00BE; Wed, 20 Apr 2022 14:47:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A43A540C35; Wed, 20 Apr 2022 14:47:14 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 44562406A2 for ; Wed, 20 Apr 2022 14:47:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650458833; x=1681994833; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=57TvBIXNAM8USgz7+1Km4g6yU4sGIU2bre5N+5no7Ks=; b=c7Qz4Ux773qqIoj64ztWDrVVIeYwlqZryNxRUwDvQN3GhSKZ5i+grOGz zfpRD81+nEM6cMvfgQ4mOQHemyYNXFWooLomahfWKRR4wGCG8AHl4NQR/ HumJHJHWsGnjx5c82dgPYphJkP4FSyxVhPT70UQyeZzMAtEfhfSSDEAQY UmjgY1+/8gWTwsSoDodQifaJiwaGkbRxe1oPleATZUBHYC9gnUXtMZKg6 eSheiV5m6zJcmyHvqJszrelxB1F3bEIitmYiYu9A9TiuIqQf99/cuFR9w yYXwp98QI3ZbWHEwFxe00lr6c7pcPuWPFuQKQg07tCH8UVrxLZ+TEK2NB A==; X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="244599119" X-IronPort-AV: E=Sophos;i="5.90,275,1643702400"; d="scan'208";a="244599119" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2022 05:47:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,275,1643702400"; d="scan'208";a="805037266" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 20 Apr 2022 05:47:12 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 20 Apr 2022 05:47:11 -0700 Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmsx605.amr.corp.intel.com ([10.18.126.85]) with mapi id 15.01.2308.027; Wed, 20 Apr 2022 05:47:11 -0700 From: "Zhang, Qi Z" To: Kathleen Capella , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "nd@arm.com" , "honnappa.nagarahalli@arm.com" , "dharmik.thakkar@arm.com" Subject: RE: [PATCH] net/iavf: remove extra copy step in Rx bulk path Thread-Topic: [PATCH] net/iavf: remove extra copy step in Rx bulk path Thread-Index: AQHYP8xCdFxgpealTEicimaad8G+16z46ceQ Date: Wed, 20 Apr 2022 12:47:11 +0000 Message-ID: <6ab1775b645f4a3298222387c8b39658@intel.com> References: <20220324221132.10055-1-kathleen.capella@arm.com> In-Reply-To: <20220324221132.10055-1-kathleen.capella@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kathleen Capella > Sent: Friday, March 25, 2022 6:12 AM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; nd@arm.com; honnappa.nagarahalli@arm.com; > dharmik.thakkar@arm.com; Kathleen Capella > Subject: [PATCH] net/iavf: remove extra copy step in Rx bulk path >=20 > In the Rx bulk path, packets which are taken from the HW ring, are first > copied to the stage data structure and then later copied from the stage t= o the > rx_pkts array. For the number of packets requested immediately by the > receiving function, this two-step process adds extra overhead that is not > necessary. >=20 > Instead, put requested number of packets directly into the rx_pkts array = and > only stage excess packets. On N1SDP with 1 core/port, l3fwd saw up to 4% > performance improvement. On x86, no difference in performance was > observed. >=20 > Signed-off-by: Kathleen Capella > Suggested-by: Dharmik Thakkar Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi