From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBC21456BC; Fri, 26 Jul 2024 13:05:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93A7240DFD; Fri, 26 Jul 2024 13:05:07 +0200 (CEST) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mails.dpdk.org (Postfix) with ESMTP id 9EE304064F for ; Fri, 26 Jul 2024 13:01:40 +0200 (CEST) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a7a8e73b29cso125339366b.3 for ; Fri, 26 Jul 2024 04:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1721991700; x=1722596500; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AQhRqlE1cQVFZp+HiHXiBlUk+Z1NH8K8Eq6vuS1QAus=; b=ghZgBrGVlQYIkc1TFbayJOHGX+u9D61E0tbmP631Aa0vntJVKKBlqnUhKsGg9XxlxP F+yYmmxdIlUYR2SRwpwXgO/unOrsnc0st2WT3cszv1iuhfZzOPoXh+apgLIjFnwb01G3 +mZsGQ8Jdkf6u9dWmjDBMt/MkO45ToyulY0VfruVduydPpfeCGkIh2ggm2bwiBGihYLK EGuEz/jovY/ymFjkdbmopXC2OU/CS0kB3ZoJ8LfHYheSw4vgCT1Q/66113i1KZ6VVdG+ zSwW0f3t3pGK5Z46PE0ue1JUV7mYJNigwG2GMGuFiNwWoFUdG9GR/cW06jaiKG/5MEw3 mi5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721991700; x=1722596500; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AQhRqlE1cQVFZp+HiHXiBlUk+Z1NH8K8Eq6vuS1QAus=; b=Bde0HBSIM0KD3gCzIgacu9pMBbJnoGDqCOIrZNANgc/RyNi99iPYljoM0e90R+AoAe G859G4xz3r+fx9h2WD3xENpRMBMEdc33K/276juwymC8rh6DeH5tkx3cW5fkKrlyoE8J Vc1uLzs6xOoqA5MAdZeA4QGI9QuF7UELKrqibp/1BYt43cStGgglDa8XaQlayLH61298 dAYn5eIbsydH58LTOpGqggMLPr3KR5E6lCkBtqqh14DRVvqPv7kzWZBAbLUxFwBim3GG xaBXaHTPusZy4Pjo4HnBySSSe8N6fm0fnt4uVvkmWTu1B63UjA0hnnZqLLvEO1yQS1mi 4Nyg== X-Gm-Message-State: AOJu0YzsScppZkRBGASgXNXC+xzDJUR/t+yibsBf75aR4gZXWXgKHMYL Ue2tJsp5bl1ve1BovfUvVHaOCaDwHeK9bRDRKRKJdx67xowlalvj5Pnu0oVt7xM= X-Google-Smtp-Source: AGHT+IHbpH9CzylVvnTZjLp76jPAwaTJy64KU3gDLQ+QOXeJg8UHgsn1mIbaywqBF12XyGIU0egv0g== X-Received: by 2002:a17:906:cae9:b0:a77:c30c:341 with SMTP id a640c23a62f3a-a7acacc7bebmr359615866b.0.1721991700061; Fri, 26 Jul 2024 04:01:40 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acab2388bsm163032666b.45.2024.07.26.04.01.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 04:01:39 -0700 (PDT) Message-ID: <6ac8b8eb-efb4-4a3f-a78f-1f66dfa70fd1@pantheon.tech> Date: Fri, 26 Jul 2024 13:01:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/3] Improve interactive shell output gathering and logging To: jspewock@iol.unh.edu, probb@iol.unh.edu, yoan.picchi@foss.arm.com, wathsala.vithanage@arm.com, Honnappa.Nagarahalli@arm.com, npratte@iol.unh.edu, paul.szczepanek@arm.com, thomas@monjalon.net, Luca.Vizzarro@arm.com Cc: dev@dpdk.org References: <20240501161623.26672-1-jspewock@iol.unh.edu> <20240724183914.436188-1-jspewock@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240724183914.436188-1-jspewock@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org For series: Reviewed-by: Juraj Linkeš On 24. 7. 2024 20:39, jspewock@iol.unh.edu wrote: > From: Jeremy Spewock > > v6: > * Fix error catch for retries. This series changed the error that > is thrown in the case of a timeout, but it was originally overlooked > that the context manager patch added a catch that is looking for the > old timeout error. This version fixes the patch by adjusting the > error that is expected in the context manager patch to match what > this series changes it to. > Here's the diff for anyone interested: diff --git a/dts/framework/remote_session/single_active_interactive_shell.py b/dts/framework/remote_session/single_active_interactive_shell.py index 7014444d0c..77a4dcefdf 100644 --- a/dts/framework/remote_session/single_active_interactive_shell.py +++ b/dts/framework/remote_session/single_active_interactive_shell.py @@ -150,7 +150,7 @@ def _start_application(self) -> None: try: self.send_command(start_command) break - except TimeoutError: + except InteractiveSSHTimeoutError: self._logger.info( f"Interactive shell failed to start (attempt {attempt+1} out of " f"{self._init_attempts})" self.send_command raises InteractiveSSHTimeoutError (and not TimeoutError) which is why we needed this change. > Jeremy Spewock (3): > dts: Improve output gathering in interactive shells > dts: Add missing docstring from XML-RPC server > dts: Improve logging for interactive shells > > dts/framework/exception.py | 66 ++++++++++++------- > dts/framework/remote_session/dpdk_shell.py | 3 +- > .../single_active_interactive_shell.py | 60 ++++++++++++----- > dts/framework/remote_session/testpmd_shell.py | 2 + > .../testbed_model/traffic_generator/scapy.py | 50 +++++++++++++- > 5 files changed, 139 insertions(+), 42 deletions(-) >