From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4BBAE20F for ; Mon, 22 May 2017 14:24:43 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2017 05:24:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,377,1491289200"; d="scan'208";a="105414418" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by fmsmga006.fm.intel.com with ESMTP; 22 May 2017 05:24:42 -0700 To: Pascal Mazon , dev@dpdk.org References: <172025985dc6ca989008cc2d93008e38ac3fff39.1495452020.git.pascal.mazon@6wind.com> From: Ferruh Yigit Message-ID: <6acb1c97-0c27-da98-5c4f-292b0f87e29a@intel.com> Date: Mon, 22 May 2017 13:24:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <172025985dc6ca989008cc2d93008e38ac3fff39.1495452020.git.pascal.mazon@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/tap: add Rx/Tx checksum offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 12:24:44 -0000 Hi Pascal, On 5/22/2017 12:20 PM, Pascal Mazon wrote: > This patch adds basic offloading support, widely expected in a PMD. > > Verify IPv4 and UDP/TCP checksums upon packet reception, and set > ol_flags accordingly. > > On Tx, set IPv4 and UDP/TCP checksums when required, considering > ol_flags. These are not specific to tap and can be used by any virtual PMD, right? What do you think moving implementation into more generic location (I don't know where right now) and use from there, and other PMDs also can benefit from these? Thanks, ferruh > > Signed-off-by: Pascal Mazon <...>