From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC24CA09E4; Fri, 29 Jan 2021 10:10:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67D9124011B; Fri, 29 Jan 2021 10:10:36 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 96E7A40694 for ; Fri, 29 Jan 2021 10:10:34 +0100 (CET) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DRs3L19DpzjF9l; Fri, 29 Jan 2021 17:09:18 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Fri, 29 Jan 2021 17:10:29 +0800 To: Ferruh Yigit , Thomas Monjalon CC: , , References: <1611150232-609-1-git-send-email-oulijun@huawei.com> <1611837805-42429-1-git-send-email-oulijun@huawei.com> <1611837805-42429-3-git-send-email-oulijun@huawei.com> <2843903.C3Glkg52S3@thomas> <117895e7-b00b-4f72-05ee-ced0d62d2aae@huawei.com> <5e75c811-c3ef-486a-471b-eeabde28bd7b@intel.com> From: oulijun Message-ID: <6aceb801-4bff-10b7-81a6-bcbb04c09b24@huawei.com> Date: Fri, 29 Jan 2021 17:10:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <5e75c811-c3ef-486a-471b-eeabde28bd7b@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/1/29 16:46, Ferruh Yigit 写道: > On 1/29/2021 1:13 AM, oulijun wrote: >> >> >> 在 2021/1/28 22:12, Thomas Monjalon 写道: >>> 28/01/2021 13:43, Lijun Ou: >>>> The hns3 PMD add FEC features implementation in 20.11. >>>> Therefore, need to update the hns3.ini for supporting. >>>> >>>> Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Lijun Ou >>>> --- >>>> doc/guides/nics/features/hns3.ini | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/doc/guides/nics/features/hns3.ini >>>> b/doc/guides/nics/features/hns3.ini >>>> index a467396..4ea568c 100644 >>>> --- a/doc/guides/nics/features/hns3.ini >>>> +++ b/doc/guides/nics/features/hns3.ini >>>> @@ -39,5 +39,6 @@ Stats per queue = Y >>>> FW version = Y >>>> Registers dump = Y >>>> Multiprocess aware = Y >>>> +FEC = Y >>> >>> Please don't use tabs but only spaces in such .ini file. >>> >> OK， I will fix it >>> Can it be squashed with the commit adding the feature in default.ini? >> Do you think patch[1/5] is merged into one ? I took ferruh.yigit's >> advice. >> > > Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged. > . Thanks. I will do it in next version >