From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D04A4A0540; Fri, 8 Jul 2022 10:51:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E0E540A7B; Fri, 8 Jul 2022 10:51:31 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8B78C406B4 for ; Fri, 8 Jul 2022 10:51:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657270290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vQYEI4av8NfSOu1pt9cSlcOegcsGp8Ty04I05w6PRPc=; b=cUAEy5UxJgYfVr4ciO5CK5NP6r6b1QKu5kAhS8JdppK6NDR7wEr9kEKI7FeAY+WHSakxNG /a1Man9eB2CR79OpMLxiKRO5UPu/JqJPaR4MAofxEC2RCsu966RR6zOer1XIEwXzEbJg+t sNuffyN4lixord/k2Qb0LGFzBaUGldc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-175-Glyo5vHNOkqUfJmNfrt6LA-1; Fri, 08 Jul 2022 04:51:28 -0400 X-MC-Unique: Glyo5vHNOkqUfJmNfrt6LA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 553CE189FFFA; Fri, 8 Jul 2022 08:51:28 +0000 (UTC) Received: from [10.39.208.8] (unknown [10.39.208.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 833CD492CA2; Fri, 8 Jul 2022 08:51:27 +0000 (UTC) Message-ID: <6b4afd2b-3fc2-3e60-5346-579f1b243ffa@redhat.com> Date: Fri, 8 Jul 2022 10:51:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] vdpa/ifc/base: fix null pointer dereference To: Andy Pei , dev@dpdk.org Cc: chenbo.xia@intel.com, xiao.w.wang@intel.com References: <1657259861-75138-1-git-send-email-andy.pei@intel.com> From: Maxime Coquelin In-Reply-To: <1657259861-75138-1-git-send-email-andy.pei@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/8/22 07:57, Andy Pei wrote: > Fix null pointer dereference reported in coverity scan. > Output some log information when lm_cfg is null. > Make lm_cfg is not null before operate on lm_cfg. Make sure* > > Coverity issue: 378882 > Fixes: d7fe5a2861e7 ("net/ifc: support live migration") > > Signed-off-by: Andy Pei > --- > drivers/vdpa/ifc/base/ifcvf.c | 31 ++++++++++++++++++++----------- > drivers/vdpa/ifc/base/ifcvf_osdep.h | 1 + > 2 files changed, 21 insertions(+), 11 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime