From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFD44A0613 for ; Wed, 28 Aug 2019 15:49:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B3301C206; Wed, 28 Aug 2019 15:49:07 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id C41911C1BC for ; Wed, 28 Aug 2019 15:49:05 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id q12so2569418wrj.12 for ; Wed, 28 Aug 2019 06:49:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=c89cZeC3XWJddNYzty+AZFA8ikDC0EkHlRWJvladJ5U=; b=OizWNNOrDngSahUvTBjgrS2ykFwrlNOO/J9JYnEx88I/MlCHroLaXKSYcv/io58/ry LbrHCsKmBF4fKh76NuBaD9hKYgn8hrCtUwG97tIAXXy9KhcKmhgPq5jQPmnpGP0RUR2F ScpN34naLRmG7c4j0R4b/850bhkWYcTWwh7JmEJYuPdjEpcuTK/4Gli2QSJEN9r6RDwn SMl45D/p5vNhd05hfCW5DvnaO5VyJ33Ae/BqvapIPG7tPSYs8bsKMmR5ykPb4xuAxjIT JNfDYjyTpoI77Brhjg+Zoq87mfxtF61P8lcSA8zUI6DspmSJE/awtRhJQNExHPaECQwC tuFA== X-Gm-Message-State: APjAAAX0GIya1GfDmCvS7qLZx6ajSkhuJNgo5qc21ZAaE9PKQNoNyNjW g5fSRIMJMWjEpfwE/5pj3+U= X-Google-Smtp-Source: APXvYqxtWa4HQPs3BoMukZ0Gqth69CbmGupb7PtAmriNcVo7WMw6nMTeiWVb7cwx37C/Of++7G5nBQ== X-Received: by 2002:a05:6000:1085:: with SMTP id y5mr4805105wrw.285.1567000145255; Wed, 28 Aug 2019 06:49:05 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id n12sm2672638wmc.24.2019.08.28.06.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 06:49:04 -0700 (PDT) Message-ID: <6b576d603fbbaceb922fcd96e666bc7caf603cf4.camel@debian.org> From: Luca Boccassi To: Christian Ehrhardt , dev , Kevin Laatz Cc: Thomas Monjalon Date: Wed, 28 Aug 2019 14:49:04 +0100 In-Reply-To: <20190828122752.27887-1-christian.ehrhardt@canonical.com> References: <20190828122752.27887-1-christian.ehrhardt@canonical.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: avoid --as-needed as it causes overlinking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2019-08-28 at 14:27 +0200, Christian Ehrhardt wrote: > A while ago telemetry was added in 57ae0ec6 and it also added as- > needed > to config/meson.build. This seems no more needed these days as due to > other > build changes the ordering in buildlogs is: > [...] -lrte_telemetry [...] -Wl,--no-as-needed [...] > Which means telemetry no more benefits from --no-as-needed anyway. >=20 > Overlinking problems get triggered by the meson generated pkgconfig > which > will have: > [...] -Wl,--no-as-needed > This will overlink and in addition anything that follows > as it also doesn't wrap back to --as-needed. So if a projects > includes > dpdk libs + it will also consider with --no-as- > needed. >=20 > Fixes:=20 > https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759 >=20 >=20 > Signed-off-by: Christian Ehrhardt < > christian.ehrhardt@canonical.com > > > --- > config/meson.build | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/config/meson.build b/config/meson.build > index 2bafea530..58800a980 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -93,9 +93,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + > toolchain.to_upper(), 1) > =20 > dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') =3D=3D 8) > =20 > -add_project_link_arguments('-Wl,--no-as-needed', language: 'c') > -dpdk_extra_ldflags +=3D '-Wl,--no-as-needed' > - > # use pthreads > add_project_link_arguments('-pthread', language: 'c') > dpdk_extra_ldflags +=3D '-pthread' >=20 Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi