From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76]) by dpdk.org (Postfix) with ESMTP id A8B251B253; Thu, 12 Oct 2017 13:15:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1610; q=dns/txt; s=iport; t=1507806935; x=1509016535; h=subject:from:to:cc:references:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=ctyoGTu0iua0jsrPfuQrMxcwv77y83Fm7+fwTfRI+Cw=; b=WOhTdREqahXQmivhWGLFks3TrWZGLKri41SAhKwDKBJOuJ31LhrabcuP L4LaBqTUsJvmRpNZk5iU+UNOWI01zz6EL4P9+zXa3SKqAy+HOQY0Wx6mT pMv9xhYFbklCN7/MEfU87bG9OIPYIbt8pxhuzxCdxALHkxJ6g6Tal4mWu c=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AQAgDfTd9Z/5pdJa1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg11kbieDeplNgXaWL4ISCiOFGAKENUEWAQIBAQEBAQEBayiFHgE?= =?us-ascii?q?FIw8BBUEQCxgCAiYCAlcGDQYCAQEXigMQqXCCJ4s5AQEBAQEBBAEBAQEBASKBD?= =?us-ascii?q?oIfggeBUYFqK4FxgQ6IGIJhBaFEAodcjQyCFF2FF4Nahy6Va4E5JggpgQ54FYg?= =?us-ascii?q?CJDYBi1gBAQE?= X-IronPort-AV: E=Sophos;i="5.43,365,1503360000"; d="scan'208";a="88962256" Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by rcdn-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2017 11:15:34 +0000 Received: from [10.150.214.134] ([10.150.214.134]) by rcdn-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id v9CBFYcu028934; Thu, 12 Oct 2017 11:15:34 GMT From: "Roger B. Melton" To: Bruce Richardson Cc: Qi Zhang , konstantin.ananyev@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, stable@dpdk.org References: <20171010132205.72173-1-qi.z.zhang@intel.com> <20171010084807.GA34984@bricha3-MOBL3.ger.corp.intel.com> <20171010113959.GA40296@bricha3-MOBL3.ger.corp.intel.com> <6c3a1cbd-e28a-a9cc-ed46-e08dc03644ce@cisco.com> Message-ID: <6b6ac998-b13e-3b3a-74a6-6bff54349dd2@cisco.com> Date: Thu, 12 Oct 2017 07:15:20 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <6c3a1cbd-e28a-a9cc-ed46-e08dc03644ce@cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix unexpected mbuf free in vPMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 11:15:36 -0000 On 10/10/17 7:47 AM, Roger B. Melton wrote: > On 10/10/17 7:39 AM, Bruce Richardson wrote: >> On Tue, Oct 10, 2017 at 07:05:33AM -0400, Roger B. Melton wrote: >>> Hi Bruce, >>> >>> I can.  It will take a day or 2 to get the results. >>> >>> Regards, >>> Roger >>> >> Thanks. Keep us posted. We want to ensure we have the best fix possible >> for the issue in this release. > > Thanks for finding a better solution ;-).  I'll let you know the > results when I have them, just wanted you to know it may take a couple > of days to turn around. > > -Roger Confirmed that this patch does address the issue.  Thanks again Bruce/Qi for finding a better alternative. Regards, Roger > >> >> /Bruce >> >>> On 10/10/17 4:48 AM, Bruce Richardson wrote: >>>> +Roger Melton >>>> >>>> On Tue, Oct 10, 2017 at 09:22:05AM -0400, Qi Zhang wrote: >>>>> vPMD tx does not set sw_ring's mbuf to NULL after free it. >>>>> So to prevent same mbuf be free again, we need more carefully >>>>> check in i40e_tx_queue_release_mbufs. >>>>> >>>>> Fixes: b4669bb95038 ("i40e: add vector Tx") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Qi Zhang >>>>> --- >>>>> v2: >>>>> - fix at i40e_tx_queue_release_mbufs so no performance impact. >>>>> >>>> This patch also supercedes this one, >>>> http://dpdk.org/dev/patchwork/patch/29814/ >>>> right? >>>> Roger, can you please confirm that this alternative fix works in your >>>> testing and that your patch is no longer necessary too. >>>> >>>> Thanks, >>>> /Bruce >>>> >>>> . >>>> >> . >> > > . >