From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46874433E3; Mon, 27 Nov 2023 11:22:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34B83402DF; Mon, 27 Nov 2023 11:22:19 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2054.outbound.protection.outlook.com [40.107.220.54]) by mails.dpdk.org (Postfix) with ESMTP id 26D8E40150 for ; Mon, 27 Nov 2023 11:22:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IIz8I39ioa6mW7+aQCHb+BWidAsIm5xhv/wnDqAhIrCMmrB7oZ4rSiyu7kQqrIRQd7qXiQDy1HI34Mtn2c++xU4ctEv+Pi0HsV5SKOUGhtEsMoKU0e0CfjjWioKBnITLSvge6m1OE+fUQz5xRuZI0K8YOAOyBt9zoyyZLmhNjPKohpsvR1+GeHbJ/jOnQzAOfMOEBH/SbHjHRaF0klGLxWkh2FA2FedObtL2KkV4ycLyQCwPxtfKSb0nZrhUDnq3fUGqxAiAz1kvO5O3Gpj0JQHIY3Pn01LL2rDNYrpCaMyq0XDi/ke2Cpe7u5j50qmoi5Iu0jGVGJ6546serLd0Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UJpfdsH/fKwL/G7zvrLC6ekEVbcFGdstbDHwFfzT8M8=; b=Zy4iNQfiigVksdKF3XtvkKXk/9Cqctj1zK5PbuhAV/VEVSZk7KSsV4LWizj1bT0GuoFLUF9Gj0xcEYt55X2RfXvKELtDqkeFi9OdRyC31hRhMREFsBuV6ybJzj94kmcyXNGBDzJbbV967rV23ZgfVboTBCCiiZ8FngbBbY8EFjOIgZFZYXVRMIY9YeDDYNLLDDih7akgbErOHc6P6lcO8gDZd0Z94dbzp9Rfp2soTmBmNUwz2sJmpcx+oj3fYhPCxj69+MWB6iQ+WHroiJYoMX6NVcKOP3VjrOytKcSfxYqINeOAeLiaCPtpyudmCmWJWowBXpneAsisAb7KsVxgPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UJpfdsH/fKwL/G7zvrLC6ekEVbcFGdstbDHwFfzT8M8=; b=VZ+imClwOoe/s7BhuexfVVXwL39EPt0DD9a5QyArLtP3EGCsV7cylSJ25V6xFLOhXmjHV2SWwf3SajKwMCTr5LHblA7URUtnRBz6birNUG63zwjma5c0grt91Kr7CdoreMG7oDbDqrkFzuXQ88sB+xRyRSutsF2QN6IonARbqW8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB5596.namprd12.prod.outlook.com (2603:10b6:510:136::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.28; Mon, 27 Nov 2023 10:22:14 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 10:22:14 +0000 Message-ID: <6b76373b-c97a-4605-be89-271eddea4af6@amd.com> Date: Mon, 27 Nov 2023 10:22:10 +0000 User-Agent: Mozilla Thunderbird Subject: Re: net/virtio: duplicated xstats Content-Language: en-US From: Ferruh Yigit To: Edwin Brossette , dev@dpdk.org Cc: Olivier Matz , Maxime Coquelin References: Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0103.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB5596:EE_ X-MS-Office365-Filtering-Correlation-Id: eb511d44-409f-475b-6141-08dbef32b95a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7XVIxNHuuLAgyms2t9/KAqdgODxSO/lJSjjeTRD7daDkGxu+KQhuuuiGZ+nEF0sHE7xXYJQfSEySIkR6lB96qC+2qeFNqn9gLD0Wxeeb5TvNZip+XgabMhF/18D+m1RSH8Ik/JC744++Mk3/Q5rNjGpv21dCLRo5Ep5/tdr4/OQkz/8ikyVVREbg6zg/irnv98BGdI01y/pc/70SC7h+NFF5naCcd5mHCPmmwIb4D0qOWq5xeL1L3k4ThHeDsGNeZPcLIkoFkKSH3pfc/kYRXBhfpn1R10MCYlfy3DWnQEC30C0UyuA5tREliDsWFZQBLqJNo43oZxjW1heGBO+oY6Gy9It6OFXzigEC73ZA9eJBQqtpP4UhX4dbjI4205vFZrAKMm8+p/UUpDKvSUkyuHIte2hIKJsHv3ZsY3WisKYpX1HK6kFtCeOCcJ5um6tMnHnkcCMs3uLgUXb+XEVTBuNifs+d/m6qYtRAW1luV5889fFsGBhhkUBPd8TIhV7JBYoeu/Sar/OgWjX2kvNLS65j/GGbHwy+1A39mKi6kKYJaAFE+co1XKBSv7rRHP1pSnDFX3LViv73TqiRG7pF3eWXiZmhVF5kE2xxNEIDfPKjK+e3g3hf/hPgyW2EH6cj3eMGMBMYshNtRJUjqm/uoA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(39860400002)(376002)(366004)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(6666004)(8936002)(4326008)(8676002)(6512007)(31696002)(53546011)(6506007)(66476007)(54906003)(66556008)(66946007)(316002)(966005)(6486002)(478600001)(2906002)(36756003)(38100700002)(41300700001)(31686004)(86362001)(26005)(44832011)(2616005)(83380400001)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkZzemYyZC91TXNlbDFOazZaVGE2dGhGdUt1dDZKVVk5Vngva2dyUlVkV05y?= =?utf-8?B?RmdOdEs4ODFka09wOGpmcHN3UXB0M1RNVGd3c2p4QVpyUzVGZzBjakNzdmZr?= =?utf-8?B?OGt1OUlWWmRxenN4THp1cXN1c1k4RXpMc3gzV1ZjMS9aTzBNeU1DSzdDU01U?= =?utf-8?B?VTREYVEwOGtHK0ErSTlQTTFQQXMvTGFBYkxGMFVtd0liQVlGUERONVVES1Fy?= =?utf-8?B?c1IvQlMxbURhQU0ybEpnb1M0bWhIQlFHZkV6RWxGUStkTzd2eEh0eDdnUTFt?= =?utf-8?B?Zmd2ZWxFLzZJeFJkbmFDWG5yZ0ErbGM5VXRXWTNxekt6ZjdpRFhHbGZBRGpK?= =?utf-8?B?enZkVjJJdjk3SzVlaDRYdDc5ZGJpcTJOeENCM0FvTDBwWkNOekFjN01sV3dh?= =?utf-8?B?YWoyYWNLa0dVUG5QSWVKbFp4cVJJVTIxZ2dyRkp4MWxlTmRBTjRpcVdaZFE2?= =?utf-8?B?dXNYdEJvNVRLZDY1ZFFYRGtLS29haWd4WElEelB0Vk5aM1JYeGVDR21wQ1dD?= =?utf-8?B?eXQ5dndOVVRBTTIzbjFNd3hlUllNVmFqUE44c2VEd0xqaGsyUnpDb1J6cXc5?= =?utf-8?B?U3pUYlNSQkhxR1g1VXlENjhWZXBETzFrQjJpVFBQN3FRKyswS1lCK2xxWlEx?= =?utf-8?B?RXNtaFhMN1R6dGNCRjhFc1pLYzVXK0M5bjBieUduOE1LZC8wV2tRbEJiSlNv?= =?utf-8?B?bHVKS3pMZU1WYUtrOWVVY0ZkUEVLWFU1d2wwUDIyM1EvVlIrbjF4ZUxTZUhR?= =?utf-8?B?TDc0NXNwU2JVOThheGRzRU51c1hPSFVQYkVDb1dkcVB6UDNwQ3FvL2R1eC9r?= =?utf-8?B?TW1LN1JkMjBRSE1vUjNpNjN3YXlNelIzcjNPRy9DUFlCQnJCZzZSODkydTky?= =?utf-8?B?MmlrdGlCcXpZZDJZVmtsMEZ0dVl6RjUzdDRCZDArOWdnRDJTQk94TEVTZm5R?= =?utf-8?B?V0pLclNmbTE0eVBkMXM0OFE2NEkzbXliaEJQdzhNMVBBLzh5UWFuUXcxNmdk?= =?utf-8?B?MnhGVVA2UXJTcGdvdmJ0NThqWHR2Z2FHWXg1eno4dkRONUY5Ly9nM2FGZm4y?= =?utf-8?B?eGp2WitnTlBQaWpOUmE4ZERETFlwR1psZGRPamJoeG4wVHVURWVFMGlidlF4?= =?utf-8?B?dWNiMDBBM0NtOFVhZnBGNVh1VHpxZlhBTkJsWGVxVWpvaWNBN0xqLzRpSWQy?= =?utf-8?B?T1ZRL2FLWDhVem1uU3hRRXdWbDFRMmI5blBsSGIydUZvRFFIK1M0em1Icjht?= =?utf-8?B?VmJkc3NwSE5mckkySDVld1dnM1gyNi9IczVNRlIrY09hcG1POW0xTjlaMUJz?= =?utf-8?B?VTU1d3ZmSEtCay9tVmlrN3VvQXdqUTlFblJmTS9EODNhWlV4Nm5PQk9QTXJt?= =?utf-8?B?dWFNZ2xkS1hZMkNMdWF6MWl1MmU3dlE3ay9XdUdNSFRHSG1GT2RNeDVUd0l3?= =?utf-8?B?YTJCdjVBZ0pObUFsT1crbjlwbStCVXNKNzQyRy9rNE9rZktmOG9wVVdmZjlV?= =?utf-8?B?VDhmVGU2SUdLL3l2YW1WeDhtY3J6Sit3NytMYW54VUVoYnNCUHk1dnRoNG84?= =?utf-8?B?V0ZGSTFSRVNzYmMvRmVnZWJaeDhxRzRGWlFkVFc4K2Z6bEl1VXdXSUh0a0Ro?= =?utf-8?B?RG1UYXJBR2tEb2dMZ1N0RVZaQnFBazdYTnRoN2dLS1dVN04yVnQ1RFlPQkVl?= =?utf-8?B?ay9xV0ZYUEluYThHM24xWFhGRmpHM2VoUWg2L0R6VE5DU3dLaDlJaGlISVEv?= =?utf-8?B?K2s3L3RpM3BXbE5rOVZ6cDJ6SUVZOUNvd0FKNHMzL0w1WW5jcUZzOGx4VmRQ?= =?utf-8?B?blN3NVdMZWEyWjFPVDBWRTh1ZmFLWGJ0TDZoM1pMNXB5cXNTZStHQjFuakJv?= =?utf-8?B?QVF2dG5PSGJ1alFNRE9saEc4YnB3dnF5VGR4NkVjNlZlZm9nZDRLRTZwd1FO?= =?utf-8?B?aDlONXhyZ3BNRWlhNGFkb2lsUzFHcXVuNkhGaHRtQ2JVN3M3OW1nVGo2R2dB?= =?utf-8?B?NE9VaXdCSkk3OUwweXpYT04vL1N5UDFEa1U2NGpIeHphclpZUEpyRWxweWpB?= =?utf-8?B?UE9TOXdIR2ZZa0xmNXk2SEhXUWloLzUyVnZUUm1QWnFZL003bXFOaERhMUxT?= =?utf-8?Q?j8zQ=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb511d44-409f-475b-6141-08dbef32b95a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 10:22:14.2275 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IZxsRrmNtIJMRR3Ai8AGaeFfOrUbceqtcd3cy+lLYlAnO3VqNvp5cAhQDi3MCHuC X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5596 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/27/2023 10:19 AM, Ferruh Yigit wrote: > On 11/24/2023 9:18 AM, Edwin Brossette wrote: >> Hello, >> >> I noticed a small inconsistency in the virtio pmd's xstats. >> The stat "rx_q0_errors" appears twice. >> I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" >> and "tx_q0_bytes" are duplicates of "rx_q0_good_packets", >> "rx_q0_good_bytes", "tx_q0_good_packets" and "tx_q0_good_bytes" >> > > Ack, I didn't reproduce but from code I can see this inconsistency can > occur. > > >> I believe this issue probably appeared after this commit: >> >> f30e69b41f94: ethdev: add device flag to bypass auto-filled queue xstats >> http://scm.6wind.com/vendor/dpdk.org/dpdk/commit/?id=f30e69b41f949cd4a9afb6ff39de196e661708e2 >> >> From what I understand, the rxq0_error stat was originally reported by >> the librte. However, changes were made so it is reported by the pmd instead. >> The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set to keep >> the old behaviour so that every pmd could have time to adapt the change. >> But it seems the flag was forgotten in the virtio pmd and as a result, >> some stats are fetched at two different times when displaying xstats. >> > > Motivation is move queue stats from "basic stats" to "xstats". > > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' is a temporary flag, as you said, > and when driver sets it, ethdev layer copies queue stats from basic > stats to xstats. > In long term expectation is driver itself implement queue stats in > xstats and unset the flag, when all drivers implement this, flag will be > removed. > > > The issue with virtio is it already has queue stats in the xstats, with > the flag some queue stats duplicated. > It seems it is not forgotten to be removed, but it was mistake to add > flag at first place. So OK to remove the flag from virtio PMD. > Fixed Maxime's email.