From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0042.outbound.protection.outlook.com [104.47.32.42]) by dpdk.org (Postfix) with ESMTP id 7EABF2BAD for ; Fri, 9 Sep 2016 13:42:47 +0200 (CEST) Received: from DM2PR03CA0005.namprd03.prod.outlook.com (10.141.96.15) by CY4PR03MB2438.namprd03.prod.outlook.com (10.168.163.140) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Fri, 9 Sep 2016 11:42:45 +0000 Received: from BN1AFFO11OLC002.protection.gbl (2a01:111:f400:7c10::130) by DM2PR03CA0005.outlook.office365.com (2a01:111:e400:2428::15) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.619.10 via Frontend Transport; Fri, 9 Sep 2016 11:42:43 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; networkplumber.org; dkim=none (message not signed) header.d=none; networkplumber.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11OLC002.mail.protection.outlook.com (10.58.53.73) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Fri, 9 Sep 2016 11:42:43 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u89Bge6D018957; Fri, 9 Sep 2016 04:42:41 -0700 To: Stephen Hemminger References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-1-git-send-email-shreyansh.jain@nxp.com> <20160907114004.4a218155@xeon-e3> <20160908094929.22d21b2f@xeon-e3> CC: , From: Shreyansh Jain Message-ID: <6b977abe-b2ff-60b6-9c31-e23db99eb389@nxp.com> Date: Fri, 9 Sep 2016 17:12:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160908094929.22d21b2f@xeon-e3> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131178949636974580; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(24454002)(189002)(199003)(377454003)(586003)(81166006)(77096005)(65806001)(65826007)(33646002)(626004)(106466001)(65956001)(92566002)(86362001)(93886004)(87936001)(11100500001)(4326007)(8936002)(68736007)(81156014)(7846002)(5890100001)(97736004)(2950100001)(23746002)(356003)(5660300001)(230700001)(8666005)(8676002)(85426001)(76176999)(305945005)(105606002)(64126003)(36756003)(104016004)(47776003)(83506001)(54356999)(50466002)(50986999)(110136002)(2906002)(189998001)(31686004)(4001350100001)(31696002)(7059030)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2438; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11OLC002; 1:zXzrN+eMgWEbGzNroh91pk4Up+4Yzzpzw21LcHW+O6So0l+xU/LHu3hAKlRr24WRcHvnepjTgfPuTRn/0zoCp1Y531/QgiyDICnsyihXs/cvOLLVr5TRcQXJmwWf9Oowjo+28wsMvgpD/YyyD6zPqHQ5hp5IitqnZHcjgC51Fxcn6OpVXsjWYveKhN5lDn9y5L2QKdxqjad5X2rHx+VCYKVaKgJZnc76dS6gaxbl5bR2ZXrFZqzgQxFMejfBtOYI6cKLC5j1KXdEWDLLAhXPnmAvVG3AFZzUB3lfw/To/Sr7nQPik5eGJIRCu6Osa6uCSOlc3OYHZb8P6dvNYPE+j8c6Bwaoo1Rg3c3UnMUtKR6a4bJ87ZeBSZDfmCZQ4wLR61dJLhtZfKbaxx5NCnikdzsIhO1g0nyEYVwAkVJ2J5XwKnendxvGtF+kFIZDfajatxpJnN2GVNxfCcGyKtwHImfQ0Re5O9JRsC3mjgXvoFDaNNwy4ilRla01Hjwo70qHrjnGAtjcYxJHrRgOw7GYAW88NEw7Bs0t1LB8NUTHLVtRDN3n9E+8+ASE5fyXxK4pBRUgQ9A2+2x6tyjXLFv/yQ== X-MS-Office365-Filtering-Correlation-Id: fc3fa8e7-9dcb-43ba-e7f4-08d3d8a66995 X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2438; 2:SGaZLMx09diZKylfTbmvCrbNJLC8uV2jBK8+PN+kDpBinGpKbYnvm9Q/fwpMQLtkz7II18y6KUO1zeXccMR32svo8c43ssRVVXzY0qY5JD+kteNBKMmtTLI6J+ZbBguZW+3e+0jsg/8Q4kie6Lr9sFwRXLtN8/9Qu1CpBG3bGjgpHKqtcKqe09BkpjGprvnx; 3:4wvSozSOLtlGmc3ab8cc2vKKt+vhAgUkXu9UuVOWFihrDKvI+z1Fx20b8Ybi6vZIRfSu8tq7ZhxWKRpzwQf5Zs6PqsIiVGrYfdfW34TXpMIkgpAth5PRVQ+Ug7ev9/cknuZinRgoHRF6o4qVd7XSqi/eUAo76C5Dv+e4P7I0kXIxqcSM9bSLBndfa+EY8C4Pc7UP/w7MRylNOXAbHyCR+0AF7Z6n8YDeKLTRmPeW5Is=; 25:5sdk8RPamaYMZrtAeyl42frw94BTQN4CjjtxTNS78NuLvEI/MuzWVA6Eh3FhAWM2V+LxHDU5yFLrZqz5XbKQ4gBsxpBLVyl0orag1ApOyngq2ombCB0RLBi/mLNPgcFA0Bf7JKl1AZcVMV4+JICe22zaGqoVsF3P3RyYr6zxwHXdQ1bGI8A4/l8TIMdJir8cXpBO55PWZ4me6/ExlnArYpUFThtjtfB0m/Bjo8kvNa5LF4tUM09if9ztgJI3t8Q+CvEgbStRMe92jw8dMI/QZOwfAXFDLKxaY5OEP1ZZwFM8dC5E1nFS5/9LRAZNn5FZJ18OVOvvSIfNrMG9dmXWEMXOGckAbWQzw2oLFc2izQegDKTFc3VOg66DT9f4uZd7kuNxl3Oq/Mk2xp/U/Yaee/2RRVCTAByTrYJNkpW4xj4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR03MB2438; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2438; 31:7z+C7HY/E2Cln0UxtwZjuqLNCmYqrhcoHRGOpVXNnSzwIU+JgcKeP9aCmytBRdC6cmrNCHoX3X8BFgBIj6jhpsZoewe9ITPVT8uYE01NG24tIL26yAn2vqKmaEeQG90eVyEJdc5S/JPzbUm0EaLVScKeOok26bIN2mcAKzS9Wx7A0AW5njc5FOW89GgslyzQcR8HCnKbJEDv6PdBeGO5ALuEd1A205uEEMUrtVON3e0=; 4:yivjjYxYVrv/pghHcYw6SPJ+H5kuzC0mhzZGIPduo1b1J+38Q+8UhiAMxORr2wIHCc3vw3qBmGJweZHC2FeyBFSsebMLCz9hoZYg5t4Q775kC8Ttx7YsnKghiY985/pjcQAbqRk/FIvqYSPbBx96uE7KwRhbPiZ+pm6tQOK2lLIFtHzAA+9PoRKRxYGghWruP5Bp0UoDsVLqPEbGC1tR31CNbxW4PTybWd2zmwzVR+HxdR/YD1xapMeLo4+YD0lKjyCeBnORIENSsGefxbBEksLKK8f3Al0prWJnlaalNs1UlqJ4XPQzscMiYpLkeA+fuFLMwzFFzfotpvvipXfJ2JfUaJqPcJm933QYU285NUdW/aJsNwXnE+z7uXFcgi0hU2MwdHOhkZNFIRNLCa+SAVeVrBB5iXqxPYjzP0FkAMUFSC/wQ5MG0P7PSjr3r8QmBudaC1WgsoB0jjBXyp3c1qKQlF2ZIrXuTjm6fO0rIOOPHnIJo7P3m//6JGB5J9HR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13023025)(13018025)(13024025)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:CY4PR03MB2438; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB2438; X-Forefront-PRVS: 00603B7EEF X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR03MB2438; 23:DZAvlqLnWsV3O+l7egJxTYN+S7d1gcezfIugg?= =?Windows-1252?Q?/3Gk1MpaNevqWKPvmxxG+lZhfUq/ozXIzGiRCTKhlmxMgJUQq8GYjz87?= =?Windows-1252?Q?AqncrQtiOoMWCnQaiaIQyY9R11s6vAGXXppcY4Af072vWfPoKmZrp2tm?= =?Windows-1252?Q?PDd9GrkTIcVHN8GtRYC8Rld5W/LUdgF/30k0x3sKkYVko9PBim6TVUJq?= =?Windows-1252?Q?NWdhVv+7QdppUzuMKm2/fItDf1ihqsIELeMR0SELsOrt4HVvJGGZPGiu?= =?Windows-1252?Q?cDqiSir6FF1MK2Q9EgsVduu6hCokdgubhoaen73ZPrQh/rkg+6oKrVX2?= =?Windows-1252?Q?y5F5jsGKz5s+KYG2V6d6o15/uXhCnyYjBl1bdHYSPFCFKVGqrbS6DfsS?= =?Windows-1252?Q?M4wwNj+HRMypayEFwx2Zspj3yAapDH2vc8421jEPLIyDkX1QdvQQT+ZR?= =?Windows-1252?Q?wJEIOOrt0nEGuEnkZiyLUCzRkG38ITDni3VUuW9hkXXfT61AmAz32N7A?= =?Windows-1252?Q?IYNXb4GA0L2y5e36cFJRMn+itxufTaLCrZb7V3q/n9h6YAbrrKcKhQM6?= =?Windows-1252?Q?WMjg63v30jhqmRMVAq1YEhdv+y1u1/rXOpJv5Zb1VArjgWi0+Kn9VmKQ?= =?Windows-1252?Q?Ci9NUEqopmYZqz4hMkipjPDRwwFE9hJpQYLeyGxXOdRimqdPRpJ8YEFM?= =?Windows-1252?Q?NbKhZQz2uYP0XtNjfVqWQ7k3vyIEgSd68ezspIzd4JsXyYlIktno4wbN?= =?Windows-1252?Q?1XSKoL46PE+qiTYEoJ+jBz3Qj6kq3qhNkOmAMQa2eTA9UhOGmx0zHIhH?= =?Windows-1252?Q?TmJv24DSSr/K4UHk5zW5Suu8rWdqut/Wm4QODjPhAeME6P2dIUiFAMNv?= =?Windows-1252?Q?P9v6cchV84XU5ddDGjocJH3Hjq0Vk0fsX5bMLXRhlvatTJAjtZTediYK?= =?Windows-1252?Q?zxCZseScuHNnM4svhes9NOcH5pM2oRPtLkRd2n5J3eTaDZOg1rVMdiZe?= =?Windows-1252?Q?Mldt+eBb2QwkdCVWTtABpz/jwSGUjnwsOOZUAxCyH+r2rKEm31tJfcPg?= =?Windows-1252?Q?6mLi7Ytk6LAAV0aRj4mW+PcKLqKfrxqBodLbHFUGU/9pNLEclTiC48kA?= =?Windows-1252?Q?7SAUQp1v2HSwMY84LhM6GqNYcXGC4HUlDiXWkVeFzeMlsWRoUJ2IcDw0?= =?Windows-1252?Q?ERl9jNEsa0SJ72ctVY8jJAdZZHmwzwYdqsVkU5V648O14FWJAah4yOQL?= =?Windows-1252?Q?gM4CIoGzTNEUhzmpz2s77qKYRhbqqnUJFA3XiAB4/qhWK3um3sWRNRcw?= =?Windows-1252?Q?ghX5oVvM44HkND8JclYe98SWfe0w9smN9OhvS1uNdKYqgcg799rqtnug?= =?Windows-1252?Q?5OLn2ZoXpEe8oO72Xp+p3lDkIhfNyJwonyQfXnco3elcPzIlTxUVtyRz?= =?Windows-1252?Q?CRG2XzjYobBPQdvRHfhCMaRFdJksC3JsobQ3QIPxOskYFgFrR9S6DnZZ?= =?Windows-1252?Q?eWI/S0=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2438; 6:2Ers9gMRZm4xFNgE4ojTwg8Gpxam35hJmiDx4NRRYeL+dCf4EzdhcbzJvWpK1w0ToUkyEMt5/aLE/zXEkIJnXhFPRqucOPo9nsDCcAfbn4N+0+R7ki5OcmznajvXXIAp3kGkGPyRcmeRmcLoVi21tCumrpXShWsDWbA+XKuBlr9pWqxcuRpXVf+UF1C6S46/7hVg9CvYdnERRBWBCjbTwn/nCZuC38Bxb41qgNzDNB+B472IMOPQ0dn8enxhsT35seJ7+skNOVCzUjbTC6d64sFKn2FuUtuavE1M1Pg9Glc=; 5:SpdO4X8opECqw0f1iz9sZtG6CGXHg/wS0GAjSRxdDRPQUgrJyimYTNf7DLQ6gpIxkeGHVR8vNoV/0xo9RXCTAT2xWkIi93o2YdmZ4PHNwVhs2mUu3Ax7iIOawcJT7TRnN7chFQCf29M6nrHvQYIsUr9XetF7NxetY9SL6uwdWEA=; 24:sXazGGxeLYHLHrxsGkHtTHek2TLKQNRasqoc2bGKR+7wX0tChtSAHEe3b2JGHzsAH3IRya9n1sPty0fn1V6ZU/sIHj9Bpbkpk5ZQhA3vGrA=; 7:gBeahib9OM2lypgUN7KmUPKQWwjyIqOS6H/xg7OCOngyhFvlfhjkBp6y52x2E3QQIvGjxqIgaqHQPe6Au2NB4irtaEO6SpK7HnvKJC4sdXfn/8cjPWa3/IihVmU4F6b2sJcQRyT64hdw7AUwYYFneHHrkm0Hg6XWsk2kkta87iRaCcrx95vuaPxUZGY3XUvDoG4Z9yAJqRpZYc8hxtNIC4cgP+rrCJLmw8NCoFdhtxkSd9CZS2r1rhGABh8QamMZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2016 11:42:43.5102 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2438 Subject: Re: [dpdk-dev] [PATCH v9 00/25] Introducing rte_driver/rte_device generalization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 11:42:48 -0000 Hi Stephen, On Thursday 08 September 2016 10:19 PM, Stephen Hemminger wrote: [...] >> > I think yes. There are separate lists for all device types which helps >> > keep the EAL code free of type checks. But, functionally it doesn't make >> > that big a different between a common or specific list. >> > I am in favor of separate lists of each rte_xxx_device/driver type - >> > other than a global list (which is not actually being used, for now). > I was just concerned that doing bookkeeping on multiple lists creates more possibilities > for bugs where error unwind paths don't match. > That is true. But in this particular situation (in my opinion), maintaining multiple lists helps because: 1. Device/Drivers lists are separate and no functionality except setup and tear-down operation would ever need to parse the common list - at least not during the application run-to-completion-cycle. 2. Keeping them separate helps make the respective scan/probe code cleaner. In fact, in absence of checks for device type, I think debugging would be easier as one would only need to focus on code related to attached physical/virtual device. But again, above is just my opinion and preference - if merging the lists helps, it can be done. In fact, rte_driver/rte_device are already creating a common list - just that it is not being used right now. I don't think there is any technical impact of this (except increasing type validation - but that is only in setup/tear-down path). -- Shreyansh