From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DB0C91B6F5; Tue, 24 Oct 2017 23:38:42 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 24 Oct 2017 14:38:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,429,1503385200"; d="scan'208";a="166620051" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.60]) ([10.241.225.60]) by fmsmga005.fm.intel.com with ESMTP; 24 Oct 2017 14:38:41 -0700 Cc: Thomas Monjalon , dev@dpdk.org, stable@dpdk.org, Jianfeng Tan , Jingjing Wu , Shijith Thotton , Gregory Etelson , Harish Patil , George Prekas , Sergio Gonzalez Monroy References: <20171020165511.47899-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <6bc24141-767d-7835-d5be-4ef0144f4282@intel.com> Date: Tue, 24 Oct 2017 14:38:40 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171020165511.47899-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 21:38:43 -0000 On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > Remove device reset during application start, the reset for application > exit still there. > > Reset in open removed because of following comments: > 1- Device reset not completed when VF driver loaded, which cause VF PMD > initialization error. > Adding delay can solve the issue but will increase driver load time. > > 2- Reset will be issues all devices unconditionally, not very efficient > way. > > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit Tested-by: Harish Patil Tested-by: Shijith Thotton Tested-by: Jingjing Wu Applied to dpdk/master, thanks.