From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C13F7A0526; Tue, 10 Nov 2020 13:33:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 988BCF90; Tue, 10 Nov 2020 13:33:52 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 4E9D6DED for ; Tue, 10 Nov 2020 13:33:50 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id s8so5391050wrw.10 for ; Tue, 10 Nov 2020 04:33:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=zRCU+QxelNIDQOZ8M/eVOSL8yCC4h+dZQ6nyrUqSVxg=; b=lhpcL19UJm6RVnPatojn8UJtwVJwfiMY0YbDnlBy0uUTBIyF7rUN4Mru2IdqTl5Tc5 zSuRFw3JE05sXwYK5VhlgkQ92okiWtGZTYFMowXTeTStVGO0V16WcV2Mw6Sc5Rl5RiKC NFEARgLQPhNBJVjeRjWjsizmqx3y5W+NDF61jaYvPj8o3XW31gzUeqcnpe+tflLVOHW3 JtLfke8KEhbVARNUl9OBZiUVlXJRz2cmwwHRm0tmo9yoVATbtBya8X9hoTg6wqN4Kl7Q FpJNhH7yDZfWNTNbRYLwQfANMemBytfs9QFR7Ad1fwEdRRAkWAVlzbtN6jJaMkCIg7b6 a2OQ== X-Gm-Message-State: AOAM532DsQ+axmWwUC1n5g8iJacd6Wrg+ZSewwV8PXJVuHZTaXeL/zHJ lRSr8HEmyf1t95TmEn0jHvsaiS0JXICtfnyC X-Google-Smtp-Source: ABdhPJyJXYRGont1p7JO4R6jhCjiH6COeJwC2SJtJFisq+qOAg6mMXU+GWGUrFDt2MR5RFMK/t4uqg== X-Received: by 2002:adf:c803:: with SMTP id d3mr23578763wrh.108.1605011630041; Tue, 10 Nov 2020 04:33:50 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id n10sm17560223wrx.9.2020.11.10.04.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 04:33:48 -0800 (PST) Message-ID: <6bc3f5b2b1814fb1824c6d4864155377d9413691.camel@debian.org> From: Luca Boccassi To: Stephen Hemminger , dev@dpdk.org Date: Tue, 10 Nov 2020 12:33:48 +0000 In-Reply-To: <20201105223602.5965-2-stephen@networkplumber.org> References: <20200922143202.8755-1-stephen@networkplumber.org> <20201105223602.5965-1-stephen@networkplumber.org> <20201105223602.5965-2-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2020-11-05 at 14:35 -0800, Stephen Hemminger wrote: > This patch renames the enum values in the EAL include files. > As a backward compatible temporary migration tool, define > a replacement mapping for old values. >=20 > The old names relating to blacklist and whitelist are replaced > by block list and allow list, but applications may be using the > older compatibility macros. To help with conversion to new names > cause a message when the compatibility names are used. >=20 > Signed-off-by: Stephen Hemminger > Acked-by: Luca Boccassi > Acked-by: Gaetan Rivet > --- > lib/librte_eal/common/eal_common_devargs.c | 14 +++++++------- > lib/librte_eal/include/rte_bus.h | 10 ++++++++-- > lib/librte_eal/include/rte_dev.h | 10 ++++++++-- > lib/librte_eal/include/rte_devargs.h | 10 ++++++++-- > 4 files changed, 31 insertions(+), 13 deletions(-) <..> > diff --git a/lib/librte_eal/include/rte_devargs.h b/lib/librte_eal/includ= e/rte_devargs.h > index 898efa0d667b..296f19324fae 100644 > --- a/lib/librte_eal/include/rte_devargs.h > +++ b/lib/librte_eal/include/rte_devargs.h > @@ -29,11 +29,17 @@ extern "C" { > * Type of generic device > */ > enum rte_devtype { > - RTE_DEVTYPE_WHITELISTED_PCI, > - RTE_DEVTYPE_BLACKLISTED_PCI, > + RTE_DEVTYPE_ALLOWED, > + RTE_DEVTYPE_BLOCKED, > RTE_DEVTYPE_VIRTUAL, Any particular reason to drop the _PCI suffix from the enums and command line parameters? Does it apply to more than PCI devices nowadays? --=20 Kind regards, Luca Boccassi