From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0066.outbound.protection.outlook.com [104.47.36.66]) by dpdk.org (Postfix) with ESMTP id 94BFC1B3A3 for ; Mon, 16 Oct 2017 08:48:33 +0200 (CEST) Received: from BN6PR03CA0081.namprd03.prod.outlook.com (10.164.122.147) by BN3PR03MB2353.namprd03.prod.outlook.com (10.166.74.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 16 Oct 2017 06:48:29 +0000 Received: from BL2FFO11FD039.protection.gbl (2a01:111:f400:7c09::147) by BN6PR03CA0081.outlook.office365.com (2603:10b6:405:6f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.77.21 via Frontend Transport; Mon, 16 Oct 2017 06:48:29 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; caviumnetworks.com; dkim=none (message not signed) header.d=none; caviumnetworks.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD039.mail.protection.outlook.com (10.173.161.135) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Mon, 16 Oct 2017 06:48:29 +0000 Received: from [10.232.133.65] (B10814-12.ap.freescale.net [10.232.133.65]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9G6mPt8029653; Sun, 15 Oct 2017 23:48:25 -0700 To: santosh , "olivier.matz@6wind.com" , "dev@dpdk.org" References: <3e228854-d5d4-7dc1-6c25-29de7f6c37c7@caviumnetworks.com> CC: "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" From: Hemant Agrawal Message-ID: <6bda52aa-6084-0db9-d78e-57019c2f1f7b@nxp.com> Date: Mon, 16 Oct 2017 12:18:24 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <3e228854-d5d4-7dc1-6c25-29de7f6c37c7@caviumnetworks.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131526101093772240; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(346002)(39860400002)(376002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(189002)(24454002)(377454003)(199003)(53376002)(69596002)(65806001)(65956001)(54906003)(104016004)(498600001)(50466002)(966005)(64126003)(5660300001)(110136005)(316002)(58126008)(86362001)(23746002)(31696002)(77096006)(2201001)(2501003)(83506001)(47776003)(68736007)(31686004)(4326008)(85426001)(230700001)(6306002)(81156014)(2950100002)(36756003)(81166006)(8676002)(97736004)(106466001)(229853002)(105606002)(305945005)(189998001)(53936002)(65826007)(50986999)(33646002)(2906002)(8936002)(53546010)(76176999)(54356999)(356003)(6246003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2353; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD039; 1:vABKPg7s97LQ55PXm0WnNbUKSdYoRktoqKLwlWItHw4DMrSP5iwGWgN+hpKmgGNTfe+cvCce9uonxde5Zvvy8AE7wNIucP8xOl4rEtmu0aICNsxkPCkd8pobNogGjz4y X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14457109-65f9-4f51-8a71-08d51461e8d7 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:BN3PR03MB2353; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2353; 3:U2FPbmqrFyXcl7Y5HJzhTu+XKQGdzwXNAMR6qbhwVzOQpRbegGxHFVhJTElPXf59siEYcIlbPrxsrfEyle+CLT0LlUk+5+0J5wHXtiqCnAaDJSh4sQZ1ISgDTd31YQ/fKbh3LbJHpmFKA3LQV4CQyofDN0SQMe2QYvkNPYNp8BHzk2ayT0FEgy8UEMwN20CvZCHH7gbMD7UVVKHBCHJiV9gBxQlF1VT7f5Zwzrmlu3QvQdUC/cHzRgm1GZWFqkLQgYiGAitMVN3mJvtSo3pwT4sBv4I5HM1tnFnDDH4rWOty5iY+AsgJfRqkX2YfeuWBnO3EaHYVnJdpXRpsUlr2DZJ0Pi2NoCOcBnkqTogRqmI=; 25:4oaqlZ4LJOLhp4qcxqoGYsqAz7v8RL0FkDmpdhXNqVp3xFPKaOwOXGZuQpYzBEZ4NoFREbMrik1T7ALCh9+w1W3rr80eLpYtG1tYN0qHmtb2OQ689XMf4DS0esYFFZ4OCwxRLQ9rIWjFt+djqEOueB5u0iXu4q9IrvN4NTIhl4K69xUbdHM98tlbGcw2xT2rwom/PiBZW6v25IEl6ojjyokCLQYQWs0prxKas6tygFFlDFfGZY1V1iSI87pONOTVhZ4bEW1JWDr1yxGRm2hkAq7pIfSVUomuDJEM7wK9sh2a7WYnsqoTUG8VfSxvDIHlxTk/7G8z74jKCnYkiCUuuA== X-MS-TrafficTypeDiagnostic: BN3PR03MB2353: X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2353; 31:gp+FE/zy8y6E3X+r9TNy9lxdWus3sgGHCJVlFVyKcVQjdSEe13g5M639yh81nMzhWJYrq9QT+l8S0GICeWDITqCd0k+DthiOXmzND2KviK+Vw57J2v4VDD4xMAXtyzjUP6mCXvNNB1dYlC22d+JYZChXAuB4ZMkbCiYrYKCewSd9YRggUXBewC1kXq5A5Nvuxm+K86nJ7jLbKdJbROdMZVLrC7gcwC4hroE8/JOUHzM=; 4:WJ8sM6jOEIHPku1/3Vuf3U58ESGD3B5gcaCFt1L7+ZguJwvXAfkY4ToFL/NPi+fSvXjQBRSdqOdlE8AWPXJrzp5GMnlpzz2xW3vXIjyq5jxmdLLIiuJHSUixszankuslEvm7zyAXv6ZbNYDWNnTttELxC+fPw8qGK72ebVXlSClLiQS6C8/roZVYUO+7F4a8r6s3ej12W/I471sl2v5kFo19iB3BTqUTof35Pv2QcLtJe2DhAK5monvVlrJkIVe8 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123563025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123565025)(20161123561025)(20161123559100)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN3PR03MB2353; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN3PR03MB2353; X-Forefront-PRVS: 0462918D61 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN3PR03MB2353; 23:QnTMWJlt8SpALe/VLBx6DsXQSgATgOIyTgmsf?= =?Windows-1252?Q?PQio8QcVCUsIoGGlEw6IaJVE7kghdTxVj2SBQ9YT1klms9v7C+CaEGLB?= =?Windows-1252?Q?d7+JSMvAX9Z3v15s9nhYtv2zTrqAO+MEoduohL9yq3/527yR/c1Vza/s?= =?Windows-1252?Q?bwc2hXGrBS+eSd1n9wYt5m4gcr3Shg6L89UJPG/MiaSoy1+iyNXQwTv/?= =?Windows-1252?Q?VFR7qCB8ZgznxCrcsWA8dJqhgdI8YXvssCa0f5f5kZ3kyfFv6mGO/YPf?= =?Windows-1252?Q?6iGrkm1+jsdbLxLBRui6PDpPGu/QIdNlYGLI3SqkBlWesJ4Paqjz6OvA?= =?Windows-1252?Q?CuMel/p2YyL3nBRiyXrnnK0IU/IMVV6WQ59zhOzn7Xw0WU7xVlBPyYbD?= =?Windows-1252?Q?hk9brM7cTvH9mbs4CgjOtAqDEtKokiCXyV2bh4r8/bBX0UUCgV103wRx?= =?Windows-1252?Q?bMclPqJTK5IJmJtquEQrkGS4e6wc4k4aTqmhRegasXChxSr/iYOjo1PV?= =?Windows-1252?Q?cO3TMkFgyQkHDJYNb4yg5x+D7WneZLdSoAdSjI82Cpdx+8HTReUXsZwa?= =?Windows-1252?Q?BJaC6EkEOzD00WBcyysB/+a8bEZOyDaCQ5/i78pKhStXGLFkQBJid/DF?= =?Windows-1252?Q?DFIEsBgQchvAHf0oh4Jt1qtmzkPUDC2JyoRUmhFKCeSlESC1aOjho/mK?= =?Windows-1252?Q?I81+XotgTvFoZFu3+lupbwjwrnZvkobmEl0vLtO2Zgs3jQlq2uR/8X2e?= =?Windows-1252?Q?gDT1NPBnMYJvM15s4w8wmmVmeYRB4tHdM2woWMp8zWoc+sypLGGbEmx7?= =?Windows-1252?Q?uXKPWgVyuSuJg4zFNGC1CN34qjrhqcvQj+zJisfKJCGyOtardh8IQFhF?= =?Windows-1252?Q?kURiX1qCH3qvHWGp/UfVt5rPU5JJY75Z04i2AZLezEr6KJXsQZxs6LFe?= =?Windows-1252?Q?KfKjD9G9k0Nc9CCIMVwUNXBoqfcAiuX+QdzX2rH0Ger8AevK/8VsO7sd?= =?Windows-1252?Q?ECfjbjcoVDfHPDBECX38jmVlj/bEfe+acvu0UA94UJcSlKAAi4q08Rfx?= =?Windows-1252?Q?lOlRI8Xt34/AE5rGURm9EBktYRfnVVruOb4UgoGG3CLHXiQqyWCU5Qpb?= =?Windows-1252?Q?ZS0BB13S+oQjrDHmvKdpIFYjmXoloiaNbvXlj94c/OAhAerTMPzZRDZh?= =?Windows-1252?Q?eh9QGraiJeABN9yy+3wAyyfsOUhmf2+t8LhwpoqZ+H4wcuV7FieS284H?= =?Windows-1252?Q?JdWjsutN6zpdy9hUcnxg+Z9m7a5+h5XEpb/TcDmtzEL2+oIqrEfOReEj?= =?Windows-1252?Q?JTRQdH+OdosCO7H+c1LExarkw9ODMJlxxrz4XHSwyS7dPicA05Vp2cn7?= =?Windows-1252?Q?XWrVIzlAhHBvIt3p6a0mf6xgftqTg8YYPrnV75ZRhUxFtIZIY1z15jiN?= =?Windows-1252?Q?IiYLhByHoJtXBQOfEyifadfOX1Zqz6f5CIS2EwVogtAzKVTvaac6hpBa?= =?Windows-1252?Q?VvDnl8aAVTmzWnpMIoSRwhR2DNk5e45oGTihQSOxZEUacPeOtGXphouu?= =?Windows-1252?Q?YsYiG/aJBrkd6iv5n/oTZDZpRksMBfr6Z2jOgelOvkuiAZKQfyYBvX3L?= =?Windows-1252?B?dz09?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2353; 6:BNQymZmM7DGpO3wZtNs/yr5mIdAI93tfpCnp2scotk1+xCSSX+/wfpDigKYY9wY1gyNry/5W4s7mSsbYfO3scIEVQd17XlLg7/V4jDWxkQScNmgJB7SiBEqKylqZR0qzdCmhn4KyeLR8XfPeSzLSnkWA54CfUAZfibBVMMfqFElSxKjJm90zYsaCZyNR5o8qPJoMnfL+oF5anSNmWYmqdpPRaC4NuSplSExkCZADXyEJXYkFLMjU1VjRdmGwPRYnXqb0wcg9r7y9G2NuPEZyO6JoviwDhRIjitYKsZY6FNk65BivN9JrNKZC9yZxjR8zh0tNp80glyzOS9toFLnPvg==; 5:oUl7CrJYeo1J9FyTt0lCKgWFyRx3I7sSo5lfeax447AlsGvXRW8uYsGRw/ndfXCsfLwaofX0kiY7V2gqf2QCzyH82bFovRFO3hAv/OM1TGD6AvgW3TUuBo0dGXBiqvDq/uPcZZrA3XmKea/YquOpxV8jXchSsNOkBJyCnxWDZxo=; 24:7zx81knpTjjkm6tYOop/SjeXZJg5Tq/uT/4gVYv5GY4bmhfhjZhmDB9SYlNsVqJ0K91KJs6XwNx0/06H30sonc5tjJVHyf2zusopgrhnCo0=; 7:NnAg8oCDeuWOHgy+3YSPBeosBYdZ2nZWatna+2BTfwfsuncirLyI5GYPhJ4PPV2LuwhW9GABTGRJ6XOSMbRRJfjObi0hS5leSMYRu/MY3XwbTcWzdrWRgsVV5VvtOT0MIBkhcRniZL1lZjyXpPuqmDr/5BfEijdDakk1/gOhAz/GWUofHBl9bh6tgFZP+6irjjulco1gTnN4YajWnNHQmLwnGk5pF49+i0lNEDhB+74= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 06:48:29.0652 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2353 Subject: Re: [dpdk-dev] Shared compilation issue - mempool/octeontx: add build and log infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 06:48:34 -0000 Hi Santosh, On 10/14/2017 8:57 PM, santosh wrote: > > On Saturday 14 October 2017 11:37 AM, Hemant Agrawal wrote: >> Santosh/jerin, >> Your patch "mempool/octeontx: add build and log infrastructure" is causing shared build failure for NXP's patch "event/dpaa2: support event eth adapter", which is still under review. >> http://dpdk.org/dev/patchwork/patch/30248/ >> >> In your patch, you have added mempool to be dependent on event, which is not correct. >> >> "+DEPDIRS-mempool := bus event" > > Yes, Octeontx needed mbox definitions and it was defined at event area. > > But You are right that adding event dependency in mempool may create issues > for future feature like you mentioned. > >> Ideally, if you have common code, you should put that in bus or mempool . This way you can make event, net or sec etc dependent on bus or mempool and not the otherway around. > > Right. > Proposed change for makefile will be: > > diff --git a/drivers/Makefile b/drivers/Makefile > index 3a5b22342..0467250aa 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -32,13 +32,13 @@ > include $(RTE_SDK)/mk/rte.vars.mk > > DIRS-y += bus > -DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event > -DEPDIRS-event := bus > DIRS-y += mempool > -DEPDIRS-mempool := bus event > +DEPDIRS-mempool := bus > DIRS-y += net > DEPDIRS-net := bus mempool > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto > DEPDIRS-crypto := bus mempool > +DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event > +DEPDIRS-event := bus mempool > > include $(RTE_SDK)/mk/rte.subdir.mk > > Can you give it a try and let me know your feedback. > This change breaks the octonetx compilation. You may also have to move the the common code from event to mempool. Regards, Hemant > Thanks. > >