From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id F25B81B168 for ; Tue, 9 Jan 2018 11:46:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 02:46:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,335,1511856000"; d="scan'208";a="17811971" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jan 2018 02:46:24 -0800 To: Hemant Agrawal , dev@dpdk.org, Luca Boccassi References: <1513166759-13466-1-git-send-email-hemant.agrawal@nxp.com> <1513166759-13466-16-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: <6be0ca5b-0e27-a071-b221-037bec5658b1@intel.com> Date: Tue, 9 Jan 2018 10:46:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1513166759-13466-16-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 15/18] net/dpaa: add support for loopback API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 10:46:26 -0000 On 12/13/2017 12:05 PM, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal <...> > @@ -0,0 +1,37 @@ > +/*- > + * Copyright 2017 NXP. > + * > + * SPDX-License-Identifier: BSD-3-Clause I guess latest agreement was without break. > + */ > + > +#ifndef _PMD_DPAA_H_ > +#define _PMD_DPAA_H_ > + > +/** > + * @file rte_pmd_dpaa.h > + * > + * dpaa PMD specific functions. > + * > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice What about adding a @warning for this note too, otherwise it is very easy to miss note. > + * > + */ > + > +#include > + > +/** > + * Enable/Disable TX loopback I am for adding EXPERIMENTAL tag for API as well, otherwise it is easy to miss. I suggest adding @warning as well to highlight is as done in rte_member.h > + * > + * @param port > + * The port identifier of the Ethernet device. > + * @param on > + * 1 - Enable TX loopback. > + * 0 - Disable TX loopback. > + * @return > + * - (0) if successful. > + * - (-ENODEV) if *port* invalid. > + * - (-EINVAL) if bad parameter. > + */ > +int rte_pmd_dpaa_set_tx_loopback(uint8_t port, > + uint8_t on); PMD now has PMD specific API, this is public API, can you please update related API documentations to document this API? > + > +#endif /* _PMD_DPAA_H_ */ > diff --git a/drivers/net/dpaa/rte_pmd_dpaa_version.map b/drivers/net/dpaa/rte_pmd_dpaa_version.map > index a70bd19..d76acbd 100644 > --- a/drivers/net/dpaa/rte_pmd_dpaa_version.map > +++ b/drivers/net/dpaa/rte_pmd_dpaa_version.map > @@ -2,3 +2,11 @@ DPDK_17.11 { > > local: *; > }; > + > +DPDK_18.02 { This API is EXPERIMENTAL (as far as I can see from above) so having an experimental tag is better. How to mark an API as experimental is not documented, we should indeed. cc'ed Luca if I am missing steps related how to make an API experimental. > + global: > + > + rte_pmd_dpaa_set_tx_loopback; > + > + local: *; > +} DPDK_17.11; >