From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A66BA04DD; Mon, 26 Oct 2020 20:01:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33DE11E2B; Mon, 26 Oct 2020 20:01:53 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 15EA51D9E for ; Mon, 26 Oct 2020 20:01:50 +0100 (CET) IronPort-SDR: wabqjA9BFLFAUXdR4bKwwXRKQWfrLZK5/l69psHPUu6Z+jazOQakKiYqTh0fp15AJcvv0vy+Hv LB+aoIgQ+4UA== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="154939433" X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="154939433" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 12:01:48 -0700 IronPort-SDR: SBZsoHOqWexQyxuHOuSxttKcaSUN8UUwmiTFPILxv2VpO2tYOrL1T43+5LQP7NLDh5WUC6P1M4 L/9dILWYRi1Q== X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="524391449" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.254.70.55]) ([10.254.70.55]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 12:01:48 -0700 To: Dmitry Kozlyuk Cc: dev@dpdk.org, thomas@monjalon.net, ranjit.menon@intel.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com References: <20201021202616.2732-1-pallavi.kadam@intel.com> <20201022220518.3ddab665@sovereign> From: "Kadam, Pallavi" Message-ID: <6bf4b9f3-68c5-7546-4d43-e5361a577835@intel.com> Date: Mon, 26 Oct 2020 12:01:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201022220518.3ddab665@sovereign> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] eal: create a runtime directory on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry, On 10/22/2020 12:05 PM, Dmitry Kozlyuk wrote: >> /* Detect if we are a primary or a secondary process */ >> enum rte_proc_type_t >> eal_proc_type_detect(void) >> @@ -181,6 +231,13 @@ eal_parse_args(int argc, char **argv) >> } >> } >> >> + /* create runtime data directory */ >> + if (internal_conf->no_shconf == 0 && >> + eal_create_runtime_dir() < 0) { >> + RTE_LOG(ERR, EAL, "Cannot create runtime directory\n"); >> + return -1; >> + } >> + >> if (eal_adjust_config(internal_conf) != 0) >> return -1; > Windows rte_eal_init() forces in-memory operation (internal_conf.in_memory=0) > with a warning message, because runtime directory and shared configuration is > only used for multi-process. Maybe do the same for no_shconf, as it's > essentially the same, but for legacy mode? Thank you for the suggestion. We sent out v2, forcing no_shconf to 1 for now.