DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Deepak Khandelwal <deepak.khandelwal@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH] eal/linux: skip attaching to external memory chunk
Date: Wed, 20 Apr 2022 16:32:44 +0100	[thread overview]
Message-ID: <6c2ec2b9-eba3-25ea-155d-04049b3a0a11@intel.com> (raw)
In-Reply-To: <1649075577-67300-1-git-send-email-deepak.khandelwal@intel.com>

On 04-Apr-22 1:32 PM, Deepak Khandelwal wrote:
> when secondary process is initialized(rte_eal_init),
> external memroy segments should not be attached.
> These segments will be attached by explicitly invoking
> rte_malloc_heap_memory_attach API
> 
> Fixes: ff3619d6244b ("malloc: allow attaching to external memory chunks")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Deepak Khandelwal <deepak.khandelwal@intel.com>
> Suggested-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>   lib/eal/linux/eal_memory.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c
> index ee1a9e6..18d2176 100644
> --- a/lib/eal/linux/eal_memory.c
> +++ b/lib/eal/linux/eal_memory.c
> @@ -1875,7 +1875,7 @@ void numa_error(char *where)
>   		msl = &mcfg->memsegs[msl_idx];
>   
>   		/* skip empty memseg lists */
> -		if (msl->memseg_arr.len == 0)
> +		if (msl->memseg_arr.len == 0 || msl->external)
>   			continue;
>   
>   		if (rte_fbarray_attach(&msl->memseg_arr)) {

Actually, this needs to be implemented for BSD as well. Windows doesn't 
have support for secondary processes yet, so it's not applicable to 
Windows as far as i can tell.

-- 
Thanks,
Anatoly

  parent reply	other threads:[~2022-04-20 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-04 12:32 Deepak Khandelwal
2022-04-20 15:26 ` Burakov, Anatoly
2022-04-20 15:32 ` Burakov, Anatoly [this message]
2022-04-21  9:11 ` [PATCH v2] " Deepak Khandelwal
2022-04-28 12:08   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c2ec2b9-eba3-25ea-155d-04049b3a0a11@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=deepak.khandelwal@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).