From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6E67A0579; Thu, 8 Apr 2021 12:32:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40552140E1B; Thu, 8 Apr 2021 12:32:20 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id 7945640698 for ; Thu, 8 Apr 2021 12:32:19 +0200 (CEST) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FGHbB28vLzkjJR; Thu, 8 Apr 2021 18:30:30 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Thu, 8 Apr 2021 18:32:17 +0800 From: "Min Hu (Connor)" To: Ferruh Yigit , Ajit Khaparde CC: dpdk-dev , Xiaoyun Li References: <1614906276-34293-1-git-send-email-oulijun@huawei.com> <1617068905-5364-1-git-send-email-humin29@huawei.com> <1dfa9ed4-052e-22f1-a84a-c49303edbc00@intel.com> <1b992d1c-2af7-8c38-8916-f62b21bd46fe@huawei.com> Message-ID: <6c3381a7-631f-fdfa-db1d-a4ff2d67dcaf@huawei.com> Date: Thu, 8 Apr 2021 18:32:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <1b992d1c-2af7-8c38-8916-f62b21bd46fe@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferry and all, This patch has been acked: Acked-by: Xiaoyun Li Acked-by: Ajit Khaparde Are there any other comments about that patch? 在 2021/3/30 18:43, Min Hu (Connor) 写道: > > > 在 2021/3/30 18:19, Ferruh Yigit 写道: >> On 3/30/2021 7:41 AM, Min Hu (Connor) wrote: >>> >>> >>> 在 2021/3/30 11:11, Ajit Khaparde 写道: >>>> On Mon, Mar 29, 2021 at 6:48 PM Min Hu (Connor) >>>> wrote: >>>>> >>>>> From: Lijun Ou >>>>> >>>>> This patch adds multi-process support for testpmd. >>>>> The test cmd example as follows: >>>>> the primary cmd: >>>>> ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ >>>>> --rxq=4 --txq=4 --num-procs=2 --proc-id=0 >>>>> >>>>> the secondary cmd: >>>>> ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ >>>>> --rxq=4 --txq=4 --num-procs=2 --proc-id=1 >>>>> >>>>> Signed-off-by: Min Hu (Connor) >>>>> Signed-off-by: Lijun Ou >>>> Some minor nits below. Otherwise looks fine to me. >>>> Acked-by: Ajit Khaparde >>>> >>> Thanks Ajit. >>> >>> Hi, Ferruh, >>>      Should I send v9 to fix the grammar bugs in doc which Ajit point >>> out or fix it in future? >>> >> >> Hi Connor, if they are only outstanding issues, I can fix them while >> merging. >> > Thanks Ferruh. >>>>> --- >>>>> v8: >>>>> * Added warning info about queue numbers and process numbers. >>>>> >>>> :::snip:::: >>>> >>>>> +*   ``--rxq=N`` >>>>> + >>>>> +    Set the number of Rx queues per port to N. N is the sum of >>>>> queues used by primary >>>>> +    and secondary process. Primary process and secondary process >>>>> should have separate >>>>> +    queues, and each should occupy at least one queue. Where N >>>>> should be the multiple >>>>> +    of number of processes. >>>> of the number of processes. >>>> >>>>> + >>>>> +*   ``--txq=N`` >>>>> + >>>>> +    Set the number of Tx queues per port to N. N is the sum of >>>>> queues used by primary >>>>> +    and secondary process. Primary process and secondary process >>>>> should have separate >>>>> +    queues, and each should occupy at least one queue. Where N >>>>> should be the multiple >>>>> +    of number of processes. >>>> of the number of processes. >>>> >>>>> + >>>>> +*   ``--num-procs=N`` >>>>> + >>>>> +    The number of processes which will be used. >>>>> + >>>> :::: snip :::: >>>>> +The number of rings should be a multiple of the number of >>>>> processes. If not, >>>>> +redundant queues will exist after queues are allocated to >>>>> processes. After RSS is >>>>> +enabled, packet loss occurs when traffic is sent to all processes >>>>> at the same time. >>>>> +Some traffic enters redundant queues and cannot be forwarded. >>>>> + >>>>> +Most dev ops is supported in primary and secondary process. While >>>>> secondary process >>>> Most dev ops are supported in the primary and secondary process. >>>> While.... >>>> >>>>> +is not permitted to allocate or release shared memory, so some ops >>>>> are not supported >>>>> +as follows: >>>>> +``dev_configure`` >>>>> +``dev_start`` >>>>> +``dev_stop`` >>>>> +``rx_queue_setup`` >>>>> +``tx_queue_setup`` >>>>> +``rx_queue_release`` >>>>> +``tx_queue_release`` >>>> :::: snip::: >>>> >> >> . > .