From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0791DA052F; Wed, 29 Jan 2020 15:57:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CA2F1BFFD; Wed, 29 Jan 2020 15:57:21 +0100 (CET) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by dpdk.org (Postfix) with ESMTP id 0690E1BFFB for ; Wed, 29 Jan 2020 15:57:19 +0100 (CET) Received: by mail-lf1-f47.google.com with SMTP id t23so12060049lfk.6 for ; Wed, 29 Jan 2020 06:57:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=zo7Imw/1ZOfA9OuIqZpaekge5nZQHY0edWdVqa4MnGg=; b=V0WO+HpAEV4BP4vEkq+IJCXw++HQviWnUtp9Vb+SXG7/SCRo5n4nKLHGDPxHwD1Zla TjsAakBuii3OkEcNzgpAFi/AxRBJdvUFhdUlBzIhUeoqi+1dHahhsB/eixOKo1Piwzf6 3xShwnG69Fsm/YYlic2TTBRrW8mvzED6kNnQ5ve39Cd/G+4j7HHWZTtfJ1NP8cfXbGAr lAymr30GPZVEZmvaDZo9i8zpvOHnS08d/uGIT1U5Z67DhWuilSGiqFwIyQgVLiToo3F8 y0K8NTN7HgCH9mzjF8DkrfwnJqh7LjVZHvnqOOlpaiztNNQ3rWAZnOBWtrgu6LBOQZJG Qb7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zo7Imw/1ZOfA9OuIqZpaekge5nZQHY0edWdVqa4MnGg=; b=DIZ9hLks1Db2drQEjXlbWDzS9vcJYyiy7Q74sI3qdmFAEGO1/ZD92CwcKUx5gcP8xs Nq4ovcGMCehjs85WLmS30e6iiex0Z/+ZGOkYIzCJZr1UEj8UwoYA3krvgwBIpAvXPIbF 1KE4foc1pLoSAylyRf5XIYMHGR8K2ezs24usFyYX6c/UBJydaQg7MsyV2RuIoJffNDLD nwxt6pWuHtUPyeG1o7J9yDmcSPAL4nHkTj1JBXkE9IR96DF2c9av0TCItHhDpJwlMAX5 B4dOWoXdVCwJ7EsSg/XtTfwkKmskx3FUSqqnZCs2Ck9NPTs6ZNrFROiaRDja8u1VGcOZ BV+Q== X-Gm-Message-State: APjAAAXbw8gQEvbqHjStHECGMVTIr1cCHZ+d/BEBzp2DmFcME8nMgBqO vtHKP6KVGftl4CH3e6MxpjJLPp2wl7oVfQ== X-Google-Smtp-Source: APXvYqyCUq1jPy2lK9ebFebSiE0D9KrPAZGnze8RVRVanAK1MKLh5M8y8TLs/UPpf0gvj7ickJAvjA== X-Received: by 2002:a19:6d13:: with SMTP id i19mr5676850lfc.6.1580309838917; Wed, 29 Jan 2020 06:57:18 -0800 (PST) Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id i4sm1112861ljg.102.2020.01.29.06.57.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 06:57:18 -0800 (PST) To: dev@dpdk.org References: <20200129122953.2016199-1-ferruh.yigit@intel.com> From: Andrzej Ostruszka Message-ID: <6c54a5f4-c766-26fe-acdf-8768f300be71@semihalf.com> Date: Wed, 29 Jan 2020 15:57:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200129122953.2016199-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/29/20 1:29 PM, Ferruh Yigit wrote: [...] > Updated meson build system to allow the versioning, > 'use_function_versioning = true', not sure why it was disabled by > default. AFAIR this is to save build time with meson. By default static build is made and from the objects from the static build shared library is constructed. This works unless function versioning is used - because for the static build "attribute alias" is used and for shared build .symver is used. So 'use_function_versioning' by default is false and only libraries that actually use them have it set to true (and perform separate shared build - see lib/meson.build). I've now noticed that LPM, Distributor and Timer libraries no longer use function versioning but have it still set in their meson.build. With regards Andrzej Ostruszka