From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B839A0547; Wed, 27 Oct 2021 11:55:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1892340E0F; Wed, 27 Oct 2021 11:55:53 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 24A1240E0F for ; Wed, 27 Oct 2021 11:55:50 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="253672408" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="253672408" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 02:55:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="579538116" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 27 Oct 2021 02:55:49 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 02:55:49 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 02:55:49 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 27 Oct 2021 02:55:49 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 27 Oct 2021 02:55:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4yD/l/wmRrmjVb0lEne1MOh1E0cv07M+aGGBdYFsYt6XVN/Y6kCrz9bOiQ9vls3ygb4C0zF0ugh36C0l2a/CsRj9PBLc5K89rNBx4TFBZNS5fYjY8VRMVQGKgnmwH4adRdxNJTsA4Hzv58G9FNfBpqg0t8vZtUu5WyeOkmoSTAG02YXl9foJqpDEc2dA7sgrKkmgdkkis3cW6Tclo+KgqGQMt5HcSbhlUeY6cNOMMnsGuRVwM6tw1YmHyYEL5TZZdwN+m4ZzR1YPmeJCSi62puI6w6GBL1gV4+kXYkrbYSmBApd4sy6cXcY2IR/jNCQDjcrIbqZuLtoz408+FSKiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PS5ZYz7/sXLQYw5SgBBFB1fs1ugXet2qMO2gi119oPM=; b=GIoyo0HyvUrte/m2XEbo4fO68gcLXVofGWrZBkejipYkmrxfVeRXsu13XSQAf7NcxV/nsrI8x8W7Dxv17m3QFegl40uBdVHlyZWkaJvGzeGHxzfJ+cBzgK1YhXGZmzj4PVRFWNKN6yiFsoQpB6BkOHzpSlo0aim4Crcl4oVWiWMcsKoWfWSDGizHwFSPKvBWaFnF0f2aMx1j5AqLBu1H2BIw/SOj3zxhb2uDYY6EsafZqcfx98h00/8rRI9E9DTttly2dKyMIQtUdMhV44PvDeb5DEONGyGnhoBPeXEiDlK4SsINR8fF9oTZ7hb2hX8RJft+TCsoiYmoYtp2mT5kNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PS5ZYz7/sXLQYw5SgBBFB1fs1ugXet2qMO2gi119oPM=; b=QIe+q3y0+s6+bDKsMKtsIClc15EBxjmkw8oWtI01i+fHE7OWILXslvEFAD9ynPLC37NslD/2c1QAJNVGPDUXzE5jypnmJekrK1EZwIX24sYo8NjQQSscT2gwiPN9PQcInTcUbvTGOTxnC5TVvxu7TEXlR5xAsodtaYq0PrGcskw= Authentication-Results: stud.fit.vutbr.cz; dkim=none (message not signed) header.d=none;stud.fit.vutbr.cz; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4773.namprd11.prod.outlook.com (2603:10b6:510:33::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct 2021 09:55:47 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.020; Wed, 27 Oct 2021 09:55:47 +0000 Message-ID: <6c5a60db-4062-ad0f-5298-baa91553a1f1@intel.com> Date: Wed, 27 Oct 2021 10:55:39 +0100 Content-Language: en-US To: Martin Havlik CC: Jan Viktorin , , , , , , , , , , , , Ori Kam , Dmitry Kozlyuk References: <20211005171613.2879-1-xhavli56@stud.fit.vutbr.cz> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211005171613.2879-1-xhavli56@stud.fit.vutbr.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR06CA0017.eurprd06.prod.outlook.com (2603:10a6:10:100::30) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR06CA0017.eurprd06.prod.outlook.com (2603:10a6:10:100::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Wed, 27 Oct 2021 09:55:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 767ac7ab-e800-4be4-9001-08d9992ff32e X-MS-TrafficTypeDiagnostic: PH0PR11MB4773: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y5PrPGlUHaiGyaZFeq8F7dX7SjGpHPRRrCIJzmQ8oqp6KdhIgGC1tJ1Pj6oaoqUpqR8a8PbL3DF25qZIeGuRAgGU5MCK9Wer7QG+OjTsDjC0WgaFiJ7gQdnPuEBWoieAWmJL27Zeu/YysZH5PgD+npemizHitbNtVaJfLHZBVgKoqUR67v0gAasToWuV3aNdEqKAqcEMPmporpuuvy1KQAJhtLm1IdrKqwR8aIGjOYGvs/VXGyoyRvEqGCoyLvRH5RX8zrgr+J+fpdE5RxkUPBl0offU1hYDUXXIlel1QsYrjvAEtKe48dBVWAXFeAFbg24xERTBwfdtyDeH+4YcG6iN9o30dvH57qx6UIS7hXZ35cLYQV4V3rO572xqpU76IRp+mnmBzh8jz5tXijRp7eYvp3Py4OSS8wkZM1ZsvbJc01810E8Ide63AEWQZdRZ9qU2PzHq6nWz/HPWZvjrZKkCVE6xJhLQmMVTYURawnd9Sl1nrBsrPrEJ5u4eb+3hO/Ye++oKVsk/3xjgBtJ3nZXgULnvfo6IUkO8OpL8kOvNqSx8KsgNTq7weXkll14zgWKmyt13vuPXt01NkC87fwspuT0Vb7Y/xIm36unNRQ53TZgCZkATWWSsfYhAz+lvvG86c7kmMwI8IJ6kWIDKH+hofObG1pNw3wG0t3X+6CWgiKDpKQFKt8NxOKmXi4f3FTlpqKXGLryDuYrbuRpFCGv9GIhvbgVBLG72QYaiYt+BaW75QRJuR2ThjOXM7XgzktrFffpRCflKMpogVpFL1rtVkcb7OGMzG32RnjYF1vw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(83380400001)(66946007)(6486002)(44832011)(38100700002)(66476007)(6666004)(66556008)(26005)(86362001)(2616005)(6916009)(36756003)(31696002)(54906003)(31686004)(16576012)(186003)(53546011)(508600001)(8936002)(956004)(7416002)(4326008)(966005)(316002)(2906002)(82960400001)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTdNaE9WeTFOYWhCN0xzdjRrdmpLY0Z6SVpxRSttMDh0RHQvU0xqcjZhdTNG?= =?utf-8?B?NGZUM0FQMmtzVncxYm1sZTIrT3dsTlYyR0hpdEZreDc5eWZUY2Q0UjRkakZ5?= =?utf-8?B?Z3dDc01CanlSMTkwWkM3dXdGcFE5OS9vYUNHUTMrL2JMSWdQUjdXVVZCNU1M?= =?utf-8?B?NmZNNStMMm9JZ1RIajBTTnBheVB2MTZudkloTjY1RWJDdk9SUjhuQVlob2Y3?= =?utf-8?B?Y3VCeUNkUFE2OVBlWVEvMmZnU2NsckkxbHk4U0g2YmNHS05JSlVWTzlDWE80?= =?utf-8?B?alA3dHdoeW9FZSt4NzZDcUdCT050Yjd1TWFBam1SUFpSYnhHVjVVOG95WkxG?= =?utf-8?B?alIyclhBS1h3V3luNTJTUDRyYUx0TEcvQ3BHaUNMU01TOFhQZU1xOUw0WGc1?= =?utf-8?B?Vm5vRi9wRHppd085RHVvQ3pFK0pQdDNudVVoNEtuRkhZQnJIMzBvSHc4MFVy?= =?utf-8?B?bStLckFIZUdUZ1QxTXloWEFFeDZ4QkVOdWpFNndmOXB2RWJEZXpIQmVrbUpW?= =?utf-8?B?YUt5M2pLWE03cStoZVdUZ1RRUDlLQjNQV0xOdElEUkxkSWVETDF1dUtieFNE?= =?utf-8?B?enVjS0tqOVdMWWdKcFRPdC9vTWV6aWJmODJNZ25SRjVEQXJ0ZEhXelR1L05X?= =?utf-8?B?MnFEL3J4eWIrTElRQmhsZ0puQytsNGNpUUQrT1I3OGprbi9FaDY2YTNpTzFK?= =?utf-8?B?bzZQdFBhOVNGK2RrUEZyM3ZacGV3QldLM3ZPOXIwK0ZOejZuQ1pHQlpJb01x?= =?utf-8?B?V3JqQ3c1LzJ2OC9LMWZoWGVUdUxlVFZuYjAwNllDWTU2TDFPV0puOUhzRTEv?= =?utf-8?B?QVFwMmZJVFVicEVKaTRSMXRYSVl6Zlh6NFBqa3JtTVZqQTViQ25iZXE1bSt2?= =?utf-8?B?Y1hKc0hhaUtmNG9EUlB4UXJhZ1hPZUFiaFlkRWo2bUkxT2krZ1d0TWVCcFZn?= =?utf-8?B?VEpUU0pUOWlHem5KV0dPNXBZSXE5MmZ2N0JVQ0k0SjBHRGgyWCt2a2VJY3BG?= =?utf-8?B?UVN3VEp0U1dNMTZ2UFY2MDhUejZpU2QzV2Q0VFRMNWZCUHQxcFQ1cUxvZk5J?= =?utf-8?B?L0tGZTdDb1d6Unl4ZStoU3FHVmhrRnBKTy9FQ0JzZWJ5eWxzVWVndDlYQUFw?= =?utf-8?B?Z2ZndjdDWmpObXg5T1lDT0ZUVlFXWDNYV3p2UWtDQVd2Zm9BVmJuR2FhSzhx?= =?utf-8?B?UlpTQjQ1c3JZdjVvTjVtbUpLVHRJRnRQcWtPTFZ1WVhtaEpTUUlNNSszTlk3?= =?utf-8?B?NGU1dnNsb3ozOU9wZnVpcVJrNTdlT2NMdStNc043aGxGQzhUYTZwdlJuTm1L?= =?utf-8?B?U25XTU4yQXY2Mm03dnEwTkJHVFYvbUsvWjFwMHNlRkM1eVRNMHp3bGN5SCtB?= =?utf-8?B?elVrNkd6VlFKeDdqOFczTnY5TzNrRGRlSHhobVNGODBreEZWbDl6N2lxQmRT?= =?utf-8?B?dUFEWVpJUlJHTi9mRW9yaVo2VHNaTkViQjR0MFBjQWNyWnZhZVZKU3JrZVZT?= =?utf-8?B?QTdteU90cUNPYjFWTUZZYjduUnB5RVQzM3dXR1RRbzFqSDgrL085YUFaVWU2?= =?utf-8?B?Y0wrcFRZc2JBWUFYUWFKNEVIdSt1TTBTeThROHgzWldCL0Z5NW1naFlnQ2dE?= =?utf-8?B?c3Job0RnSHZkL0sxN2Z5Wk91dnppeWU4YkVQK3hLZXlaeXZnUGRmOVU0VWdo?= =?utf-8?B?VGtCZ1picEpQSXovSEc2VVZOLzIva3lnU2NMbWh4RksxL2RBUHJBb0dPUC9Z?= =?utf-8?B?cG5NbVJCM3QxRURXVEVhdmx0bW12NTUzbWRBRU4yMVprTm5ScjFGcExmTXpH?= =?utf-8?B?QjJPc1B0akMyMTZUUjBwZmZUVXM4anlYaVhsQ2ZMc3Fpa0JLeWdwcDFxY1Bm?= =?utf-8?B?RWNVbXl2RmJ4dUx2UHNWWjBlWTc2OXpuNzl1NTRXaEhJazNocHp6N0pTS1gr?= =?utf-8?B?SmtNWno1TXpkRjc5cmJ1ak1oZ21ZN1U0R0Mvd2pka0NzV1hUSEJ4M3pWcXVN?= =?utf-8?B?dG4xWFk0bUdrQ21LNTVkbkJaT05ySGNDK0dTWnBYNHQ5MWNqUEl1RW41TFd2?= =?utf-8?B?aWVNcW9GNi9oYUxwYkNJZWJIYXBobngzd2s1ajF5WFNXY2p3cUNhY0hING9j?= =?utf-8?B?WktNcGRBcCtOT1drTjZPTGYzT2U4MVdRNklrS2NsVGJUVG1SQytKN08xaHRS?= =?utf-8?Q?KGVeBIXiKqN7cV1XZBWNoTs=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 767ac7ab-e800-4be4-9001-08d9992ff32e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 09:55:47.6533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2vrgvwZ9dmHDrDsXkAIKbq/UDcHkf1IiOcaSxIZjL6ZBslY7QPx53tYXnRQLHAJB9Lx74HYVCX/X7QNPowyH7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4773 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 0/2] net/bonding: fix dedicated queues flow rule issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/5/2021 6:16 PM, Martin Havlik wrote: > This patchset stems from [1]. > > Not all PMDs allow RTE flow rule creation before device start. > Introduced capability marks the ones that allow it. > The capability is then used to fix flow rule creation for > dedicated queues in slave devices in bonding. > > The introduced capa _will need to be set_ for all appropriate PMDs > in `rte_eth_dev_info->dev_capa`. > That is not pretty, but it holds the semantics of a capability > correctly, as opposed to making it a requirement to have the device > started before creating flow rules. > +Ori & Dmitry. I think right now the method to check if device supports adding flow rules when stopped is run 'rte_flow_create()' when device is stopped and check return value. Can we do similar in the bonding? I am not clear if there is an error to differentiate flow create is failed because device is stopped (or from some other reason). And other option is, what happens if rule is always created after device started? > [1] https://www.mail-archive.com/dev@dpdk.org/msg214840.html > > Martin Havlik (2): > lib/ethdev: introduce RTE_ETH_DEV_CAPA_FLOW_CREATE_BEFORE_START > net/bonding: require started device for dedicated queues > > drivers/net/bonding/rte_eth_bond_pmd.c | 25 +++++++++++++++++++------ > lib/ethdev/rte_ethdev.h | 2 ++ > 2 files changed, 21 insertions(+), 6 deletions(-) >