From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D729FA034F; Thu, 25 Feb 2021 15:59:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A69551608E1; Thu, 25 Feb 2021 15:59:26 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D372C40692 for ; Thu, 25 Feb 2021 15:59:24 +0100 (CET) IronPort-SDR: xEtd/8xTiLd3h6xyty0+H6F7NKrPnE5735PsAgF2NxhLk6jzOrWN5DbtkadyIh22anhRoPOP3Y OP0EI2EbZsPA== X-IronPort-AV: E=McAfee;i="6000,8403,9905"; a="246968539" X-IronPort-AV: E=Sophos;i="5.81,206,1610438400"; d="scan'208";a="246968539" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2021 06:59:23 -0800 IronPort-SDR: 1eb1QTYLvuOTLZhLdURkxLkpeTnx/S3S/ELCKQ3tv3E6c5AvM/v/bMcmVL3Wlb5vKs0xrhNukr 7gC6CFweLdLA== X-IronPort-AV: E=Sophos;i="5.81,206,1610438400"; d="scan'208";a="404325615" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.17.100]) ([10.252.17.100]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2021 06:59:21 -0800 To: Dmitry Kozlyuk , dev@dpdk.org Cc: Tyler Retzlaff , Mike Wells References: <20210214012013.23165-1-dmitry.kozliuk@gmail.com> <20210214021616.26970-1-dmitry.kozliuk@gmail.com> <20210214021616.26970-5-dmitry.kozliuk@gmail.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <6c5e9d34-abfa-d808-eef0-165315baf3ce@intel.com> Date: Thu, 25 Feb 2021 14:59:18 +0000 MIME-Version: 1.0 In-Reply-To: <20210214021616.26970-5-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 4/6] net/pcap: add libpcap wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: > libpcap headers can expose OS headers. On Windows, system networking > headers are incompatible with DPDK ones, causing multiple name clashes. > API of libpcap itself involves a non-standard u_char type. > > Add a limited set of trivial libpcap wrappers, so that libpcap headers > are not included directly by OS-independent PMD code. Use EAL types and > functions for time instead of POSIX ones. > It is not nice to duplicate the pcap struct and macros and have dpdk versions of them, it may have long term maintanance issues too. What are the clashes in question? If they are macros, can the issue solved after undefining some after including 'pcap.h'? And at the end of the day, shouldn't we need to resolve these clashes globally since we may hit same things with other PMDs or libraries as we enable them. I am for a global solution instead of these changes in pcap, but I guess question is how possible that global solution is.. > Signed-off-by: Dmitry Kozlyuk <...>