DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>,
	Jonas Pfefferle1 <JPF@zurich.ibm.com>
Cc: bruce.richardson@intel.com, chaozhu@linux.vnet.ibm.com, dev@dpdk.org
Subject: Re: [dpdk-dev] Huge mapping secondary process linux
Date: Fri, 27 Oct 2017 17:06:49 +0100	[thread overview]
Message-ID: <6c60c15b-a8c1-d74d-23b3-254fa53e16cf@intel.com> (raw)
In-Reply-To: <8fa16207-f057-d5fc-1942-54719526c837@intel.com>

On 27-Oct-17 4:48 PM, Tan, Jianfeng wrote:
> 
> 
> On 10/27/2017 10:44 PM, Burakov, Anatoly wrote:
>> On 27-Oct-17 3:28 PM, Jonas Pfefferle1 wrote:
>>> "Burakov, Anatoly" <anatoly.burakov@intel.com> wrote on 10/27/2017 
>>> 04:06:44 PM:
>>>
>>>  > From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
>>>  > To: Jonas Pfefferle1 <JPF@zurich.ibm.com>, dev@dpdk.org
>>>  > Cc: chaozhu@linux.vnet.ibm.com, bruce.richardson@intel.com
>>>  > Date: 10/27/2017 04:06 PM
>>>  > Subject: Re: [dpdk-dev] Huge mapping secondary process linux
>>>  ...
>>>  > >
>>>  > hi Jonas,
>>>  >
>>>  > MAP_FIXED is not used because it's dangerous, it unmaps anything 
>>> that is
>>>  > already mapped into that space. We would rather know that we can't 
>>> map
>>>  > something than unwittingly unmap something that was mapped before.
>>>
>>> Ok, I see. Maybe we can add a check to the primary process's memory 
>>> mappings whether the hint has been respected or not? At least warn if 
>>> it hasn't.
>>
>> Hi Jonas,
>>
>> I'm unfamiliar with POWER platform, so i'm afraid you'd have to 
>> explain a bit more what you mean by "hint has been respected" :)
> 
> Actually, I also met this case on x86 once that kernel does not respect 
> the "addr" parameter even that memory region is not occupied. I am not 
> sure if it can be reproduced now, anyway, send here FYI: we run primary 
> on the host, run secondary in a container.
> 
> I'll agree at least we need to check if the final addr is the same of 
> the parameter addr, and warn if it's not.
> 
> Thanks,
> Jianfeng
> 

We could put in a warning saying that the address we got is *lower* than 
the address we expected to get, but i'm not sure throwing a warning 
because our assumption about kernel's behavior was incorrect is worth it.

-- 
Thanks,
Anatoly

      reply	other threads:[~2017-10-27 16:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 12:43 Jonas Pfefferle1
2017-10-27 14:06 ` Burakov, Anatoly
2017-10-27 14:28   ` Jonas Pfefferle1
2017-10-27 14:44     ` Burakov, Anatoly
2017-10-27 14:58       ` Jonas Pfefferle1
2017-10-27 15:16         ` Jonas Pfefferle1
2017-10-27 16:00           ` Burakov, Anatoly
2017-10-27 19:22             ` Jonas Pfefferle1
2017-11-07  8:25               ` Chao Zhu
2017-11-07 10:15                 ` Jonas Pfefferle1
2017-11-09  3:08                   ` Chao Zhu
2017-11-09  9:54                     ` Jonas Pfefferle1
2017-10-27 15:48       ` Tan, Jianfeng
2017-10-27 16:06         ` Burakov, Anatoly [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c60c15b-a8c1-d74d-23b3-254fa53e16cf@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=JPF@zurich.ibm.com \
    --cc=bruce.richardson@intel.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).