From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id B00899B77
 for <dev@dpdk.org>; Fri, 26 May 2017 11:14:02 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga105.fm.intel.com with ESMTP; 26 May 2017 02:14:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,396,1491289200"; d="scan'208";a="91680392"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81])
 ([10.237.220.81])
 by orsmga004.jf.intel.com with ESMTP; 26 May 2017 02:14:00 -0700
To: Pascal Mazon <pascal.mazon@6wind.com>, dev@dpdk.org
References: <398d6c2d628f8239bdf5726236f72990dbbcde3b.1495444748.git.pascal.mazon@6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <6c618cb0-57b0-f39d-5428-9b5c4d19a17d@intel.com>
Date: Fri, 26 May 2017 10:13:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <398d6c2d628f8239bdf5726236f72990dbbcde3b.1495444748.git.pascal.mazon@6wind.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix some flow collision
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 May 2017 09:14:03 -0000

On 5/22/2017 12:19 PM, Pascal Mazon wrote:
> The following two flow rules (testpmd syntax) should not collide:
> flow create 0 priority 1 ingress pattern eth / ipv4 / end actions drop / end
> flow create 0 priority 1 ingress pattern eth / ipv6 / end actions drop / end
> 
> But the eth_type in the associated TC rule was set to either "ip" or "ipv6".
> For TC, they could thus not have the same priority.
> 
> Use ETH_P_ALL only in the TC message to make sure those rules can coexist.
> 
> Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions")
Cc: stable@dpdk.org

> 
> Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>

Applied to dpdk-next-net/master, thanks.