From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B80CA0C45; Fri, 29 Oct 2021 19:22:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0AB740688; Fri, 29 Oct 2021 19:22:56 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 5A64A40395 for ; Fri, 29 Oct 2021 19:22:55 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10152"; a="291545369" X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="291545369" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2021 10:22:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="498990525" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 29 Oct 2021 10:22:46 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 29 Oct 2021 10:22:46 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 29 Oct 2021 10:22:45 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 29 Oct 2021 10:22:45 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 29 Oct 2021 10:22:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TCS5wWTYdnnsaxrWjekWzXLW64ZLz9Aytq5Sw1V74d71VAttLtTnbJ0SCJcabxUmrLnFkz97O9t96pHnkN6mWMpW7x3UlmaZrFzCdsStEpnRyulcIkI4CtKOSkSD891Ag1wC6dfW/cucj+Ul+vtS/QTjmX1kJ4kBILq4dKS7pum8qnD900OUHubyJdvrqRQ6xOkB9B8Mo0Z4BnfhuoOfXSFA4yTu4HlpOr8UzGUvs3hw9N/0G40zRGX1az985TB3ayRVJBcWlANTTtSsElFMfB8UWRC10M0Xgui8kjAHdF7ZkFDm8L0RXAdRcAe3vrWjSO7Um7ZAo8t3u98YZMttiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GxFvWG1UDt1cmbNwlHtXT4WHYcuf1BHQ1uZYdgFlcLQ=; b=l55gNHyIDT8j6ymKsZDTQMPcoU2LZLliI2TWVFNMeTVYMkEhSPtpecxaomdTDRVVIztonkm3o2PfP99JCY/qg425sZLKUyX24eckaEgAZLIeEKKyXgRarB0UV2hF+xkqDEuPgBWp9ojUKhx9BpRnBdw+nCixqaAtmuZLam26qw3Z9VZlx9BrtHvoietJn5IorgG7lAaGQIUfbCnS3Y5YAG5q6udXWZJczxjBUy6EebegdsQuZVX6IhDE3IqotpbS2DJhDhhzx8aMHp4kkO1rNz6v5ZFyeij6shrkbJihOFTSIzRpwzjNIa/xpa+YDKkc8vQBMqwJJKaTlTR96oknbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GxFvWG1UDt1cmbNwlHtXT4WHYcuf1BHQ1uZYdgFlcLQ=; b=VWIAuCe+IOg9G6wzy6aYNUlonr1u6iGKYg1rU1+h0w7bkYlFJCljRKRLkuaA0RycexheH6JP+aMZObmcuUvQ+0al+80LEwviBkke2xN7oOWO/AYeD9ZsZSkFsAzA16vmo4X3jXFs0Zto0mBjTBBmfB7v2bTJ2oqv74Ycr7J9Ckk= Authentication-Results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4901.namprd11.prod.outlook.com (2603:10b6:510:3a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Fri, 29 Oct 2021 17:22:44 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021 17:22:44 +0000 Message-ID: <6c82f2aa-e5dc-fc3d-34d0-a309077cb4cd@intel.com> Date: Fri, 29 Oct 2021 18:22:38 +0100 Content-Language: en-US To: Ajit Khaparde , CC: Kalesh AP , Somnath Kotur References: <20211026051432.83989-1-ajit.khaparde@broadcom.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211026051432.83989-1-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0062.eurprd07.prod.outlook.com (2603:10a6:6:2a::24) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0062.eurprd07.prod.outlook.com (2603:10a6:6:2a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.4 via Frontend Transport; Fri, 29 Oct 2021 17:22:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 405db666-c887-47f1-c731-08d99b00b83b X-MS-TrafficTypeDiagnostic: PH0PR11MB4901: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WkrGjkOgSjcuNlkHY/FDtMizjn3WziCM+lMCA23MOe0Z8VqzUEZ0765ujOQOCjeqV4ZhyFB+FeMm2gINNa8WUbR7Qjyp8H248NpVBMxcMpNfwFgr6RZi1XZnoByCAPrcFYvN9qFzIjgVAzAUMB5tT2pZxgnJ3r3L8jLK1jUuMzZ8+ZDL/b3PfuygTFBNiX+rf7IjAKzXBtQZ1VBgxylumuZB88GRy1joa6X+zsBRby/8kguskXEk2HdwCf7m+Oa/UCMf9UkcUGms6d4x6+fu2NGpobjrDRy9KhF/T56OtErMr/9r4DwbOnaQJ2u67DeZ/FvJPfKlf+1hD31/O5gAHQud7rSVAKsryoBq81f2bbtfEBrHw1bcckHhC3Gz1veUizc7zUNu5bHCwQiMMexeshcqdgR8cEztyETm13z6kQhF8fvgO8tMRmH4jEKAI7qHyYM+XfmI+pxTsxNTFne2sPNjLEZtw3rMb+YYdzdI03AnbJeE0b12xpOcOQ49WwPRmpaEaLz0IiTc/v436LtwRh+X3V7zyAYQYvErsh7w197GOHkrZOxtVqkhI9qx/TxAyJLFo2cMlj3EokAyp2TSKCAgePTIJ4VKE4xmp1Mkz97Usw75ELfWEKv9pqn5GLSBWdxdX8EEgnMo7J42VFxYj0oZK+OS0YYlaNx9zR37qo9ytTwG/mpwUYxuUvwlwtz2nG3b2jCFBg15flX0uk31Mw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(53546011)(956004)(5660300002)(36756003)(2616005)(8676002)(316002)(6486002)(86362001)(16576012)(4326008)(38100700002)(54906003)(508600001)(6666004)(31696002)(31686004)(26005)(66476007)(44832011)(2906002)(83380400001)(82960400001)(8936002)(186003)(66556008)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTJWM0huOERjK3FDQVkxallvMEVqVG1QQ2dFNE5ielpPaHhVN0t3KzN4aDFq?= =?utf-8?B?elMrcDlWa2wreklXQVRzNm1jZVBnVStPRlhGbGExSXRqc0w1Rnh4WEJaM24v?= =?utf-8?B?LzhNaFBDb2FPQWcxTmhROVhpN2JGN0cycGhicFNLQzcwcUZLb2hRamQ2REVQ?= =?utf-8?B?S3BMQmRwMWw5WDVjUFBKa0lXSERjTVliRWsxdm51SThDTTZLWVkzZTYwV0Q5?= =?utf-8?B?VGx0cVY1V3cxajNtRnpIdXhXRWpRRzV1SWRjSWdnQ1c4SlJadHFXQ3lpeXhL?= =?utf-8?B?YUxKc21VSXpqMlQ0d3J4K2xON094V0hTNWd3YmRIMm1ZZGNqZndXL2Uram45?= =?utf-8?B?d25TYmRldWNYR0FTcUJJUnNnd0xPNXhiQlJhWHFISll6ckZ6WEJsVzNuNXgx?= =?utf-8?B?MlI1THZkbEpqbkZOd0ExQnRMWm9YNDN2VVRMTXNEdzJ0d1FORFcxYS8vQzF6?= =?utf-8?B?dnNneU40VUNZMk9Kem8yYUNkR29RMlR4NGZHV2xETVNLWHVYWm43d1ppdnFU?= =?utf-8?B?eG1iQ3dlcEFWOXQyRFVoblI4MlRXN3NyVDlEUDJ1RURiYThzeW9FbHdyQTRq?= =?utf-8?B?TlkyS1N1MW9mU1QrcERGU1RvZHJzLzh6YkhOTHEvZU8wWElHbHpDenlBamJ6?= =?utf-8?B?dm1kbFBuc2RYWnJObVFIcjh4Ylo1ZjhjT2VZTTZOYzREMXMxRWNoOWJOeEtT?= =?utf-8?B?Y3NJUGd5QVRrUDMwRWk5QURZZ25BVC9BWWRHbnNYTDVxck1Ba2JJb05lc3F5?= =?utf-8?B?d1BvblZOZG5ReWNMd1NlRlRHQjRKRUtzRWxpcy80ckJDbGttSDZ6K082c0l0?= =?utf-8?B?TjhRWXVPQzhwMWpUNFFveXdWL0xJOU5QYW42ZjRlTmdQeFBBY3lyZWNtZlJi?= =?utf-8?B?SlVqNWJmL0dweHJYQ3N1bkRSVFFPRXMxeFBkK0dESkxXL2g2SVYxNGdRL0lE?= =?utf-8?B?alpnRWVMUG1RSEJzYUJmV2xWVTFHMVNWWUoweXZpbmEzK09mbklFMFVaQVlI?= =?utf-8?B?dmpNQ01iaTdHekNYMjlDc0RSNEJLbUl3M2pOaVB5aUhvL2lSTHdhZnZsNDV3?= =?utf-8?B?cUZyUUhwTGZtUGNicFNCSDhRajFKS2tRVnl2QUF3TXQyN1paRmxla0J3QnNk?= =?utf-8?B?THNGNEtVaC9KdVd0VEVXT1RNMHhUL1hyZTNjSFd3azdJNHYvanA0SHhqalAr?= =?utf-8?B?TkU4QlNzYkt2TUFqcDBxRWZZaVd1cGE2VDFoL25zWlQ2Wlp0ODR1alJsejdM?= =?utf-8?B?SzkwdmdweUVzNlJsQUNURVFnRDNDejBhcGJqNnpSM05pdlVKUTUyaVFJbnZR?= =?utf-8?B?dWowYlhuTHR1cVF2YUo5cTViWkJFTU9PYUNqZ1BiS09GNlhKT1BsQVkxb0Nv?= =?utf-8?B?Q1VwbExLTU1FS0dnZ0orWWpVckt1Ry9LNUl5NWtnck15MzlNekEwL1NPNlpZ?= =?utf-8?B?THcvTFF4Yjg1cHFVQWt6eHFqREZrRGFMK0ZnUmpZN09BRFpmRlJUTlhnZHFQ?= =?utf-8?B?UjR0Slo1b2RraEFneEtEWUFEejZ2N3M5YWJSWXpyRW9XMGljbW1tOGw2b1ZB?= =?utf-8?B?bm1aSUNlbElFU3NMWkFIQTBRbk91OFQzaExkMDZueDFQamlpNmZJb2RZNGtV?= =?utf-8?B?L1pMVE9YcVdKM3Z5VTJRTU9Uc3M3cjI1MGR5VExDZUwreWRSeU5iZHNlT3RJ?= =?utf-8?B?Ti8zOEd5TVdVNzIyMDJjTml6SHlJUlhDL3JlTzRSb2M2d0U0Z2dXUVlzUyt1?= =?utf-8?B?eUdJdng5SmI2TnloYjl4QVBaajM5YjkyME1uemVQMlJyenBFWkpXc204R1hw?= =?utf-8?B?K3dYL2Iwc3dSZ093S3AwOWJxZWtZNFVRR1VaNU9XRkgyL1pSU0gzdWIrUm1E?= =?utf-8?B?cUk5QTNXTU44MGZlL1ZyL2F1RzBoWEJUOE5IbjFBTTdMVnIvYlZYQ0YvY2kr?= =?utf-8?B?UXRHOEJKS2NrMlVZSTdVdTVuN2JsT01tMWplZUVoRW56NTluOVB2YzJMbDBX?= =?utf-8?B?bFlCRkRNQWU2aEh2Vm1GbHJKd081ZUg4blpudFVuQzlWelI3cTIvUHczampl?= =?utf-8?B?dFU1QWV2WnFZUmJrMUlqRzFNQitBdW1Ta2ZQd0NwdEttck5zdjhNbW1vMDFl?= =?utf-8?B?dkJ6M3pseXlCelJPTDZyNVJMY2s4dVpPaTJ4dGx3Mmwxazlua0R0cmF1aWox?= =?utf-8?Q?cnyBmtSa/UU9mRyclMXJDz0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 405db666-c887-47f1-c731-08d99b00b83b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 17:22:44.5923 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oWNY4AwmWpeA4qJCYKM5bzpgC6O7nYs95W/onoTcCUoFL/HyrZdDnni3OUgZSjSP7VlfNyLGW01oy7tY0LaaFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4901 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS action parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/2021 6:14 AM, Ajit Khaparde wrote: > Minor fixes are needed in the RTE_FLOW RSS action parser. > 1. Update the comment in the parser to indicate rss level 1 implies > RSS on outer header. > 2. RSS action will not be supported if level is > 1. > 3. RSS action will not be supported if user or application specifies > MARK or COUNT action. > 4. If RSS types is not specified i.e., is 0, the best effort RSS should > use IPV4 and IPV6 headers. Currently we are considering only IPV4. > > Fixes: fe0bab7eb34e ("net/bnxt: enhance support for RSS action") > > Signed-off-by: Ajit Khaparde > Acked-by: Kalesh AP > Acked-by: Somnath Kotur <...> > @@ -1177,7 +1172,7 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp, > } > > /* If RSS types is 0, use a best effort configuration */ > - types = rss->types ? rss->types : RTE_ETH_RSS_IPV4; > + types = rss->types ? rss->types : ETH_RSS_IPV4 | ETH_RSS_IPV6; We should keep the RTE_ prefix, updating in the next-net.