From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com,
Peng Zhang <peng.zhang@corigine.com>,
Long Wu <long.wu@corigine.com>
Subject: Re: [PATCH 1/3] net/nfp: add the elf module
Date: Fri, 1 Mar 2024 17:22:46 +0000 [thread overview]
Message-ID: <6c833fe5-0a9f-4612-af3a-d505834737c8@amd.com> (raw)
In-Reply-To: <20240228141851.4122231f@hermes.local>
On 2/28/2024 10:18 PM, Stephen Hemminger wrote:
> On Tue, 27 Feb 2024 19:15:49 +0800
> Chaoyong He <chaoyong.he@corigine.com> wrote:
>
>> From: Peng Zhang <peng.zhang@corigine.com>
>>
>> Add the elf module, which can get mip information from the
>> firmware ELF file.
>>
>> Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
>> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
>> Reviewed-by: Long Wu <long.wu@corigine.com>
>> ---
>
> Why are you rolling your own ELF parser?
> There are libraries to do this such as libelf.
> Libelf is already used in the BPF part of DPDK.
>
There cons and pros to depend external library, as this is in the
limited scope of the driver I am less concerned about local code.
Chaoyong, what is your take on the issue, did you consider using libelf
library option?
next prev parent reply other threads:[~2024-03-01 17:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 11:15 [PATCH 0/3] reload the firmware as needed Chaoyong He
2024-02-27 11:15 ` [PATCH 1/3] net/nfp: add the elf module Chaoyong He
2024-02-28 16:50 ` Ferruh Yigit
2024-03-01 2:38 ` Chaoyong He
2024-02-28 22:18 ` Stephen Hemminger
2024-03-01 17:22 ` Ferruh Yigit [this message]
2024-03-04 1:13 ` Chaoyong He
2024-03-04 8:50 ` Ferruh Yigit
2024-02-27 11:15 ` [PATCH 2/3] net/nfp: reload the firmware only when firmware changed Chaoyong He
2024-02-27 11:15 ` [PATCH 3/3] net/nfp: add force reload firmware option Chaoyong He
2024-02-28 16:53 ` Ferruh Yigit
2024-03-01 2:06 ` Chaoyong He
2024-03-01 8:42 ` [PATCH v2 0/3] reload the firmware as needed Chaoyong He
2024-03-01 8:42 ` [PATCH v2 1/3] net/nfp: add the elf module Chaoyong He
2024-03-01 8:42 ` [PATCH v2 2/3] net/nfp: reload the firmware only when firmware changed Chaoyong He
2024-03-01 8:42 ` [PATCH v2 3/3] net/nfp: add force reload firmware option Chaoyong He
2024-03-04 13:28 ` [PATCH v2 0/3] reload the firmware as needed Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c833fe5-0a9f-4612-af3a-d505834737c8@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).