From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7D6243C12; Fri, 1 Mar 2024 18:25:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 326E643376; Fri, 1 Mar 2024 18:22:56 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2067.outbound.protection.outlook.com [40.107.220.67]) by mails.dpdk.org (Postfix) with ESMTP id F300143376 for ; Fri, 1 Mar 2024 18:22:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kM6zUuILukipsXtdsn71m+gLNaXzYrz7ERpU8UiWfK+eS+BVLBrl+4zd3iTwSdPtm0VU5gSaShUJ4bb92/x+XJJOuyFoqoe13aFKK1tmtWnNur0g1a0Y1D9r7K32AVxyTUg3aft78V7uHF/3eZ2alW/S83pf7laHquvVpLQR2PSDL3JEYUPMEgu5OILdqWep9lWJn7RbD9xV22WQHgSMfROnEi064WlZw0hM5/s9nCdu0boq2wd2ScVjf8bqZRqnfcukwN91B5KKv/AdH5oOqs+09idmvvgX/dVsPdx+LOZHemlbOksVlR6UZrXNgt5N9lUDyMVq1/w4gxy4G6N1bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=77eSacyfew3e44e5hdGTmVDbBd+AFhSY7HRthGBueo8=; b=TmMRYO0TxWGgiAxC/M2G8XQCsOWLqLpxoV1xCGIX3gWFhM9SNK1tJLoAIKLIznw1ncueg3BdkXCmufZhQAVpgCfkVha8tl4uIRnKapCPE95GCEbRmdSRhWa4wmx/7mtUtverFs7amOLywBhOVFEJWXUMcEWXbCeBrEtNprvR0YYxpDCPpI2bLUZNFKheI2/wn2hq6WUjN0PnbXsA8EKebUFxhXdTdQ5HiWJLzVd9mNTHJl907AKzLg3CxF+5BD9wR2cxxGoMUgawCFR+SQXmtbqqfijE4tjs/wChPWoEfH1KXhHyK+7soUZjAeYwNdMq2+LXPRuXxOvE60fA7TwxjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=77eSacyfew3e44e5hdGTmVDbBd+AFhSY7HRthGBueo8=; b=5P33B8hk7uC90WbVmzo3yGwsQdr+EsS5EGPhDDb1tzJJ1/GKuEoqY+AdXjXfcy9/4p1gtKrpW2WGFPkjhHzEC9r/4sEWQdmCNO9Dd+5l6oJhlbL8u5fh6OmsX/Sm91F9WBqmWrYj2w18qTs3POXvfhlDCtq+HJOYKes5Y00QNeI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV8PR12MB9133.namprd12.prod.outlook.com (2603:10b6:408:188::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.32; Fri, 1 Mar 2024 17:22:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.039; Fri, 1 Mar 2024 17:22:52 +0000 Message-ID: <6c833fe5-0a9f-4612-af3a-d505834737c8@amd.com> Date: Fri, 1 Mar 2024 17:22:46 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] net/nfp: add the elf module Content-Language: en-US To: Stephen Hemminger , Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, Peng Zhang , Long Wu References: <20240227111551.3773862-1-chaoyong.he@corigine.com> <20240227111551.3773862-2-chaoyong.he@corigine.com> <20240228141851.4122231f@hermes.local> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240228141851.4122231f@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0313.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:390::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV8PR12MB9133:EE_ X-MS-Office365-Filtering-Correlation-Id: 86cae0e6-c827-45b2-753a-08dc3a1439a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7bd5YuYDkMXo8h0JbWwXT7qJyf9K3FUTIn987LGdXVTOPBq9f3cZ0uoUpc98qQpqfzuua/1vxTEqYy2rVzkqVX60+N1q7MwnaXCBw76Pi623dOvhhPKoQGnaHCyf4TKNyPGNFItm2IJXgEmJDC/5f/C9kWsJQ7IHqKZk6qtzsQRHg3Ttq29wMwnMwtIn7no/vwdhncGyiOuIVCwq/LWy6JAnWk4KThKy9IVoA9DVhsyTM6IPblusAvRcqTPwikQbFKYk1ZVs3pP9x0rkC2qLtPTKNoPYofpjiCSwl+rFPjtnd8aViC3+rz/R4Pi30CNLMLGxXTgab0ANLI2TjWFktZ2UWhNymu1wtr4crj5IbmOyZZZNYlcvlgHbkiGWsZYju6lDLO4tVEW94eVYzqS5+5G2u+xdlSZAlBKckYl/PmPJDVQKEbhUFg8tXqG2prKsbjl7DhoectMKYSSao7UYx8T6yEz9dFB9CzdSiuuGnlf8jheh482d9Me1VZ7KPvGQymZ+7y4UEHHiLHN5jp3B42z6H4eme+PMcoW4mbAKwg4wfzBje5u22itKEimHYcsYsmRAv450klfnLb3Rr+Bue14JhjDx1VTEd6FzCYi1YkKyAMNfS+oD5+FLL8WLeEzZasoYiQn5uhPHf/gQjKDOPw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDhxemUvSC9hOThUNVhSQ0FIQzlvaDNRY0F5d1BSaWFTMzZmdXphM2lnVXNV?= =?utf-8?B?ajhEcU93M2NKT2M2NkExYnFDSEV3elo2aE5QMWtEemJWVmN6dTFmL1d5a2hB?= =?utf-8?B?UGlnRmg4THZ6TGFDcTlWSVJvY0tHcW9Yb1dVVGMvQVNQdFVTYitzWERXaVhr?= =?utf-8?B?cU5RNUdHTWlxV1h5NlZhYUJiV2xUSVhWL2EyT3BaZC9zaXNveU1jclRkb2pS?= =?utf-8?B?dlpudUFCZ0xSMFJ6anUyMXh4TzlTaVdtS2NDSVBPU0RweU10Y1NPSi9iUmkw?= =?utf-8?B?VlB2bjFydmY0bWRwV1JuMjNSazE1dTZ1MWNaN3BTN1BGbHhESG1rTkpzTERK?= =?utf-8?B?dHFGaHNBdkxMTUhyQ0s5U3RUenljZmNKNWNWWlgyaFh5Si80Qm16QStQOWta?= =?utf-8?B?cXJ1OCtESG1Nd0JFSDEraytnSmc0RFBxQ0wrR1NuQ2NOQXBLcDRuMVFhdkpp?= =?utf-8?B?Yk92d2pOZFZOQlBodDJTZnFwbjRwaEd0bS9YUmhkWVhDZ2Q0U1Y3dC9pZWl4?= =?utf-8?B?cUdmTzZGRDdPQkNxaUR5aVdZclUvVDRNUlZkZ2NWUUFuRkV4VmZQaHlvVVdX?= =?utf-8?B?ZFFXdWJZWlR3RlRHSXdES25SQ3dZSFRVNFcrdlVLb1RLMk1sMmhFWklIZGwr?= =?utf-8?B?Y0QrZ0tYeVhLaFB3bWdWZ1BwVDd0cjdvUTZ4U0FBSXhBaU9DbVRhWk8zdmhh?= =?utf-8?B?VllCY25UUnZXV0dMUUZuNEU3YnllV3lad1RFdzFnbkNOU1RDWTVPVDlIeEJS?= =?utf-8?B?T3lXNlZ3WUU5M09UbExBak9DYXc2S3VMTkFvY0MyZTN0Tm1vODFJc1ZteWh4?= =?utf-8?B?VkRoNDN2MDFMKytzNzZBM1A3c1NWMFUrWU16djR3SXBNUGErajlaYXY0MmVC?= =?utf-8?B?dERGTUVwVEIxM2tpdW9HRWtWNGpqbm1mNnJBbjNUbGRRdFc1R1Y3R25lSHhQ?= =?utf-8?B?b2dNWjhmSHhlYU5NQnprZ2ZWQTZFSkNHVi92WG5FZTZqc1IyU1R1anI4OTY2?= =?utf-8?B?WW5TNkFyZ21zU1FyeS9od3NtdUZ4SHQ1RFRKNWo1S1VEczEyZXd1RWFKNEVp?= =?utf-8?B?b0lnV2tEVXZBSGl0QklMd0VFT3NTVHh3U1NoVXNBVEw1bVgvajBtK29pdVhO?= =?utf-8?B?VmYzaHQ5dVZLVVE4WnkxUmJBWllFZWdRdVI5OEVkRlB1OTlXbUd2K0pRbTFR?= =?utf-8?B?WUsvUTlUeE1wVXcvSHN0K0wvOUo2K3JwU3JUNkJ0Ukt0YXRDNmRYRHV1UU92?= =?utf-8?B?VGlMYmJma1BlQUNCTmpHNXJHallrZnBUa0VZNG9ka0ptQ0RXb3Y4TklNaGRV?= =?utf-8?B?UUE3Rmw2OFZqcVdIeTdpNkdUNnhxWHFVaEQ5dVh3c0NCdjg3Z1lzZUlkcWly?= =?utf-8?B?ZGVxVEcycElrc01zVEdUd0dqRm1qZndNUVZOeVdjYmVPVFdrVU5nSnNSSXBS?= =?utf-8?B?R2h3U0tHb3dmQzhnY2d6aGRMMnNkQ05zR0UyU2toRGlyZTdvSFM4M1E5Qk5M?= =?utf-8?B?M1NYVlplakY1KzFHTFRUbnJROXRiYjRQMm5iR283OGl2SHU3WS9DQW5zZUsr?= =?utf-8?B?UDN5UGFrZGFwL1ZlSlRZUnVIN3FuVXlRSUFCVTUyNmF0WU5PbjFRL0xXV0dC?= =?utf-8?B?QURNdlBZaUxEZTBUWkhOOXlPUXc0S1lqc2ZzcURScVUvUHRwMG5iNWxhZ29P?= =?utf-8?B?TmNPTEs4d3VsdkZXRXpvU0liK0prd2MwdVJ2Njk1MFAweE8zZjBXeHRYcnZp?= =?utf-8?B?blV5T2JzTEgwNnZVSXh0N0hNcDc0dEp1Z3FWRktkU3lMZWw2OFp3eEJacDlR?= =?utf-8?B?djIvYytGVi9zZmJDVDhMK2RtV3BHdUtvand2cXZjcW9FRThOeUdGOEhrQ0x0?= =?utf-8?B?UW9KWjRGZ2tXbmhzWDk4SDFrSzE1Si82dTFWbUU3cjFiMlFUMUhUUXVWdTRi?= =?utf-8?B?bFJoajdCc3Q4Myt6bk03aVFYQThkSlIvSUJFU1FYVVljSmpNVjd2cEx2NkVD?= =?utf-8?B?bkhocHdUMzA5RzZDTDd5SXB2WGQ4SVBSTDUwb0NnaElLak1SMndoZk5SVjdu?= =?utf-8?B?RlQxNHk2dmZTdVFjQW5xQ3A3QzdJYkdIMTcwQUZ5TWRURUprd1JVWURRem4x?= =?utf-8?Q?aZ+ZwiKePXH2/KCKE3HJ31wLs?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86cae0e6-c827-45b2-753a-08dc3a1439a9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 17:22:52.3004 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SELuSH9Syx0ZJZSnVbGSj3OO4HiYbTZMLDF6pV9XTrcDc8+l4Gti8y6PUFmHkhiS X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9133 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/28/2024 10:18 PM, Stephen Hemminger wrote: > On Tue, 27 Feb 2024 19:15:49 +0800 > Chaoyong He wrote: > >> From: Peng Zhang >> >> Add the elf module, which can get mip information from the >> firmware ELF file. >> >> Signed-off-by: Peng Zhang >> Reviewed-by: Chaoyong He >> Reviewed-by: Long Wu >> --- > > Why are you rolling your own ELF parser? > There are libraries to do this such as libelf. > Libelf is already used in the BPF part of DPDK. > There cons and pros to depend external library, as this is in the limited scope of the driver I am less concerned about local code. Chaoyong, what is your take on the issue, did you consider using libelf library option?