From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C2BBA0C3F; Wed, 28 Apr 2021 03:16:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C990240147; Wed, 28 Apr 2021 03:16:00 +0200 (CEST) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 3F14140041 for ; Wed, 28 Apr 2021 03:15:59 +0200 (CEST) Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FVLHD32RFzBt5V for ; Wed, 28 Apr 2021 09:13:28 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Wed, 28 Apr 2021 09:15:56 +0800 To: "Wang, Haiyue" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Guo, Jia" References: <1619513481-15370-1-git-send-email-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: <6cc502b9-2ad2-4024-8961-9ca123864c0f@huawei.com> Date: Wed, 28 Apr 2021 09:15:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/4/27 21:22, Wang, Haiyue дµÀ: >> -----Original Message----- >> From: Min Hu (Connor) >> Sent: Tuesday, April 27, 2021 16:51 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Guo, Jia ; Wang, Haiyue >> >> Subject: [PATCH] net/e1000: fix param misusage when set rte flow error >> >> This patch fixes parameter misusage when set rte flow action error. >> >> Fixes: c0688ef1eded ("net/igb: parse flow API n-tuple filter") >> Cc: stable@dpdk.org >> >> Signed-off-by: Min Hu (Connor) >> --- >> drivers/net/e1000/igb_flow.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Acked-by: Haiyue Wang > > >> diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c >> index 33f6b1d..e72376f 100644 >> --- a/drivers/net/e1000/igb_flow.c >> +++ b/drivers/net/e1000/igb_flow.c >> @@ -350,7 +350,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, >> memset(filter, 0, sizeof(struct rte_eth_ntuple_filter)); >> rte_flow_error_set(error, EINVAL, >> RTE_FLOW_ERROR_TYPE_ACTION, >> - item, "Not supported action."); >> + act, "Not supported action."); > > Thanks, Connor. > > Just wonder how do you get this error ? With some code scan tool ? ;-) > No, I just read your code to help me understand flow table. I found this part of codes are the same as others. So I think this mistake derived from other drivers. >> return -rte_errno; >> } >> filter->queue = >> -- >> 2.7.4 > > . >