Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

[Andrew Rybchenko <arybchenko@solarflare.com>]

On 04/03/2018 03:41 PM, Olivier Matz wrote:
> Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a
> return code is added to notify the caller (librte_ether) if an error
> occurred in the PMD.
>
> The new default MAC address is now copied in dev->data->mac_addrs[0]
> only if the operation is successful.
>
> The patch also updates all the PMDs accordingly.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> ---
>
> v2:
> * add same change for net/cxgbe
> * mrvl was renamed as mvpp2
> * mvpp2: return success if no ppio as suggested by Tomasz
> * mlx5: update comment as suggested by Adrien
> * sfc: replace by Ivan's patch
>
>   doc/guides/rel_notes/deprecation.rst    |  8 --------
>   drivers/net/ark/ark_ethdev.c            |  9 ++++++---
>   drivers/net/avf/avf_ethdev.c            | 12 +++++++----
>   drivers/net/bnxt/bnxt_ethdev.c          | 10 ++++++----
>   drivers/net/bonding/rte_eth_bond_pmd.c  |  8 ++++++--
>   drivers/net/cxgbe/cxgbe_ethdev.c        |  5 +++--
>   drivers/net/cxgbe/cxgbe_pfvf.h          |  2 +-
>   drivers/net/dpaa/dpaa_ethdev.c          |  4 +++-
>   drivers/net/dpaa2/dpaa2_ethdev.c        |  6 ++++--
>   drivers/net/e1000/igb_ethdev.c          | 12 ++++++-----
>   drivers/net/failsafe/failsafe_ops.c     | 17 +++++++++++++---
>   drivers/net/i40e/i40e_ethdev.c          | 24 +++++++++++++---------
>   drivers/net/i40e/i40e_ethdev_vf.c       | 12 ++++++-----
>   drivers/net/ixgbe/ixgbe_ethdev.c        | 13 +++++++-----
>   drivers/net/mlx4/mlx4.h                 |  2 +-
>   drivers/net/mlx4/mlx4_ethdev.c          |  7 +++++--
>   drivers/net/mlx5/mlx5.h                 |  2 +-
>   drivers/net/mlx5/mlx5_mac.c             |  7 ++++++-
>   drivers/net/mvpp2/mrvl_ethdev.c         | 15 ++++++++++----
>   drivers/net/null/rte_eth_null.c         |  3 ++-
>   drivers/net/octeontx/octeontx_ethdev.c  |  4 +++-
>   drivers/net/qede/qede_ethdev.c          |  7 +++----
>   drivers/net/sfc/sfc_ethdev.c            | 35 ++++++++++++++++++++++-----------
>   drivers/net/szedata2/rte_eth_szedata2.c |  3 ++-
>   drivers/net/tap/rte_eth_tap.c           | 34 +++++++++++++++++++++-----------
>   drivers/net/virtio/virtio_ethdev.c      | 15 +++++++++-----
>   drivers/net/vmxnet3/vmxnet3_ethdev.c    |  5 +++--
>   lib/librte_ether/rte_ethdev.c           |  7 +++++--
>   lib/librte_ether/rte_ethdev_core.h      |  2 +-
>   test/test/virtual_pmd.c                 |  3 ++-
>   30 files changed, 188 insertions(+), 105 deletions(-)

sfc part
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>