From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 79DCA3777 for ; Fri, 28 Apr 2017 11:34:31 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 02:34:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="79991939" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.172.161]) ([10.252.172.161]) by orsmga002.jf.intel.com with ESMTP; 28 Apr 2017 02:34:25 -0700 To: Bruce Richardson , Thomas Monjalon Cc: Qi Zhang , dev@dpdk.org, jingjing.wu@intel.com, helin.zhang@intel.com, wenzhuo.lu@intel.com, jing.d.chen@intel.com References: <20170424145848.18544-1-qi.z.zhang@intel.com> <20170427070107.65465-1-qi.z.zhang@intel.com> <20170427092539.GA7544@bricha3-MOBL3.ger.corp.intel.com> <1655942.nOeDIEQQQZ@xps> <20170428092617.GA14648@bricha3-MOBL3.ger.corp.intel.com> From: Ferruh Yigit Message-ID: <6cda12cf-1f3f-d53f-aed2-110cbe9c7016@intel.com> Date: Fri, 28 Apr 2017 10:34:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170428092617.GA14648@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/3 v2] disable vector PMD for i686 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 09:34:32 -0000 On 4/28/2017 10:26 AM, Bruce Richardson wrote: > On Fri, Apr 28, 2017 at 11:14:24AM +0200, Thomas Monjalon wrote: >> 27/04/2017 11:25, Bruce Richardson: >>> On Thu, Apr 27, 2017 at 03:01:04AM -0400, Qi Zhang wrote: >>>> Vector PMD is not designed for i686 orginally, but it still can be active >>>> with i686 compile option. >>>> Below are observed failure when vPMD is invovled on i686 >>>> (but may not limited to) >>>> >>>> 1) memory overwrite when assign 2 mbuf points to rx return points. >>>> _mm_storeu_si128((__m128i *)&rx_pkts[pos+2], mbp2) >>> >>> Is this a serious issue that prevents us using the driver? I think it's been >>> in the code for quite some time. Can it not be relatively easily fixed for >>> 32-bit builds? >>> >>>> >>>> 2) rearm_data is not 16 bytes aligned that cause general-protection exception >>>> _mm_store_si128((__m128i *)&rx_pkts[0]->rearm_data, rearm0); >>>> >>> >>> Good catch. I think this is also an easy fix. My preferred fix is to >>> explicitly align the rearm data on a 16-byte boundary. It would add some >>> padding to the middle of cacheline0 of the mbuf, but given that we >>> explicitly move other data to cacheline1, we will have padding on 32-bit >>> anyway, be it in the middle or the end of the mbuf cachelines. >>> >>>> So the patch set will exclude Vector PMD from compile with i686 configure. >> >> Please try to fix the drivers instead of turning them off. > > The patch for alignment of physical addresses should fix these issues, > removing the need for these patches. Patches marked as rejected, Thanks for the fix Bruce! > > /Bruce >