From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 89A255B2C for ; Tue, 2 Oct 2018 15:43:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 06:43:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,332,1534834800"; d="scan'208";a="267805194" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by fmsmga005.fm.intel.com with ESMTP; 02 Oct 2018 06:43:19 -0700 To: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= , Jerin Jacob Cc: Bruce Richardson , dev@dpdk.org References: <20180918124514.10615-1-mattias.ronnblom@ericsson.com> <20180918124514.10615-2-mattias.ronnblom@ericsson.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <6ce09f6f-df2e-25f9-70ac-168484b1080e@intel.com> Date: Tue, 2 Oct 2018 14:43:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180918124514.10615-2-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 01/10] event/dsw: add DSW device registration and build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 13:43:22 -0000 On 9/18/2018 1:45 PM, Mattias Rönnblom wrote: > This patch contains the Meson and GNU Make build system extensions > required for the Distributed Event Device, and also the initialization > code for the driver itself. > > Signed-off-by: Mattias Rönnblom <...> > @@ -0,0 +1,26 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2018 Ericsson AB > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +LIB = librte_pmd_dsw_event.a > + > +CFLAGS += -DALLOW_EXPERIMENTAL_API > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > +CFLAGS += -Wno-format-nonliteral This is causing build warning with icc [1], can you please add the flag conditionally as done in other samples of this flag [2]. Since this patch has already merged, can you please send an incremental fix patch? [1] icc: command line warning #10148: option '-Wno-format-nonliteral' not supported [2] https://git.dpdk.org/dpdk/tree/drivers/net/qede/Makefile?h=v18.08#n40 https://git.dpdk.org/dpdk/tree/drivers/net/i40e/Makefile?h=v18.08#n38