From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 99718A0C55;
	Wed, 13 Oct 2021 18:35:27 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8619A40E64;
	Wed, 13 Oct 2021 18:35:27 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 7CE3240151
 for <dev@dpdk.org>; Wed, 13 Oct 2021 18:35:26 +0200 (CEST)
Received: from [192.168.1.192] (unknown [188.242.181.57])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E97D27F530;
 Wed, 13 Oct 2021 19:35:25 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E97D27F530
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634142926;
 bh=644b2zT7THY03SydwFqyN7t5eoBOq3fh91s/pVPYo6o=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=eZ+gp4hUz95vfLbgUsF9AnG37sqpdX4WCo8crkyAH1nvuSMK4K99zplZBhS+qV2An
 TX2CRJi49h0gUD9eLfr8XEI0Uw6crCaHlPA9nw+ZPzLH76p3i/RdbEEjnlkdGHCNLd
 dgU6SJ+p3EE4Ho+CGlTvliD22lRKelRI8ArHyP9Y=
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Igor Romanov <igor.romanov@oktetlabs.ru>, Andy Moreton
 <amoreton@xilinx.com>, Ivan Malov <ivan.malov@oktetlabs.ru>
Cc: dev@dpdk.org, Raslan Darawsheh <rasland@nvidia.com>
References: <20211013152027.2480175-1-ferruh.yigit@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <6cfcbf83-5b8c-cb6b-0414-410f473efd96@oktetlabs.ru>
Date: Wed, 13 Oct 2021 19:35:24 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211013152027.2480175-1-ferruh.yigit@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] net/sfc: fix build when assert enabled
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/13/21 6:20 PM, Ferruh Yigit wrote:
> When 'RTE_ENABLE_ASSERT' is enabled (meson -Dc_args=-DRTE_ENABLE_ASSERT)
> build fails:
> ../drivers/net/sfc/sfc_repr.c: In function ‘sfc_repr_start’:
> ../drivers/net/sfc/sfc_repr.c:251:20:
>      warning: implicit declaration of function ‘sfc_repr_lock_is_locked’;
>      did you mean ‘rte_spinlock_is_locked’?
>      [-Wimplicit-function-declaration]
>    251 |         SFC_ASSERT(sfc_repr_lock_is_locked(sr));
>        |                    ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: c85675423f01 ("net/sfc: implement port representor start and stop")
> 
> Reported-by: Raslan Darawsheh <rasland@nvidia.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

I'm sorry for the breakage. I've sent v2 which avoid usage of
conditional compilation in function body. I'd prefer to fix
the problem this way. Yes, it is a bit less straight-forward,
but still preferable.

Andrew.