From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Cc: Kishore Padmanabha <kishore.padmanabha@broadcom.com>,
Michael Baucom <michael.baucom@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix overrun of the ulp device params array
Date: Wed, 6 May 2020 10:17:11 +0100 [thread overview]
Message-ID: <6d0bac2f-7295-3f2a-9100-447ce60e45dc@intel.com> (raw)
In-Reply-To: <20200505191738.58219-2-ajit.khaparde@broadcom.com>
On 5/5/2020 8:17 PM, Ajit Khaparde wrote:
> From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
>
> Fix a buffer overrun issue spotted by coverity while accessing
> the array ulp_device_params.
If it is spotted by coverity, is there a coverity issue id?
>
> Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init")
>
> Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
> Reviewed-by: Michael Baucom <michael.baucom@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> drivers/net/bnxt/tf_ulp/ulp_template_db.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db.c b/drivers/net/bnxt/tf_ulp/ulp_template_db.c
> index 86384169f..e89aefad4 100644
> --- a/drivers/net/bnxt/tf_ulp/ulp_template_db.c
> +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db.c
> @@ -321,7 +321,7 @@ struct bnxt_ulp_def_ident_info ulp_def_ident_tbl[] = {
> }
> };
>
> -struct bnxt_ulp_device_params ulp_device_params[] = {
> +struct bnxt_ulp_device_params ulp_device_params[BNXT_ULP_DEVICE_ID_LAST] = {
> [BNXT_ULP_DEVICE_ID_WH_PLUS] = {
> .global_fid_enable = BNXT_ULP_SYM_YES,
> .byte_order = (enum bnxt_ulp_byte_order)
>
next prev parent reply other threads:[~2020-05-06 9:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 19:17 [dpdk-dev] [PATCH 0/2] fix coverity reported issues Ajit Khaparde
2020-05-05 19:17 ` [dpdk-dev] [PATCH 1/2] net/bnxt: fix overrun of the ulp device params array Ajit Khaparde
2020-05-06 9:17 ` Ferruh Yigit [this message]
2020-05-06 22:14 ` Ajit Khaparde
2020-05-07 0:09 ` Ferruh Yigit
2020-05-07 3:14 ` Ajit Khaparde
2020-05-05 19:17 ` [dpdk-dev] [PATCH 2/2] net/bnxt: fix uninitialized variable error Ajit Khaparde
2020-05-06 9:13 ` Ferruh Yigit
2020-05-07 18:55 ` Ajit Khaparde
2020-05-07 21:15 ` Ferruh Yigit
2020-05-06 1:40 ` [dpdk-dev] [PATCH 0/2] fix coverity reported issues Ajit Khaparde
2020-05-07 3:11 ` [dpdk-dev] [PATCH v2 " Ajit Khaparde
2020-05-07 3:11 ` [dpdk-dev] [PATCH v2 1/2] net/bnxt: fix overrun of the ulp device params array Ajit Khaparde
2020-05-07 3:11 ` [dpdk-dev] [PATCH v2 2/2] net/bnxt: fix uninitialized variable error Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d0bac2f-7295-3f2a-9100-447ce60e45dc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kishore.padmanabha@broadcom.com \
--cc=michael.baucom@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).