From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id CDA72FEB for ; Mon, 29 Oct 2018 15:09:05 +0100 (CET) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181029140904euoutp016a744ce2a5662ebd30cd14446a101dfd~iGZOok9B61158611586euoutp01a for ; Mon, 29 Oct 2018 14:09:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181029140904euoutp016a744ce2a5662ebd30cd14446a101dfd~iGZOok9B61158611586euoutp01a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1540822144; bh=9E5NzJ81ef92lTIRzZ2EEH8CpKwCNcsYPZCiUywmzHs=; h=To:Subject:From:Date:In-Reply-To:References:From; b=Obt3CBuTP2ktztTmXNtIhhlnV920ZrddFcKmybCLeYLhPREDRi/s5sBkccl2OXZnu cxOaXDk+mz9vsqzyKlxbiT3CHQQMsmnGEBxtt3owLSLfVUhk1Q7d7s/MCJ1p0LEFFH VdP5WAtf8KzZm2RVG7xV5ljM25UB2za1SKbARZkc= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181029140904eucas1p11294cb68a7d2f932d0a846fb1363433a~iGZOOG4021464314643eucas1p1-; Mon, 29 Oct 2018 14:09:04 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 22.A8.04806.F7417DB5; Mon, 29 Oct 2018 14:09:03 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181029140903eucas1p1021673ecc6c9d40c31dd21ca52dbb114~iGZNgJyOT0523805238eucas1p1f; Mon, 29 Oct 2018 14:09:03 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181029140903eusmtrp25a960606b4baee35e95fcae6b1428e2c~iGZNQQm452638326383eusmtrp2c; Mon, 29 Oct 2018 14:09:03 +0000 (GMT) X-AuditID: cbfec7f5-34dff700000012c6-01-5bd7147f7c78 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F3.C8.04284.E7417DB5; Mon, 29 Oct 2018 14:09:02 +0000 (GMT) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181029140902eusmtip1f6c1ceb2c23d20e135925c19b5965380~iGZM4Jpc-0326103261eusmtip12; Mon, 29 Oct 2018 14:09:02 +0000 (GMT) To: dev@dpdk.org, Bruce Richardson , Luca Boccassi From: Ilya Maximets Message-ID: <6d16dc9e-c2f5-ba4b-eeb5-a9cdd8ac75bc@samsung.com> Date: Mon, 29 Oct 2018 17:09:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1539364001.8721.45.camel@debian.org> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SXUhTcRjG+e+cnZ0tJ8e58sWEcJhRpFaK7iJcgRermww0IoVaeporN3XH j+wDTfMzUluGNqcp5tckJVm6aYaN0kwaJZHLi+yiG5VNahbzA83TmeTd73nf94Hn+fMnMckj fjCp0eXSep0qU0aI8MHxFUdEkXQm5YhpLEJuKukTyJ1mhdz9a4gn/1yxIjiBK1fLmzHlamsH X9n+cp6nrLGYUSJ+QXQ8nc7U5NP6qPhLoowltwHLNvldH58xCIqRXViNhCRQMdDTOIWqkYiU UN0IqoyLOCeWEcx+fMHjhAdBTVs5tm1xVoz5rroQVCx18jnxE4HDWrYlSFJKpUHfVCqLgdRZ 2HRcYb0EdRje975BLIupeDCMeHks49R+WPHaCZZ3U+ehcq6X4G4CYPLxD5xlIXUMHIaqf16M CoKS5R4+x/tgyGXC2AhA3RPAvPc+nwuaAP3FowTHgbAwYRFwHAKbtic8jotg7u484syVCBrs G76FAiyLDgFbAKMOQv9wFDc+CQPj0zg7BsofnK4ALoM/GAYbMG4shspyCXcdBmuvu3zPFgxf 3R5fAiW8tdcRdSjUuKOlcUcz445mxv8ZWhFuRkF0HqNV00y0ji6IZFRaJk+njkzL0g6grc8y tTHx24perV+2I4pEMj/x911fUiR8VT5TqLUjIDGZVLzwYWskTlcV3qD1WRf1eZk0Y0d7SVwW JO5seZ4iodSqXPoaTWfT+u0tjxQGF6OmOeuM5eFIXM7t2C5XgiFH0SabPnMzgJG2zcKw2i7s aHA7Hng26lusttKWU+HOO1HrZZM4YTMQ0fxzqaHQNHB1ObA77lu7S1z7Kbk5yZqV6H3XExOW v5YYgjnMnmf13Yo+v8baA7YkjW3UfHrPH01BLJFWimT9t8JVT5NlOJOhOnoI0zOqv3xOllgo AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsVy+t/xu7p1ItejDaY9NbeY07SO3eLGKnuL d5+2M1lcaf/J7sDi8attLrPHrwVLWT0W73nJ5NG3ZRVjAEuUnk1RfmlJqkJGfnGJrVK0oYWR nqGlhZ6RiaWeobF5rJWRqZK+nU1Kak5mWWqRvl2CXsb7d5OYC+bwVBy7Pom9gfEQZxcjJ4eE gInEjfYDLF2MXBxCAksZJQ5u6GSFSEhJ/Ph1AcoWlvhzrYsNoug9o8SOQyvZQBIiAskSb+bO YwexhQQMJc63P2LqYuTgEBYIlPh/Lg0kzCagI3Fq9RFGEJtXwE5i0u4fTCA2i4CqxM8fh8DG iApESJx9uQ6qRlDi5MwnLCA2p4CRxLlJnWBxZgF1iT/zLjFD2OISTV9WskLY8hLb385hnsAo OAtJ+ywkLbOQtMxC0rKAkWUVo0hqaXFuem6xoV5xYm5xaV66XnJ+7iZGYMxsO/Zz8w7GSxuD DzEKcDAq8fA+4L4WLcSaWFZcmXuIUYKDWUmE99VZoBBvSmJlVWpRfnxRaU5q8SFGU6DnJjJL iSbnA+M5ryTe0NTQ3MLS0NzY3NjMQkmc97xBZZSQQHpiSWp2ampBahFMHxMHp1QDo8nLmB8e RmI5QpytTWvn3I/mVxX0XnoiekbEzYMPeI33die4+33iLjlxRfRX53epwKeNOaX8XNdm9s71 Kepk+HpU4lrWHblHTCc1JW6f0HjWaLVj3/Ki289WZa2QZ9O4Kvxjx1cBiaPPub9uVe76ZXny zu2MK84vchcZLfrgo3R/4csFaY/jfiixFGckGmoxFxUnAgB6RyvIrwIAAA== X-CMS-MailID: 20181029140903eucas1p1021673ecc6c9d40c31dd21ca52dbb114 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181029140903eucas1p1021673ecc6c9d40c31dd21ca52dbb114 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181029140903eucas1p1021673ecc6c9d40c31dd21ca52dbb114 References: <1539364001.8721.45.camel@debian.org> Subject: Re: [dpdk-dev] [PATCH v2] build: add meson.build for kni kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 14:09:06 -0000 > On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote: >> On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote: >> > A Kbuild is also included to allow users to use DKMS natively >> > without >> > additional code. >> > >> > Signed-off-by: Luca Boccassi >> > --- >> > v2: add local directory to -I and build sources list recursively to >> > fix build on Fedora >> > >> >> Yep, now seems to build for me on Fedora. One minor suggestion is to >> look >> to use the "console" keyword on the custom_target if possible. It >> should >> help prevent noticable stalls as make runs in the background. >> [Unfortunately, it's meson 0.48 onward only, so if conditionals are >> needed, >> just ignore this suggestion] > > Good idea, I just with 0.48, 0.47 and 0.41 and in all cases there are > no complaints or errors, it's simply ignored in the older versions. Hmm. I have following on my Ubuntu 18.04 with dpdk v18.11-rc1: $ meson --version 0.45.1 $ meson build <...> kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument "console". WARNING: This will become a hard error in the future. WARNING: Unknown keyword arguments in target rte_kni: console <...> It builds, but prints above warning. Best regards, Ilya Maximets. > >> Also, do we want to use "make -j" for this, given the number of >> files? >> [Maybe -j4 just?] > > Yeah makes sense, added j4. > > Sent v3 with both changes and the ack, thanks. > > -- > Kind regards, > Luca Boccassi