From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE95DA0C55; Wed, 13 Oct 2021 13:00:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5955E4115A; Wed, 13 Oct 2021 13:00:07 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E5D4040E64; Wed, 13 Oct 2021 13:00:05 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="227685344" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="227685344" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 04:00:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="626307265" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga001.fm.intel.com with ESMTP; 13 Oct 2021 04:00:05 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 04:00:04 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 19:00:02 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Wed, 13 Oct 2021 19:00:02 +0800 From: "Zhang, Qi Z" To: "Yu, DapengX" , "Yang, Qiming" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/ice: fix freeing queues on DCF device reset Thread-Index: AQHXvnE87/WJvrEvfEq2GRwJ923paqvQxYvA Date: Wed, 13 Oct 2021 11:00:02 +0000 Message-ID: <6d30914e186d43d2b6aa3b9e8872c3f0@intel.com> References: <20211011072546.371639-1-dapengx.yu@intel.com> In-Reply-To: <20211011072546.371639-1-dapengx.yu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix freeing queues on DCF device reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yu, DapengX > Sent: Monday, October 11, 2021 3:26 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [PATCH] net/ice: fix freeing queues on DCF device reset >=20 > From: Dapeng Yu >=20 > In function ice_dcf_stop_queues(), RX queues and TX queues are actually n= ot > freed, so their pointers shall not be set to NULL when queues are stopped= . >=20 > This patch adds function call to free queues on DCF device close and rese= t, The patch only add function call in device close but not reset. > which also set the RX and TX queues' pointers to NULL on freeing queues, = and > avoids referring to the released resource when device is started again. >=20 > Fixes: 1a86f4dbdf42 ("net/ice: support DCF device reset") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu Acked-by: Qi Zhang Applied to dpdk-next-net-intel after refined the commit log. Thanks Qi