From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>
Subject: RE: [dpdk-dev] [PATCH v2] doc: update machine meson option in prog guide
Date: Fri, 26 Nov 2021 14:16:30 +0000 [thread overview]
Message-ID: <6d43878b964d4f10b9bddc86442708b7@pantheon.tech> (raw)
In-Reply-To: <2221425.XNKqbgPmLA@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, November 26, 2021 2:41 PM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: david.marchand@redhat.com; bruce.richardson@intel.com; dev@dpdk.org;
> honnappa.nagarahalli@arm.com; Ruifeng Wang <ruifeng.wang@arm.com>
> Subject: Re: [dpdk-dev] [PATCH v2] doc: update machine meson option in prog
> guide
>
> 11/10/2021 15:42, Juraj Linkeš:
> > Update the docs to reflect the two new variables, cpu_instruction_set
> > for non-arm builds and platform for arm builds.
> >
> > Fixes: bf66003b51ec ("build: use platform for generic and native
> > builds")
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > ---
> > --- a/doc/guides/prog_guide/build-sdk-meson.rst
> > +++ b/doc/guides/prog_guide/build-sdk-meson.rst
> > - meson -Dmachine=generic # use builder-independent baseline -march
> > + meson -Dcpu_instruction_set=generic # use builder-independent
> > + # baseline -march
> [...]
> > .. note::
> > - machine=generic uses a config that works on all supported architectures
> > - regardless of the capabilities of the machine where the build is
> happening.
> > + cpu_instruction_set=generic uses an instruction set that works on all
> > + supported architectures regardless of the capabilities of the machine
> > + where the build is happening.
> >
> > +.. note::
> > + cpu_instruction_set is not used in Arm builds, as setting the instruction
> > + set without other parameters leads to inferior builds. The way to tailor
> > + Arm builds is to build for a SoC using -Dplatform=<SoC>.
> > +
> > +]
>
> I assume this last line is a typo.
Yes, the square bracket shouldn't be there.
>
> I would prefer having an Ack from Arm, but it did not happen.
>
> Applied, thanks.
>
>
Thanks.
prev parent reply other threads:[~2021-11-26 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 7:44 [dpdk-dev] [PATCH v1] " Juraj Linkeš
2021-10-11 13:42 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
2021-11-26 13:41 ` Thomas Monjalon
2021-11-26 14:16 ` Juraj Linkeš [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d43878b964d4f10b9bddc86442708b7@pantheon.tech \
--to=juraj.linkes@pantheon.tech \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).