From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5B06D2BB5 for ; Fri, 1 Mar 2019 11:30:44 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2019 02:30:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,427,1544515200"; d="scan'208";a="147625084" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.114]) ([10.237.221.114]) by fmsmga002.fm.intel.com with ESMTP; 01 Mar 2019 02:30:42 -0800 To: Qi Zhang , wenzhuo.lu@intel.com, qiming.yang@intel.com Cc: paul.m.stillwell.jr@intel.com, dev@dpdk.org References: <20190228055650.25237-1-qi.z.zhang@intel.com> <20190228055650.25237-8-qi.z.zhang@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <6d443840-69d1-a2b1-2c7b-9e73c35e76a8@intel.com> Date: Fri, 1 Mar 2019 10:30:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: <20190228055650.25237-8-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 07/37] net/ice/base: declare functions as external X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 10:30:45 -0000 On 2/28/2019 5:56 AM, Qi Zhang wrote: > Remove static of below functions and declare them as external > APIs. > > ice_aq_add_vsi > ice_aq_free_vsi > ice_aq_update_vsi > ice_aq_add_lan_txq > ice_init_pkg Hi Qi, This is generic comment for the patchset but it is easy to demonstrate in this patch, Patch title and comment describes what is done in the code, which is exactly same with what can be seen from the code, so doesn't add more value. What can't be seen from the below code is "why you need this change?" and "what is the impact of the change?". Can you please update the patch title to describe what is achieved by the patch but not implementation details. Also in commit log describe "why it is needed" and "what will be the impact, or impact of not having this change", and of course if the implementation is complex describe the implementation too. And specific to this patch, this is base code update, most probably it is setting ground to enable some features in driver, wouldn't it be better to do these changes when the relevant driver change done? It sets the context for the update and it helps to review the patch. Right now it just exposes some APIs without really knowing who will use them, or will anybody use them at all. > > Signed-off-by: Paul M Stillwell Jr > Signed-off-by: Qi Zhang > --- > drivers/net/ice/base/ice_common.c | 2 +- > drivers/net/ice/base/ice_common.h | 4 ++++ > drivers/net/ice/base/ice_flex_pipe.c | 2 +- > drivers/net/ice/base/ice_flex_pipe.h | 2 ++ > drivers/net/ice/base/ice_switch.c | 6 +++--- > drivers/net/ice/base/ice_switch.h | 9 +++++++++ > 6 files changed, 20 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c > index 86d3be17a..015db11e0 100644 > --- a/drivers/net/ice/base/ice_common.c > +++ b/drivers/net/ice/base/ice_common.c > @@ -2935,7 +2935,7 @@ ice_aq_set_rss_key(struct ice_hw *hw, u16 vsi_handle, > * Association of Tx queue to Doorbell queue is not part of Add LAN Tx queue > * flow. > */ > -static enum ice_status > +enum ice_status > ice_aq_add_lan_txq(struct ice_hw *hw, u8 num_qgrps, > struct ice_aqc_add_tx_qgrp *qg_list, u16 buf_size, > struct ice_sq_cd *cd) > diff --git a/drivers/net/ice/base/ice_common.h b/drivers/net/ice/base/ice_common.h > index 0b387cdbe..63f4a5ebe 100644 > --- a/drivers/net/ice/base/ice_common.h > +++ b/drivers/net/ice/base/ice_common.h > @@ -94,6 +94,10 @@ ice_aq_get_rss_key(struct ice_hw *hw, u16 vsi_handle, > enum ice_status > ice_aq_set_rss_key(struct ice_hw *hw, u16 vsi_handle, > struct ice_aqc_get_set_rss_keys *keys); > +enum ice_status > +ice_aq_add_lan_txq(struct ice_hw *hw, u8 count, > + struct ice_aqc_add_tx_qgrp *qg_list, u16 buf_size, > + struct ice_sq_cd *cd); > > bool ice_check_sq_alive(struct ice_hw *hw, struct ice_ctl_q_info *cq); > enum ice_status ice_aq_q_shutdown(struct ice_hw *hw, bool unloading); > diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c > index 2d23c36eb..ff615f94f 100644 > --- a/drivers/net/ice/base/ice_flex_pipe.c > +++ b/drivers/net/ice/base/ice_flex_pipe.c > @@ -1314,7 +1314,7 @@ static void ice_init_pkg_regs(struct ice_hw *hw) > * ice_copy_and_init_pkg() instead of directly calling ice_init_pkg() in this > * case. > */ > -static enum ice_status ice_init_pkg(struct ice_hw *hw, u8 *buf, u32 len) > +enum ice_status ice_init_pkg(struct ice_hw *hw, u8 *buf, u32 len) > { > struct ice_pkg_hdr *pkg; > enum ice_status status; > diff --git a/drivers/net/ice/base/ice_flex_pipe.h b/drivers/net/ice/base/ice_flex_pipe.h > index 23fffed75..00c2b6682 100644 > --- a/drivers/net/ice/base/ice_flex_pipe.h > +++ b/drivers/net/ice/base/ice_flex_pipe.h > @@ -88,6 +88,8 @@ ice_set_prof_context(struct ice_hw *hw, enum ice_block blk, u64 id, u64 cntxt); > struct ice_prof_map * > ice_get_prof_context(struct ice_hw *hw, enum ice_block blk, u64 id, u64 *cntxt); > enum ice_status > +ice_init_pkg(struct ice_hw *hw, u8 *buff, u32 len); > +enum ice_status > ice_copy_and_init_pkg(struct ice_hw *hw, const u8 *buf, u32 len); > enum ice_status ice_init_hw_tbls(struct ice_hw *hw); > void ice_free_seg(struct ice_hw *hw); > diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c > index 512e64b91..e6fc9fcee 100644 > --- a/drivers/net/ice/base/ice_switch.c > +++ b/drivers/net/ice/base/ice_switch.c > @@ -288,7 +288,7 @@ enum ice_status ice_free_sw(struct ice_hw *hw, u16 sw_id, u16 counter_id) > * > * Add a VSI context to the hardware (0x0210) > */ > -static enum ice_status > +enum ice_status > ice_aq_add_vsi(struct ice_hw *hw, struct ice_vsi_ctx *vsi_ctx, > struct ice_sq_cd *cd) > { > @@ -331,7 +331,7 @@ ice_aq_add_vsi(struct ice_hw *hw, struct ice_vsi_ctx *vsi_ctx, > * > * Free VSI context info from hardware (0x0213) > */ > -static enum ice_status > +enum ice_status > ice_aq_free_vsi(struct ice_hw *hw, struct ice_vsi_ctx *vsi_ctx, > bool keep_vsi_alloc, struct ice_sq_cd *cd) > { > @@ -366,7 +366,7 @@ ice_aq_free_vsi(struct ice_hw *hw, struct ice_vsi_ctx *vsi_ctx, > * > * Update VSI context in the hardware (0x0211) > */ > -static enum ice_status > +enum ice_status > ice_aq_update_vsi(struct ice_hw *hw, struct ice_vsi_ctx *vsi_ctx, > struct ice_sq_cd *cd) > { > diff --git a/drivers/net/ice/base/ice_switch.h b/drivers/net/ice/base/ice_switch.h > index 90dfdabcb..b28e55a4f 100644 > --- a/drivers/net/ice/base/ice_switch.h > +++ b/drivers/net/ice/base/ice_switch.h > @@ -271,6 +271,15 @@ enum ice_promisc_flags { > > /* VSI related commands */ > enum ice_status > +ice_aq_add_vsi(struct ice_hw *hw, struct ice_vsi_ctx *vsi_ctx, > + struct ice_sq_cd *cd); > +enum ice_status > +ice_aq_free_vsi(struct ice_hw *hw, struct ice_vsi_ctx *vsi_ctx, > + bool keep_vsi_alloc, struct ice_sq_cd *cd); > +enum ice_status > +ice_aq_update_vsi(struct ice_hw *hw, struct ice_vsi_ctx *vsi_ctx, > + struct ice_sq_cd *cd); > +enum ice_status > ice_add_vsi(struct ice_hw *hw, u16 vsi_handle, struct ice_vsi_ctx *vsi_ctx, > struct ice_sq_cd *cd); > enum ice_status >