From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 343C7A034F; Tue, 8 Jun 2021 12:18:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B137D4067A; Tue, 8 Jun 2021 12:18:15 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id B34894013F; Tue, 8 Jun 2021 12:18:13 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 249FD7F53D; Tue, 8 Jun 2021 13:18:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 249FD7F53D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1623147493; bh=s1PXFTLEwPZ5uL09cRPRIF1mHB01SILADEvKKMsnCO4=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=bco31Rvs4tB3auUMhNaUxUYmpjULgA/4971LkNkD/xsPiqcJtqJi+iOXfQ0DtdD6X Txw7ODawj2BHen0fdxvH4EosG9mipuSMTaPHDykDEpHkjbglR5c/RAH3sbo4Kxx0/R 1V3huWapfZqx/S44f4otbAog//h1FzQbM6JRiBhI= To: Olivier Matz , dev@dpdk.org Cc: Keith Wiles , Hongzhi Guo , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Thomas Monjalon , stable@dpdk.org References: <20210427135755.927-1-olivier.matz@6wind.com> <20210427135755.927-3-olivier.matz@6wind.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <6d54bb29-2acd-463d-a96b-9bdabd97f347@oktetlabs.ru> Date: Tue, 8 Jun 2021 13:18:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210427135755.927-3-olivier.matz@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/4] net/tap: fix Rx cksum flags on TCP packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/27/21 4:57 PM, Olivier Matz wrote: > Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP > checksum 0"), the functions rte_ipv4_udptcp_cksum() or > rte_ipv6_udptcp_cksum() can return either 0x0000 or 0xffff when used to > verify a packet containing a valid checksum. > > This new behavior broke the checksum verification in tap driver for TCP > packets: these packets are marked with PKT_RX_L4_CKSUM_BAD. > > Fix this by checking the 2 possible values. A next commit will introduce > a checksum verification helper to simplify this a bit. > > Fixes: d5df2ae0428a ("net: fix unneeded replacement of TCP checksum 0") > Cc: stable@dpdk.org > > Signed-off-by: Olivier Matz Acked-by: Andrew Rybchenko