From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 72C30325F for ; Mon, 22 Jan 2018 02:53:57 +0100 (CET) Received: by mail-pg0-f67.google.com with SMTP id y27so5904836pgc.5 for ; Sun, 21 Jan 2018 17:53:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=OJdOZeFNB4Y4fj+WCC9Id7yNceDA2uMmZqUlqBDyvF8=; b=DPWQXB4nR41H0x8ruJb0432qrngNY/t1YIYMpJ4oWUVb6IGcb4Ha/gtp+pxNzS2fOt l3tCUR7s8XPniFAlXDNWRsgWzL3S8g+I1Xh814lqhoR5Uzn4YNIRT+oNU9m5P9kBWELG W23q//eofUFn28QqLuWYnC9X73Cf0hulP/8Z/8YJNiuRNuCYXYJIQJKLQ2o4Q7I9+KAC 8eqCZeYQhxOySsmtjCjZ0Kj8IEvOKrH2xuPWNUxr6UcNU3PMsL6GWhk6HEx8b+CDsyjr D5PNEDPXG9iklrBOBLgFjFBghNHops3uWoyisJadQkZEGuC+wgIU8K4LfPVCa0S8L2J8 0GQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=OJdOZeFNB4Y4fj+WCC9Id7yNceDA2uMmZqUlqBDyvF8=; b=ib4IKc08jhYmHSHGNYBSR4vZkebSR34pW+5tN7/tf4uBFJRdTNKvVS4EL5FvidmReO TbKVBHvsl0CR4SvaXslnt/6uIS62anbB90r3NkHVGhLkW6HxLu7tqIk2oAAtaLjXpvrS Vg1QwUCojKZIrSFPQSpnO9V4ivp1TU7IdHinfOcBQU+wQa4Mgy4zkV/HTVwDUO0/zZ0Q 3CG33w3V3h3QAIGNHDaIRixGVWJevleRpI/GrNDKWa8yoL1oujzUlfLGfEoEtlsgFfLz +94scej8VlgNx7pWMTeMzqunLlEu4n8wRxcYnoU1Pi4yDuCMwFmWshtYcvawDZdu9jPV 1dFA== X-Gm-Message-State: AKwxytfpPkqyIYkHc2vvmWIqwIzsls5mUMTETjrN+frE7XXriHuew2/u uBfCntWHI6KlV7KROVsn4go= X-Google-Smtp-Source: AH8x224rS8FrjV7zXj9jpCMdWowodnCmbOR9TmNhwJeekrpvZMG8PRmktUiZ7igTTMWiy9fio5874g== X-Received: by 10.99.126.26 with SMTP id z26mr5772585pgc.151.1516586036692; Sun, 21 Jan 2018 17:53:56 -0800 (PST) Received: from [0.0.0.0] (67.209.179.165.16clouds.com. [67.209.179.165]) by smtp.gmail.com with ESMTPSA id m22sm28215195pfg.120.2018.01.21.17.53.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Jan 2018 17:53:56 -0800 (PST) To: Hemant Agrawal , Olivier Matz Cc: "dev@dpdk.org" , Thomas Monjalon , Jerin Jacob , Jianbo Liu , Jan Viktorin , "konstantin.ananyev@intel.com" , Jia He , kmacy@freebsd.org References: <1516161831-28719-1-git-send-email-hejianet@gmail.com> <1516161831-28719-3-git-send-email-hejianet@gmail.com> <20180119163820.lk6mi6mjxaomb5nq@platinum> From: Jia He Message-ID: <6d596a3b-c3c7-5dea-2786-0275d36af4da@gmail.com> Date: Mon, 22 Jan 2018 09:53:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 01:53:57 -0000 Hi Hermant On 1/20/2018 12:47 AM, Hemant Agrawal Wrote: > Hi Olivier, > >> On Fri, Jan 19, 2018 at 07:45:30PM +0530, Hemant Agrawal wrote: >>> Hi Jia, >>> >>> On 1/17/2018 9:33 AM, Jia He wrote: >>>> Move the common part of rte_ring.h into rte_ring_generic.h. >>>> Move the memory barrier part into update_tail(). >>>> >>>> No functional changes here. >>>> >>>> Signed-off-by: Jia He >>>> Suggested-by: Jerin Jacob >>>> Suggested-by: Ananyev Konstantin >>>> Acked-by: Jerin Jacob >>>> Acked-by: Olivier Matz >>>> --- >>>> diff --git a/lib/librte_ring/rte_ring_generic.h >>>> b/lib/librte_ring/rte_ring_generic.h >>>> new file mode 100644 >>>> index 0000000..01f2cae >>>> --- /dev/null >>>> +++ b/lib/librte_ring/rte_ring_generic.h >>>> @@ -0,0 +1,202 @@ >>>> +/*- >>>> + * Copyright(c) 2017 Intel Corporation. All rights reserved. >>>> + * All rights reserved. >>>> + * >>>> + * SPDX-License-Identifier: BSD-3-Clause >>> The SPDX should be first line. See other files for Intel or NXP. > [Hemant] Don't add SPDX to this file. > This file is not BSD-3 licensed. Please keep the full text as in the original file. > > >>>> + */ >>>> + >>>> +/* >>>> + * Derived from FreeBSD's bufring.h >>>> + * >>>> + >>>> >> +********************************************************* >> ********** >>>> +******* >>>> + * >>>> + * Copyright (c) 2007-2009 Kip Macy kmacy@freebsd.org >>>> + * All rights reserved. >>>> + * >>>> + * Redistribution and use in source and binary forms, with or >>>> +without >>>> + * modification, are permitted provided that the following conditions >> are met: >>>> + * >>>> + * 1. Redistributions of source code must retain the above copyright >> notice, >>>> + * this list of conditions and the following disclaimer. >>>> + * >>>> + * 2. The name of Kip Macy nor the names of other >>>> + * contributors may be used to endorse or promote products derived >> from >>>> + * this software without specific prior written permission. >>>> + * >>>> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND >> CONTRIBUTORS "AS IS" >>>> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT >>>> +LIMITED TO, THE >>>> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A >>>> +PARTICULAR PURPOSE >>>> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR >>>> +CONTRIBUTORS BE >>>> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, >> EXEMPLARY, >>>> +OR >>>> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, >>>> +PROCUREMENT OF >>>> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; >> OR >>>> +BUSINESS >>>> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF >> LIABILITY, >>>> +WHETHER IN >>>> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR >>>> +OTHERWISE) >>>> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF >>>> +ADVISED OF THE >>>> + * POSSIBILITY OF SUCH DAMAGE. >>>> + * >>>> + >>>> >> +********************************************************* >> ********** >>>> +********/ >>>> + >>> This is BSD-2-freebsd, which is not a approved license for DPDK. >>> Can you ask Kip Macy, if he/she is ok to re-license it with BSD-3? >>> >>> Please check with legal, if you can just keep the copyright of Kip >>> Macy and re license it with BSD-3. >>> >>> I see the BSD-3 license to be permissive enough to be re-licensed as BSD-3. >>> But I am not a lawyer. >>> >> I agree this is something we should do, as a maintainer of librte_ring, I can >> do it. >> >> But here, Jia is just moving code in a new file. I don't think this should block >> his patchset from beeing included. > [Hemant] I thought of blocking this kind of moves, so that we get the license complaint of DPDK faster 😊 > > Jia, shall keep the original copyrights and headers in this file (i.e. No SPDX). You need to fix it along with rte_ring.h in near future. > > Regards, > Hemant > Ok, I will Besides ,I got the allowance from Kip Macy just now. He/She allowed dpdk to license librte_ring.h as BSD-3. My question: >Would you mind allowing dpdk librte_ring.h to be licensed as BSD 3 instead of BSD 2? His/her reply: "I think that's fine. If you're using it be careful I think there's a fix to memory barrier usage needed more relaxed memory models such as ARM. I'll check reviews to see if it made it in or not." -- Cheers, Jia