From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B56C45748; Tue, 6 Aug 2024 10:47:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A0F040EE4; Tue, 6 Aug 2024 10:47:18 +0200 (CEST) Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012024.outbound.protection.outlook.com [52.101.66.24]) by mails.dpdk.org (Postfix) with ESMTP id E4A0B40ED9 for ; Tue, 6 Aug 2024 10:47:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V4InHGiC6qr9frtSr5koxy7143akRlD/Yk5Ssr3aZGBp2aFNUnawczSISGUcec7ikam2RCk5CJsrVrV5oyiUSPvMbehAMdyavRT5mJX4mPAD38gYCU3+a/8nsqYLZtqa12DiuxIEUhJ/fwwRHfNabzWN6tYbrskSY/U+fsT35r1BiDFNEKT3bC9aOPcn8uWIHPW9Ajls5nA4IZYFIOQDb8/cX80MWqVrGJqnLik68GvmI1UJY39WviPFDd1OxB6z4JTAOU95NsNmWh1bK6DYonhF6CwJmeJWIT1/eeGdeuqd/b2qicSGbddesFMCjwa7l3XR4Na2irti4MPfI/Zk+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yfDMFY7CBeC6eiAwKlWIzK8aKrq6IzhjhhVQVoB9VoA=; b=e8sDRpmGydJ2N/L6tTFdPM+r+m45rXyWvvr0HTvbxgiaRROhlRuamiBrxfTMmU2Yyx20ikHJdreN3vRVzqXbA1MaCIyguJPfijD4v6hKDJMtrzXODqn4pBjiNporuMeCMvk2cB/Q4wh9kQI6IdbDPafunPkAcRmSgpXB+SEr+H5Tj2sr5o4mKibzj7JCkARIFDXlSUleGWakskFTFd2N+E4CBshiLjEbDY8i2xeHM2pl2zlNzB2QUUUjgB9iNf+UBjj9PGRv35NDG7BRgzyeghlp5qP2+PWSOkYk+sZcMmXtEl6fHijotFkJ/u5WDZDLRDLiY3l1NdgDL3vZtubaEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yfDMFY7CBeC6eiAwKlWIzK8aKrq6IzhjhhVQVoB9VoA=; b=rxbTg/Mw4fXgkhLYkd55smcTNotxID30DIzBcICcuMz7kGDa71FtlBrd8hs7x6Xqzm9BMVVT5x6rT6sFZHwjA9wePI54SsChA3ZXjb0oZTO8kKozH/d/XjV33AHXYwJlpk9W+hPmx3pp7vPBS+DTI3Pzp1mbhLJAzexCOaVZFqQzdt/nXXECu0T1MfVYCB3rvERikJAcxg2YhnrfDOXKd8z2Zbs7dpN5sjm4t3H35kScejDPKKJ7HIICWgHyIa8pSOOqbX2njunjaem6LllS7kNjce75YQaEJACB+1B3KvW2HkYdD9e+7q0Uc1u7q13J6MYILXkbZXaJGAJe08vljw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by PA1PR04MB10296.eurprd04.prod.outlook.com (2603:10a6:102:44a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.26; Tue, 6 Aug 2024 08:47:15 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%3]) with mapi id 15.20.7828.023; Tue, 6 Aug 2024 08:47:14 +0000 Message-ID: <6d6a26d5-0b3e-be07-e748-8754bcfc9f34@oss.nxp.com> Date: Tue, 6 Aug 2024 14:17:11 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [v1 7/7] crypto/dpaa2_sec: rework debug code To: dev@dpdk.org References: <20240806084136.3212615-1-g.singh@nxp.com> <20240806084136.3212615-8-g.singh@nxp.com> Content-Language: en-US From: Hemant Agrawal In-Reply-To: <20240806084136.3212615-8-g.singh@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SI2PR04CA0006.apcprd04.prod.outlook.com (2603:1096:4:197::13) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|PA1PR04MB10296:EE_ X-MS-Office365-Filtering-Correlation-Id: 76e067f9-0e9a-4a57-dfe4-08dcb5f45ebc X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cnpkSEpQTzYrS09XaWN4aWx3RStNcTJkUmM5UUJNMHY5MGZJOWY5ZXUzUWtq?= =?utf-8?B?Ym5OcUVLSzFpNmZkNXBWVFdHSS9KeEJGdlJZeUtpN2pJbnV3YlZrdjAveEVn?= =?utf-8?B?QWJVTVMxNXNKRWIxcWs1WGlScE13NU53eWtSQU5qdzVNRkdKbnpnMXlaY3hR?= =?utf-8?B?K292ZklWSllZY2pQTmNPUWhQYXNNemRTT0pranp6OUNNWGZLTUtXaWk4a21y?= =?utf-8?B?OW9YR0xhT3FYWmwvMGZneVJudmY1dTlaNHNEVmVwN3lNOWRtVWdIb0V0bTR3?= =?utf-8?B?UGFMUUNnSEVaNytRRFNnMUd1a3ROYmpWaWZQYTV0TjVEYm1kd1hvZFFOYnJm?= =?utf-8?B?QURKSXFCZ1gycy90MU9uSURBcWhRcGI2NDI2QUU4T01kMWhaQTlUd281QUpU?= =?utf-8?B?UW5xZWIvRm1vNkorc0JqV2JwWkhaSWVoYmFuc1hYZlJHM1F4L2NrLzBJRm15?= =?utf-8?B?Y05zSklCeHgzeTRpTzg3VnNrTVQvbjBwVVBhSFRBRzQ0T0kxTzVtZlVyUXVx?= =?utf-8?B?YWhYSXh4WDArQ0x5cndIMHlnaENwQktBL21YS1I3NUJ6dUZKM2s2TlpvLzV2?= =?utf-8?B?dnNqN0h1MGNqRHVWaWtIZFVHK0dJMnlHVW42UFd1cFZNUHJrakc1cGdZVjl1?= =?utf-8?B?ajVmRDN3RzZRd0t4RmNodGp2bEtUdFVTeEFYMHJNbGJkTm9yUVRvZUVVU3J2?= =?utf-8?B?SjFBSVNVVmsybHl6V3J0MVB3U1JHU1J3ZnVEd1pmbDJxd0Y3YkI5WG9rN0ta?= =?utf-8?B?QUI0bEQwSGpqRTJhZWJ2VDRySGp6dHZGdnUvckFwSWsrZnA2WTlyR2F6YjZK?= =?utf-8?B?eFdJTjhndjN4OWZSUHBYMWNqeXpTYlFsNUV3VHdrK2ZHVzE1U01VZFJ6elpx?= =?utf-8?B?MXhtakxMalVwUSs2QWl2WDdyQy85SnJHNE1xaFc3bkxKMzdMUlVTMkRGek9U?= =?utf-8?B?cmtPQ1ZFN21CVEhPVzBMbkFHL1JJa0JRY29NUGpiSmlTU3FTUlZRSTYydXNy?= =?utf-8?B?WURyS2tWaTBjTzFQVytiTDE1WTdERklJYzMzUkVpclo2UjA4RGRTeDJPQzhu?= =?utf-8?B?TjZ6K2tMejdPZHFlazRGVGxreE5HR1pEbkhxSEZPRVdqdlhVSGRJMFVqQXdy?= =?utf-8?B?SGRRc2VKU2pkekVUdEhNZDJTcE1xbkptRitIamVUeTlJZXBMOHBWS2dkajhF?= =?utf-8?B?M3hvMmoxeVlTaGErWE1TZGUrRUpNK0FYc3FVSmY2a0R5dW5zTDBKWGZGdmE2?= =?utf-8?B?UUhvOGNEQUFka1NTTVRkcysya1JubklueWJwQzVWZElvb3hwakphRy9yTEMx?= =?utf-8?B?RmpyWTQrOGYrYnZkWkg4ajJvRGg3NEJDZEtsa3FyQzBtWEwyakt3b3VRZ1Y0?= =?utf-8?B?VGNtOWl6citWMFlkbzcweHFsS2NBSk5IWVFWbnI1ZnR0UFE0RmVmeGtkbWZH?= =?utf-8?B?K0VJOWpxMnNuVmdaVHlsc05xNldDWENuNGM2b2FZMjhVaGRqY2NTR0NtdDZH?= =?utf-8?B?VkxTSE5td1pXOUMzdlhJQ0RGaFVPMmkvV3JkQ2JXNmRndExjL1FET0o4VWhv?= =?utf-8?B?RHptVGhLNkZ3Qk1LTW9mRnF1Y3dYdjBwUm5TdmJzSmltS1JteHEycEVaQjFY?= =?utf-8?B?dTEzRkdNeHRFT2RraW1OdTBhcGJtUlVMaWtJV3N1eGVTYkE0RWFDOW5oTWxV?= =?utf-8?B?Qkhkb3QyWWhuU2dMYjFMelV6RDRKaDFyQnZNZW5MYjlOcUREWm5JV29kWTNv?= =?utf-8?B?QzlPZmVtQlpaZTg2N0IrckNKRmY3Mml2Q25Gem9vZkdsZlNTbzBLWldYWGZk?= =?utf-8?B?bWZFMjBUekUyenUvY2RIdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UENlaHlCdTV6a3ZUK0NMejRGTzdtZjhHRjRZcDJsNGh3VlNjUlN2N0hlR2Zu?= =?utf-8?B?N2VndVFsSjIvSktxVGlld243RkhjSUVaY3BmRkR4ajduaFVkTFJ3UWRiM3Bm?= =?utf-8?B?VDl1S0RzSjZ5NjB1K0xqQUNVbGphNGxWcDcrc2xVZkFNbCtyMWlVR0J5Q1NT?= =?utf-8?B?QjFTZEUzYXl6ZVhpbVZhek83amtZZnE5R0c5Qzh0UnIvNDFoTmpjd056NmV6?= =?utf-8?B?VklXb2ZjQXFhS2hjYndML1JHMnNlTXNFcW90RjB3VXJwOGlIUXVuSjUwOUdi?= =?utf-8?B?RWpqblY0NWp3THNPWngzK2dIdjRCcHlOalZrOEpxL0crT3hIMWlDd3Y4WFF4?= =?utf-8?B?Y1FJOEZmZGc2bWNoQjhpSERFTGJ3bGlHWlpJY0V4SzIxdk5EdmhaLzNhWVR6?= =?utf-8?B?ckVlMEo1RWRxMTdsaDMyODBuZXYvWUMwZzhtamsvVTJXam5MNGEwR2N3WWNv?= =?utf-8?B?ZnNSaXdyTGZmaDBCV2VPbEFpNkpVL0VpSlMvMjdDYytZbC9uYktGNGs3T25h?= =?utf-8?B?RGlvWU45c1Y1RGMxa3Nhb2VPbUJ2YTRkY2sxcThnMXc1ZkZkQ2JuQlZpUFhX?= =?utf-8?B?ZitFQ2VnMHkyYVVRcjNTMXNUWnN5dDVpL1B5RExRTkhzM0NldGlhTzJwV0hw?= =?utf-8?B?bzkxSys3UzA3MFE4RURkcU5CbExldERXeEtmRFZvK2t3RDVwaDhHazdXNnl2?= =?utf-8?B?TGFIQVJKZkFkMVhiZGs1TGk4ejRoNTU5aGFwM3ZadjNkaUpnZVRIMUtFM2Vu?= =?utf-8?B?Ni9VNGU1VnRBbWJMU09JVXJHdWgyNEFoQ1ZpM1B0cFpvLytnL08xdDNDblpQ?= =?utf-8?B?TVlZaFdaSGhzUld6QmU1RTd4bXpkTFhldUJtalNxTk9tZjZKTFRNZCtHYUh3?= =?utf-8?B?SytySWRMVU54K3YyaVJvektSMFNCZW5Vbm5RSi9lTFNweFp1NmMwNjF2dWEr?= =?utf-8?B?K3ZnTExQM1JrcUVsVXZDS1IrRjg2T2MzVVk4b1J0N3VXMXhLdFM1QmQ0Q2tO?= =?utf-8?B?T08yZHQvbDJycmZHa01IUGR5U1pGN3JwSHpUNjQvTXQvcUdjdFJPOW5UYWFX?= =?utf-8?B?S0pWWklyM05CTXNLelBVekU1am5ETk1UTStCME1XV3l6UnFxWFN1b3ovd0ZW?= =?utf-8?B?NmpDTVpuT0FLend2NnNnNEJpQi8zaU0vNmVzU3pXYjFLbERMaS9XOS9sOG4w?= =?utf-8?B?WTZUYXNQMlBodm8xTnhNL0NudU5BU2xEdDdQd1g1QjR3UnRhTHJYeFJVa09O?= =?utf-8?B?OGttMC9YSHZDWTMzcHpudUw1dEkxTVlrQy9GN052b3U4UE94MEd3KzJRSUpR?= =?utf-8?B?RkFlUTJ5MkdPY09BMXlPbWtwSG45Nk8yZUxnaWtYZVZTdjZIOHZaNGNKdVQ3?= =?utf-8?B?cUQ5RVRMMlI1R1RleXNkYTNzQjNFd280M2JqTlU1TmE1U0c4WDJMbHdLcjBh?= =?utf-8?B?dXlRMWZuY0EvRFlLMzY4elJXaUhmWitFWmpvT2ZpNkVYeTlId3pJb0FzS3NG?= =?utf-8?B?b2I4OUlSOVkvcE1RaCtxT2pTUy81Y1VacGlSK1l2U0FxWUpyWW5GZVVCV1pG?= =?utf-8?B?Mm5ZYnByL0FRRjNaclQ3elVRL1lmNUppeHJPNHBhd3paRWoxOERRNnZPZ25I?= =?utf-8?B?SDd1TUNNVDd3bUFQaXpPU1Zwa1BKY2RZTUVJMms2azl5VkZ6WHkydFgvT3ow?= =?utf-8?B?aFh1N1dwTXZOaWFDaWhLeFVWcVdla3BRaVp0MHJrQmxhNjdhekthckIzeTF6?= =?utf-8?B?MXdjZHNLOGFVTERUWHhTR21WcEpTbm1WeHFzT0puK1JuK0JiclJrUzlEVlla?= =?utf-8?B?UFhhTyt1VW5sK0RtT0N4c09lTWpZZ3RUbWZxRHgwU1hvTlBDZ3lIRUxLTWcw?= =?utf-8?B?dHZpSUR4a3ZRemJjRmNmN1d3YTFFdXdLcXI5VmtkMGxRRyt2U0cxajQ5SWx2?= =?utf-8?B?V2wxNUNYRCttMWxXcUxJVXlCaUJPcS9BQ2hja1RUQTNXQndZSWk0MDVCZ05s?= =?utf-8?B?eHdQbGJjNUROVFNYV3dPd3FGdU1lSWcwZERtTkZTTkR1bEU0KzlzMHBKeWRZ?= =?utf-8?B?Ly92VWFmcUhvTjZ4dG54VHZWdyt6UXJDQm4zSzUzUDUrejJYTHFMNzlDZmEr?= =?utf-8?B?Z29KV3NJUFYwTS9uYmxzWGlES05xcHB5T1ZRYmgybEZybkxJb0ZxUjJqSFBW?= =?utf-8?B?amc9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76e067f9-0e9a-4a57-dfe4-08dcb5f45ebc X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2024 08:47:14.9158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mTs+OOXMZAT2eRS/520yjXGjEEN+oM6YtBun4llqQkUsuIlWuk7ScFCsXusMf0Nb1yusX38zY5rT+JbSCDMsJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10296 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Gagan, On 06-08-2024 14:11, Gagandeep Singh wrote: > From: Jun Yang > > Output debug information according to various modes. > > Signed-off-by: Jun Yang > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 63 ++++++++++++++++----- > 1 file changed, 48 insertions(+), 15 deletions(-) > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 1e28c71b53..da3bd871ba 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -1095,7 +1095,7 @@ build_auth_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, > > static int > build_cipher_sg_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, > - struct qbman_fd *fd, __rte_unused uint16_t bpid) > + struct qbman_fd *fd, uint16_t bpid) > { > struct rte_crypto_sym_op *sym_op = op->sym; > struct qbman_fle *ip_fle, *op_fle, *sge, *fle; > @@ -1105,6 +1105,10 @@ build_cipher_sg_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, > struct rte_mbuf *mbuf; > uint8_t *iv_ptr = rte_crypto_op_ctod_offset(op, uint8_t *, > sess->iv.offset); > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL) > + char debug_str[1024]; > + int offset; > +#endif > > data_len = sym_op->cipher.data.length; > data_offset = sym_op->cipher.data.offset; > @@ -1210,14 +1214,26 @@ build_cipher_sg_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, > DPAA2_SET_FD_COMPOUND_FMT(fd); > DPAA2_SET_FD_FLC(fd, DPAA2_VADDR_TO_IOVA(flc)); > > - DPAA2_SEC_DP_DEBUG( > - "CIPHER SG: fdaddr =%" PRIx64 " bpid =%d meta =%d" > - " off =%d, len =%d\n", > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL) > + offset = sprintf(debug_str, > + "CIPHER SG: fdaddr =%" PRIx64 ", from %s pool ", > DPAA2_GET_FD_ADDR(fd), > - DPAA2_GET_FD_BPID(fd), > - rte_dpaa2_bpid_info[bpid].meta_data_size, > - DPAA2_GET_FD_OFFSET(fd), > - DPAA2_GET_FD_LEN(fd)); > + bpid < MAX_BPID ? "SW" : "BMAN"); > + if (bpid < MAX_BPID) { > + offset += sprintf(&debug_str[offset], > + "bpid = %d ", bpid); > + } > + offset += sprintf(&debug_str[offset], > + "private size = %d ", > + mbuf->pool->private_data_size); > + offset += sprintf(&debug_str[offset], > + "off =%d, len =%d\n", > + DPAA2_GET_FD_OFFSET(fd), DPAA2_GET_FD_LEN(fd)); > + DPAA2_SEC_DP_DEBUG("%s", debug_str); > +#else > + RTE_SET_USED(bpid); > +#endif > + > return 0; > } > > @@ -1233,6 +1249,10 @@ build_cipher_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, > uint8_t *iv_ptr = rte_crypto_op_ctod_offset(op, uint8_t *, > sess->iv.offset); > struct rte_mbuf *dst; > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL) > + char debug_str[1024]; > + int offset; > +#endif > > data_len = sym_op->cipher.data.length; > data_offset = sym_op->cipher.data.offset; > @@ -1324,14 +1344,23 @@ build_cipher_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op, > DPAA2_SET_FLE_FIN(sge); > DPAA2_SET_FLE_FIN(fle); > > - DPAA2_SEC_DP_DEBUG( > - "CIPHER: fdaddr =%" PRIx64 " bpid =%d meta =%d" > - " off =%d, len =%d\n", > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL) > + offset = sprintf(debug_str, > + "CIPHER: fdaddr =%" PRIx64 ", from %s pool ", > DPAA2_GET_FD_ADDR(fd), > - DPAA2_GET_FD_BPID(fd), > - rte_dpaa2_bpid_info[bpid].meta_data_size, > - DPAA2_GET_FD_OFFSET(fd), > - DPAA2_GET_FD_LEN(fd)); > + bpid < MAX_BPID ? "SW" : "BMAN"); > + if (bpid < MAX_BPID) { > + offset += sprintf(&debug_str[offset], > + "bpid = %d ", bpid); > + } > + offset += sprintf(&debug_str[offset], > + "private size = %d ", > + dst->pool->private_data_size); > + offset += sprintf(&debug_str[offset], > + "off =%d, len =%d\n", > + DPAA2_GET_FD_OFFSET(fd), DPAA2_GET_FD_LEN(fd)); > + DPAA2_SEC_DP_DEBUG("%s", debug_str); > +#endif > > return 0; > } > @@ -1564,6 +1593,10 @@ sec_fd_to_mbuf(const struct qbman_fd *fd, struct dpaa2_sec_qp *qp) > struct qbman_fle *fle; > struct rte_crypto_op *op; > struct rte_mbuf *dst, *src; > +#if (RTE_LOG_DEBUG <= RTE_LOG_DP_LEVEL) > + char debug_str[1024]; > + int offset; > +#endif you have defined these variables but not used?  have you missed something in this patch? > > if (DPAA2_FD_GET_FORMAT(fd) == qbman_fd_single) > return sec_simple_fd_to_mbuf(fd);