From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03hn0238.outbound.protection.outlook.com [104.47.10.238]) by dpdk.org (Postfix) with ESMTP id E15591B4BA for ; Fri, 13 Jul 2018 08:32:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yKu4/WklMbUIS91rusa3sU3uxL4yd8ccxtyZsev+Jho=; b=mt8vhT3qoxvXBrUosukVAVL1fLuyC6FAmhdpriFuITPlzZCL+DSUTpfK9FgSap+yVoMhg1Mh2NTdIEIgEmdtEPS58nvWmbNa3TlrhO1i47w9Ldkq53fTAZjmyNf5rnJu+i6eKPA2GrtnboKUkQxI0h/Vvajt+61vHKWJa4fdgW0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by AM0PR04MB4675.eurprd04.prod.outlook.com (2603:10a6:208:75::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21; Fri, 13 Jul 2018 06:32:39 +0000 To: Thomas Monjalon , Hemant Agrawal Cc: dev@dpdk.org References: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com> <1530864613-11754-16-git-send-email-hemant.agrawal@nxp.com> <2191617.RJdI2X8ch5@xps> From: Shreyansh Jain Message-ID: <6d77cb11-a208-9075-592e-71f6396568ea@nxp.com> Date: Fri, 13 Jul 2018 12:02:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <2191617.RJdI2X8ch5@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR0101CA0004.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::14) To AM0PR04MB4675.eurprd04.prod.outlook.com (2603:10a6:208:75::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d72caf91-45ac-48ef-96d2-08d5e88a6e68 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB4675; X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4675; 3:jj9VnyBzatO9Jo2G1l8lIxuWqmvXzlaG5OPyISrHKfDA0oLuJYtgBi0XcnaNnHxRR5cM1+qXBcbqOxjwL6mMchPOCHOuApL2SD4XBvFg+K8Smsie8JmVydK2uDl8OcRpfshYeBFuw3HnMzduxbmoZKY4lkQ4ZlnFBUzWp4pc8V28dPRzZyI4xemManTPA075jFjaS5D1r3x/pbp9cipkn57oRayHVGRS3QyKumCNH4thH9Bu/r84UUb94zKGOHTy; 25:xaHFc1xk8W0LVH3gwz+dT+PhyuYC+LvU8xX75ZMnHPGS6ErZ7t7pMBhzT5BLB/mfUkGF6UMZ7jIvWtZLwXnLkpjsQsHT2XrsJIxtE+xmS5M2IuXloXDCBV/y3dZzW8w6ctIwxB92DeoKogzkA3ShGu0nSM9QclI8XUfw8vmUvG6ifAZETtIz8Fe2J1bBkcATFUfRzOFTVeicMVLirFRwSx7+rs+9wv2kuj8YigHNgVAt27DKwauvlrv1t428GB/eJVAA1EAlNnrbWSXSVgn76sWtZryUDeGfls412PdzbeBmDkGqOvNKRdBPIgLgyhonJI4mdZp6iUfgqiWzVry7Aw==; 31:8daTkJiwT2O8ZH4E+Autw8gyH1/KfAo6efwbsNV3m16sD4OfkNGzCXBhHGv4B6a0FLRrVLY94ElWltA4DHkRWzvBs7zEJ/ZevLV+QHKTMow+GLRZXQvr0wY3oG6OEZLIHorUfiu0Li0RAr0OwsAFo5ZRGoqrU/oLmNc41qnyWBi3Xf+hQvEVg8m1cB2ZB8xIFf8lKtF8KNGTkvI/SSpj3ZfIUUTtH9c4wq0tzZERleM= X-MS-TrafficTypeDiagnostic: AM0PR04MB4675: X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4675; 20:n3yNATQBaSFw2I8rMstBA+5E3wLb0n6iXw/cC4nA8dG1onQPG3PUsDgAOk+An2d9UUv3wA9D/oxlgNrZNU9esPADE9Ln7/1NgNjU2WBnZe+0hyyOhyNOJcViVWeUM8CxJOlLlN3Te+W4OudugRKf2uFIRJyCUzphTS0ecnFwQ9uyrBdTUiVXrfIlz//UuaEVIrbPFW8LUaQ/vGeN+m1Qi87+kmmXl1kyshh7nVaT3+EvmYQqjqbaifvL7PGogTESYE71VVSjbtDxFL2nx1h26rDvc/BHnDBSBrwExXabduHgL+EE8vJJLJC8wQYmNpbXuzL+zEcAKBR+jZPYRILDmnDH0nw1r1dTdRdvwBIJfNq54yQmZHNu/ZWExSEI0Bieb8i/v/OcgefR34QHM2ykBV9nryBeCUukKgQVPEYOE2+OBBtIRBb2ONKbVJHHnRRJLXjuP9nBNUtNsji1C/cXDya5US96mcloJVQ7ewbp15vf6/bS00v4TfRcbkMSZzfO; 4:aXRHG/P+a5F3jd2LB9iyRT9Xmd+x9FkxdU6g+LhqLXyVuH/JKm8UA9uCl3dAgMGdfdQ6cKKwkvjBhVrn1pU6Jv+sxgirlD5yk5nbdUDgFb+z/eKrF7YKQHm/KJOBbkF+lCdWnlxDHSB8liQ8VALDwCN3AyIpa6BkqbIOBYjmhWCegPhTYA+HhwiorghM4u6y1sAnYKnNc/SYekMkhzKHHuRMHLPK2dgWSXUiDv8n0vd8QpPasp1f7dZ3eL1ApeEOORqdQBdOUi27QBrv3j25SA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:AM0PR04MB4675; BCL:0; PCL:0; RULEID:; SRVR:AM0PR04MB4675; X-Forefront-PRVS: 07326CFBC4 X-Forefront-Antispam-Report: SFV:SPM; SFS:(10009020)(6049001)(136003)(396003)(346002)(366004)(376002)(39860400002)(189003)(199004)(8936002)(67846002)(6486002)(6636002)(486006)(23676004)(11346002)(110136005)(77096007)(16526019)(16576012)(2486003)(575784001)(36756003)(446003)(31686004)(186003)(105586002)(53936002)(106356001)(476003)(386003)(52116002)(2616005)(64126003)(6246003)(6306002)(52146003)(316002)(55236004)(229853002)(86362001)(44832011)(4326008)(58126008)(5660300001)(6666003)(68736007)(2870700001)(7736002)(2906002)(31696002)(26005)(76176011)(81166006)(6116002)(50466002)(5009440100003)(47776003)(3846002)(8676002)(97736004)(966005)(66066001)(65826007)(81156014)(65956001)(305945005)(25786009)(65806001)(93886005)(478600001)(956004)(533714002)(110426005); DIR:OUT; SFP:1501; SCL:5; SRVR:AM0PR04MB4675; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTBQUjA0TUI0Njc1OzIzOmN1Ky9RM29zdng5SkVvcGJFZzdmY2gyV2ZY?= =?utf-8?B?ZXZQaERqY2krMWpoSjErSXZNb3p4UkRQb0JGMjNmdFZVdGhBZ0NaT1pXR2h3?= =?utf-8?B?LzJFUnZxWEtKOHRBVitUckpNV09mbk5yZHMxaGQ3bTVmNTZlUXVKNUw0amRX?= =?utf-8?B?SW10bVFHN1lJcmR2dnIxTFNEQkE4UGZZTEkwUStZeUo0RHBsSWhBRzdVUVYv?= =?utf-8?B?eFR6TDhuYlpDWTJLY29ldjlrQW13SjNNaTdMaWFUbGFmUjBjSlVvWENZUkhq?= =?utf-8?B?QkE2Rk5JbFMrRXlHY25OTGdiYk5WTkIzV2E4OGwzTThsSmpXakNNVFEwL2xl?= =?utf-8?B?V0pwNmUyWnBiMXJiNzhQWHptNzNlOWdQRkdEQjRQRGhRM0Z0R1UzdFNyUXJH?= =?utf-8?B?Z1krUUx2dkJoSmpsQWVsbEhNTEt5VytWQ2pldndaVmlUUVpQeTh0K2EwcTZu?= =?utf-8?B?VzZGSHRSQUg0Szk4bVNVdkhMUjlOM0VXaUtXNmxubm5SMjFzdzhGZ1V5aFpB?= =?utf-8?B?SEd2WWdVVUc0NDNHNjUwY2JoUlEvQVlURVVIZDB3a3RMVFpVYzA3OWZhTnBG?= =?utf-8?B?RGxpd1AwQVh6RHMvQTVZRVMydEtDK1pQSG1CczlPaWY2TU96NEpsZ2RaRTVC?= =?utf-8?B?ZVNIQ0MyOCtjOUlrdVJkM3h3UEdhcEhBMXRpbVpnSFlORnE2dzVTU3d2VmhL?= =?utf-8?B?M3lIb0N1T0Rpd2tZOXZ5SlU4SkNzVDJsZnpva1JHeUsyVkdyQU5Yc3FIN0RO?= =?utf-8?B?enI5aGNNNkdlQUQ5VjNsU2pYSysraUtjS1V0ZkFxNDV3dy9CVEN4dGp1WVBn?= =?utf-8?B?L250ajFrcllxL3FQdmZnVTNsL3pJa0xxUW5RSGRXY1UwV0YvZTNwNEVhSVpB?= =?utf-8?B?Y3owU1ZZbStGdkZiUCtoZjRsT0laRk9wZG1ITnZGMVM5M0NZdnZEL2dCRkpW?= =?utf-8?B?QTY5N29MdHdpelI4NEdRNmg0azIzL3FxdFZwMHl4aTRzSDlYdWlYcU1TZDFj?= =?utf-8?B?MWM1TDRNSElOODVMN1ZOTk9qZGRHa0h0WEYya1NDQkZkNW8rWU9adjRDQXpw?= =?utf-8?B?Ny91d0JQRi9vRTRYNnZXbUw1SVJjcm9Sa21jQlUwSWNNaHBjb213Z2l1VVhi?= =?utf-8?B?SDJ3VXdYUmZEcWdvTGJ4Z2N5VG9YSEJNSTNvM2ZQYkdreUtMemZ0bTFUdGtz?= =?utf-8?B?dE96QlZmaE83bE5FemRSa3AwMVdNd29TV0JkY21OeW5CQWlkYmU3Q2MxV1c1?= =?utf-8?B?YzI2WHRxb001eE5HU2dVeFd2MkpjNlRsKzVJdjF5cHdFdzVXZ2pTYVdzeTM3?= =?utf-8?B?c1pzQTU1WXkwaGRKY3J2WTR5T2RVUTdlUlFZR25NNVd3cG4rU0VOOGhWR1Zl?= =?utf-8?B?UEtHQzFpMTRUclVDeDBZUTIzdlNtaFhnWW85N3N3ZWowVVZTYkdxL21sS2hK?= =?utf-8?B?TXhqMVU5MHVVZWl6V0xabUFWcmFDWjZoSGJGckk5MmRBOURMQXlZMzZzQ0dC?= =?utf-8?B?YllqbVlXZG9RMno1Rlpvd1U4NGtQQ1V5cEhycUo1bzF2RzUzS3ljNEFYMWlJ?= =?utf-8?B?NmhXbVg1M2IyT1Y2bGQzeTV1RlJ6NDRnODdBSnU1ZE1XTmhMUDZzbnFpZ0xo?= =?utf-8?B?SWU2WEhvK2thNEhGVXlRdnJGelY3LzB4SEJHbGJ2SkNPUWVNTlh5OTk3dDI1?= =?utf-8?B?TlFSczZCYWRLK3YxNFJ4ZTNSTndXdFhFc0hocG12aWkwZlIvb3QrR1FmRVJv?= =?utf-8?B?cHpMOTR1dTNaV2I3NnBIOVh6NExCdmJDZVhCQTVzSnEwK3JjNk9IMndQdXFY?= =?utf-8?B?UUtEdkZjVTRVWUxyZkhxMmJQejJ6SEpFREQyMUk0S2FRK09DRUZvVXZraWUr?= =?utf-8?B?OXZ6M0lHMjgwWVI4SU9Mbit4RkVkblRCUXY5QXJ5bzcwd1BLdkMxdnA4SFRl?= =?utf-8?B?RzJlR0I4aUw5bXU2LzdWYXhLd1ZjR25HcWpqdDRnUUh0M0gxVXYvNzJqTTlZ?= =?utf-8?B?YVFDRlI5R3YyNlp1a1JBMVJnb2FVU1hzdElTdUMwQ2FyTm1wc3k5UUwwVENY?= =?utf-8?B?SEFuenBrRFo2V2dwdE5QQmxkbVRTcVo2a2Y2SW8vbk0xNlo0UDdNeitCM2pF?= =?utf-8?B?RTNhOENzKyswazJoYXAzdmMzOGFLQndHdjA1aTF3clY0SGNKbWNhMDVhRWwx?= =?utf-8?B?Mm1nUS8vSlZXRWZ4Rm84bDUwNWxPM2NTVkUvVTZSYXlrL0RRc0JwcXRnU0FL?= =?utf-8?Q?GgZ72OCFxrMVrsICkO?= X-Microsoft-Antispam-Message-Info: /yd7V3udzWNc8TOp999rrs4wNHbHvycLzPRNQBWvEAf+KPGJISVPzprLmGq2mnQqCyWPLgW3ywGiodduXsAHv5FTCGbnEsBvgzSuCP/RmsAZnYNi4oO0T//WXQ2RS9WdWOkvVWVW9YURqzNxcalIfQbHTaaRWAEnW+efU2hEvLF0BujXej+rAM9ffEctU5AxIt1XHAyzU8riFC7M5c+iVROcw9qVa4MUkSU+gctug/IRzO7T7AXvAGej2D5+S2DjJeTvJTuzO/brD3KaSQK0wfs2dO/XpmhyGmLwknmku5KLt9//TVJVU5VQVRvtu5xiaRrhPrRBvI06QrjAQ7fOqTG6QcSw+4EPO3qQF+kPfbn+OZbDpGpz78bgys/dVrxAQYVUtxnRV+HBrsaAordfZB/2ZxeJJe11WZDT8K4F9ywtk4cDRrAX0SfHBp+dCWs609Xt6ImZE8drHkr3CBlEOZCm4q8YlkTlSWHvuNTbL6yQpuJpKoMnOaPn+eMoNASeXbS1apkhHnnaOKTkTVmSCrqGXd/KS7EAYxQDm+MXxWi2qD7xVISamHOOa8yBVFeCk3SCKYa9ur4gMU2RJ1l4Fw== X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4675; 6:NX6eay8nnk/BsrYSzkeSmmJLQCXv1xM/S2Wachw+ybr85io4TZq/lDmIBiaCyZYOBDudB/FGhKf26drrgBlwTc9ajWClaspPeooDyvfDApQ3Z3bgmPQXJUIZHVAWiOAAyPAf62JS7/Xo/n3UNR9Q1rjttbGiB2Qfd/ZTS/qZp9vf4bfJp/EBXiOwRvfmc8m6zfus3MCcLsWlkBKMnwNv+zOepQArtSw8Ty/SdcmUolPKg85gEd8R6VW8xmZpyPPYSwhGRxehFHbyw2bc/CNV9xXgJqMh0O/r1mvBmieNcf08DdHKjtCVA8Dy6tvTAPi9kd5ZAyUfJ4E1zTEa48EnvV3tKqgwg8F/mKIacQgl3b4QfKMDD7+SgOI4mLMB8Sh3mxkltno77337z0qwoMtrQa8tjQdnIORdCrx5IGAYHKjrLqPDq2bpux6SmEi09GITmunx5/13gBszqbybLKNF1g==; 5:ibKBC4yKlhzMmlvwO73Ilf+R3Sq2iuyaifuUahqxitd5G9+cYwB+0aWtXf5CVHDbSGNJAuZbD5H586CT/hlqNko+rkjHlA1C6/NGG5RAF8PWuV5LnfPEFX2dj+WJQm06r/nogMLFd6mDNz009lXZWNM7uANRiOeaLAfNTjHGpZM=; 24:Ppf5KB3T/2z4VCACYe2GLkjVzK+4vxYI8z5x0j7Tg11gxRHYM576BTWV0EpmrVGt7frk/wQ5PL94N+L+i+cCww== SpamDiagnosticOutput: 1:22 X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4675; 7:EjMuAtNedy06VumDl5GnNP1PX2M6e9gjrvW93EQgi3E7pOi6D5JEbCBUl2gdScX6yk1mYpmM0fzl92mjk2oDEPK2Zr9SRjApsYhCVZGHdDqBUAlvw6fJXqMzAvfSlc+34mTUSWw3bvoBtkTipLQXWYGGVOPa6Ey+N0YcKNa3qqRKHmPrFj9LP0jPHGoWtt5mpQ2lZOzoo+koTWezQCS+7Zk565ufhCzzaeq8b0AYvkjskKRxHr/f5evisKAQ3r86 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2018 06:32:39.0303 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d72caf91-45ac-48ef-96d2-08d5e88a6e68 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4675 Subject: Re: [dpdk-dev] [PATCH v3 16/16] net/dpaa: implement scatter offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 06:32:41 -0000 On Thursday 12 July 2018 05:53 PM, Thomas Monjalon wrote: > Title can be "net/dpaa: support scatter offload" > > 06/07/2018 10:10, Hemant Agrawal: >> + /* Max packet can fit in single buffer */ >> + if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) { >> + ; > > Why an empty statement? Its just a way of collating the cases without deep cascade. If we don't do this, it would just mean having multiple if cases - either cascading or segregated (non if-else). Either way achieves same result. > >> + } else if (dev->data->dev_conf.rxmode.enable_scatter) { > > error: ‘struct rte_eth_rxmode’ has no member named ‘enable_scatter’ > As for this, it would be because of another patch on master: ab3ce1e0c19 which was not factored when the tree was reviewed. So, this is a merge conflict. Or, maybe a rebase on an old tree before posting patches. Also, for your comment in [1] - this patch doesn't really need a context - it is a feature and the headline is self-explanatory for that. [1] https://mails.dpdk.org/archives/dev/2018-July/107793.html